Re: sim/arm/Makefile.in fix for non-GNU make

Andrew Cagney
2001-11-15T22:06:00Z

> [ Now with a ChangeLog entry ]

In the wrong place :-)

> sim/arm/Makefile.in currently uses $< in a non-implicit rule. This
> doesn't work with non-GNU makes (at least NetBSD's one) since $< isn't set
> for non-implicit rules. This patch fixes the problem:

Yes, thanks, it can go in. If you find more of these the I think they
can be considered obvious.

Can you also, separatly, add yourself to the MAINTAINERS file as an
``obvious fix'' (ie still post the change).

enjoy,
Andrew

> Index: Makefile.in
> ===================================================================
> RCS file: /cvsroot/gnusrc/gnu/dist/toolchain/sim/arm/Makefile.in,v
> retrieving revision 1.1.1.1
> diff -u -r1.1.1.1 Makefile.in
> --- Makefile.in 2000/07/26 00:34:28 1.1.1.1
> +++ Makefile.in 2001/11/15 14:57:19
> @@ -31,10 +31,10 @@
> armcopro.o: armcopro.c armdefs.h
>
> armemu26.o: armemu.c armdefs.h armemu.h
> - $(CC) -c $< -o armemu26.o $(ALL_CFLAGS)
> + $(CC) -c $(srcdir)/armemu.c -o armemu26.o $(ALL_CFLAGS)
>
> armemu32.o: armemu.c armdefs.h armemu.h
> - $(CC) -c $< -o armemu32.o -DMODE32 $(ALL_CFLAGS)
> + $(CC) -c $(srcdir)/armemu.c -o armemu32.o -DMODE32 $(ALL_CFLAGS)
>
> arminit.o: arminit.c armdefs.h armemu.h
>
>
> ChangeLog entry (suspiciously similar to one from 1997):
>
> 2001-11-15 Ben Harris <bjh21@netbsd.org>
>
> * Makefile.in (armemu32.o): Replace $< with autoconf recommended
> $(srcdir)/....
> (armemu26.o): Ditto.
>
>