From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mark Kettenis <kettenis@wins.uva.nl>
To: drow@mvista.com
Cc: gdb-patches@sources.redhat.com
Subject: Re: [PATCH] Make ARM/Linux build on current glibc
Date: Wed, 31 Oct 2001 10:18:00 -0000
Message-id: <200110311818.f9VIIRb21686@delius.kettenis.local>
References: <20011031105747.A2009@nevyn.them.org> <20011031105828.A2045@nevyn.them.org> <s3ilmhr23gn.fsf@debye.wins.uva.nl> <20011031112035.A1749@nevyn.them.org>
X-SW-Source: 2001-10/msg00395.html

   Date: Wed, 31 Oct 2001 11:20:35 -0500
   From: Daniel Jacobowitz <drow@mvista.com>

   On Wed, Oct 31, 2001 at 05:12:40PM +0100, Mark Kettenis wrote:
   > Daniel Jacobowitz <drow@mvista.com> writes:
   > 
   > > On Wed, Oct 31, 2001 at 10:57:47AM -0500, Daniel Jacobowitz wrote:
   > > > <sys/user.h> no longer includes <asm/ptrace.h>.  If we want it, we've got to
   > > > get it ourselves.
   > > 
   > > Right... include the patch..
   > > 
   > > Committed as obvious.
   > 
   > In principle we shouldn't include any <asm/*> on Linux.  Why do you
   > need to include <asm/ptrace.h>?

   Because <sys/user.h> used to and no longer does.  If you prefer I can
   define the structure (pt_regs) in the file itself.

Ah, I missed `struct pt_regs'.  Hmm.  On the i386 ptrace(PTRACE_GETREGS,...)
doesn't return a `struct pt_regs'.

   <sys/user.h> now uses a "struct user_regs" instead, but we can't use
   that without requiring glibc 2.2.x.

I'd use elf_gregset_t instead.  Should work with all versions of glibc
as long as you include <sys/procfs.h>.  Looks like there's quite a bit
of redundant code in arm-linux-nat.c.  Feel free to clean it up a bit :-).

Mark