From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Kettenis To: gdb-patches@sources.redhat.com Subject: [PATCH] Use extract_typed_floating in i387-tdep.c Date: Sun, 28 Oct 2001 06:43:00 -0000 Message-id: <200110281443.f9SEhmQ11624@delius.kettenis.local> X-SW-Source: 2001-10/msg00345.html This certainly cleans things up. Committed. Mark Index: ChangeLog from Mark Kettenis * i387-tdep.c (print_i387_value): Use extract_typed_floating to convert RAW to a DOUBLEST instead of extract_floating. Index: i387-tdep.c =================================================================== RCS file: /cvs/src/src/gdb/i387-tdep.c,v retrieving revision 1.14 diff -u -p -r1.14 i387-tdep.c --- i387-tdep.c 2001/09/21 12:15:15 1.14 +++ i387-tdep.c 2001/10/28 14:05:15 @@ -165,25 +165,12 @@ static void print_i387_value (char *raw) { DOUBLEST value; - int len = TARGET_LONG_DOUBLE_BIT / TARGET_CHAR_BIT; - char *tmp = alloca (len); - /* This code only works on targets where ... */ - gdb_assert (TARGET_LONG_DOUBLE_FORMAT == &floatformat_i387_ext); - - /* Take care of the padding. FP reg is 80 bits. The same value in - memory is 96 bits. */ - gdb_assert (FPU_REG_RAW_SIZE < len); - memcpy (tmp, raw, FPU_REG_RAW_SIZE); - memset (tmp + FPU_REG_RAW_SIZE, 0, len - FPU_REG_RAW_SIZE); - - /* Extract the value as a DOUBLEST. */ - /* Use extract_floating() rather than floatformat_to_doublest(). - The latter is lossy in nature. Once GDB gets a host/target - independent and non-lossy FP it will become possible to bypass - extract_floating() and call floatformat*() directly. Note also - the assumptions about TARGET_LONG_DOUBLE above. */ - value = extract_floating (tmp, len); + /* Using extract_typed_floating here might affect the representation + of certain numbers such as NaNs, even if GDB is running natively. + This is fine since our caller already detects such special + numbers and we print the hexadecimal representation anyway. */ + value = extract_typed_floating (raw, builtin_type_i387_ext); /* We try to print 19 digits. The last digit may or may not contain garbage, but we'd better print one too many. We need enough room