From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eli Zaretskii <eliz@is.elta.co.il>
To: fnf@ninemoons.com
Cc: gdb-patches@sources.redhat.com, fnf@ninemoons.com
Subject: Re: [RFA] Change auto-solib-add to boolean, add auto-solib-limit
Date: Sun, 28 Oct 2001 01:54:00 -0000
Message-id: <200110280853.KAA01884@is.elta.co.il>
References: <200110271948.f9RJmLd08493@fishpond.ninemoons.com>
X-SW-Source: 2001-10/msg00342.html

> From: Fred Fish <fnf@www.ninemoons.com>
> Date: Sat, 27 Oct 2001 12:48:21 -0700 (MST)
> 
> In the current gdb, auto-solib-add is used as both a boolean and as a
> limiting size in megabytes.  This patch removes this overloaded
> meaning.

The patches to gdb.texinfo are approved, with the following comments:

> +There are times however when you may wish to not automatically load

I think we need commas on both sides of "however".

> +@kindex set auto-solib-add
> +@item set auto-solib-add @var{mode}
> +Set the shared library symbol autoloading mode.  If it is @code{on},
> +symbols from all shared object libraries will be loaded automatically

I think this sentence will be much clearer if you begin it like this:

  If @var{mode} is @code{on},

> +new library has been loaded.  Otherwise if it is @code{off}, symbols

Same here: Instead of "Otherwise if it is @code{off}", let's say "If
@var{mode} is @code{off}".

> +To explicitly load shared library symbols use the @code{sharedlibrary}
> +command:

This needs a comma after "symbols".

> +reached.  This provides the benefit of allowing autoloading to remain on
> +by default while avoiding attempting to autoload excessively large
> +shared libraries, up to a threshold that is initially set but that you
> +can modify if you wish.

This sentence is in a dire need of commas ;-)

Also, "while avoiding attempting to autoload" sounds awkwardly.  How
about "but avoids autoloading" instead?

> +@item set auto-solib-limit @var{threshold}
>  Set the autoloading size threshold, in megabytes.

This leaves me wondering: can the value of threshold be a fraction,
like 0.5?  I think this should be stated in the docs.  (Yes, I know
that it was so before your changes.)

Thanks!