From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Jacobowitz <drow@mvista.com>
To: Andrew Cagney <ac131313@cygnus.com>
Cc: fnasser@cygnus.com, gdb-patches@sources.redhat.com
Subject: Re: [rfa/testsuite/mi] Recognize a few incorrect outputs
Date: Fri, 28 Sep 2001 15:54:00 -0000
Message-id: <20010928185435.A24623@nevyn.them.org>
References: <20010928151616.A14106@nevyn.them.org> <3BB4DEBB.1020906@cygnus.com>
X-SW-Source: 2001-09/msg00442.html

On Fri, Sep 28, 2001 at 04:34:03PM -0400, Andrew Cagney wrote:
> > <gripe>
> > A lot of GDB tests seem to be written with only pass and timeout
> > alternatives, or only with overly-specialized fails.  The hypocrite-alert
> > readers of this message will note that I'm guilty of the same thing; this is
> > Just Enough to make them catch a few errors I could think of, not enough to
> > recognize completely wrong output.  Someday, someone more motivated than I
> > should clean this up.
> > </gripe>
> 
> For the MI, this is a pretty obvious fix.  I've been doing the same 
> thing my self (when I noticed it).  One suggestion, can you make that 
> fail expression less strict so that it picks.  Something like:
> 
> 	<correct-output> (gdb) <more-output> (gdb)
> 		pass
> 
> 	.* (gdb) .* (gdb)
> 		fail
> 
> 	timeout
> 		fail
> 
> alternatively (hmm, better?), keep the expression as you have it but add 
> a comment in paren vis:
> 
> 	fail "continue to incr_a (compiler bug info is wrong)"

Is this about what you had in mind?

-- 
Daniel Jacobowitz                           Carnegie Mellon University
MontaVista Software                         Debian GNU/Linux Developer

2001-09-28  Daniel Jacobowitz  <drow@mvista.com>

	* gdb.mi/mi-var-display.exp (continue to incr_a):  Recognize
	some incorrect output instead of timing out.
	* gdb.mi/mi-var-display.exp (continue to incr_a):  Likewise.

Index: gdb.mi/mi-var-display.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.mi/mi-var-display.exp,v
retrieving revision 1.5
diff -u -r1.5 mi-var-display.exp
--- mi-var-display.exp	2001/08/19 01:23:43	1.5
+++ mi-var-display.exp	2001/09/28 22:52:37
@@ -591,6 +591,12 @@
     -re "\\^running\r\n${mi_gdb_prompt}\\*stopped,reason=\"breakpoint-hit\",bkptno=\"3\",thread-id=\"\[01\]\",frame=\{addr=\"$hex\",func=\"incr_a\",args=\\\[\{name=\"a\",value=\"2\.*\"\}\\\],file=\".*var-cmd.c\",line=\"85\"\}\r\n$mi_gdb_prompt$" {
 	pass "continue to incr_a"
     }
+    -re "\\^running\r\n${mi_gdb_prompt}\\*stopped,reason=\"breakpoint-hit\",bkptno=\"3\",thread-id=\"\[01\]\",frame=\{addr=\"$hex\",func=\"incr_a\",args=\\\[\{name=\"a\",value=\"\.*\"\}\\\],file=\".*var-cmd.c\",line=\"8\[345\]\"\}\r\n$mi_gdb_prompt$" {
+	fail "continue to incr_a (compiler debug info incorrect)"
+    }
+    -re "\\^running\r\n${mi_gdb_prompt}.*\r\n$mi_gdb_prompt$" {
+	fail "continue to incr_a (unknown output)"
+    }
     timeout {
 	fail "continue to incr_a (timeout)"
     }
Index: gdb.mi/mi0-var-display.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.mi/mi0-var-display.exp,v
retrieving revision 1.4
diff -u -r1.4 mi0-var-display.exp
--- mi0-var-display.exp	2001/08/19 01:23:43	1.4
+++ mi0-var-display.exp	2001/09/28 22:52:37
@@ -591,6 +591,12 @@
     -re "\\^running\r\n${mi_gdb_prompt}\\*stopped,reason=\"breakpoint-hit\",bkptno=\"3\",thread-id=\"\[01\]\",frame=\{addr=\"$hex\",func=\"incr_a\",args=\{\{name=\"a\",value=\"2\.*\"\}\},file=\".*var-cmd.c\",line=\"85\"\}\r\n$mi_gdb_prompt$" {
 	pass "continue to incr_a"
     }
+    -re "\\^running\r\n${mi_gdb_prompt}\\*stopped,reason=\"breakpoint-hit\",bkptno=\"3\",thread-id=\"\[01\]\",frame=\{addr=\"$hex\",func=\"incr_a\",args=\{\{name=\"a\",value=\".*\"\}\},file=\".*var-cmd.c\",line=\"8\[345\]\"\}\r\n$mi_gdb_prompt$" {
+	fail "continue to incr_a (compiler debug info incorrect)"
+    }
+    -re "\\^running\r\n${mi_gdb_prompt}.*\r\n$mi_gdb_prompt$" {
+	fail "continue to incr_a (unknown output)"
+    }
     timeout {
 	fail "continue to incr_a (timeout)"
     }