Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@mvista.com>
To: Andrew Cagney <ac131313@cygnus.com>
Cc: fnasser@cygnus.com, gdb-patches@sources.redhat.com
Subject: Re: [rfa/testsuite/mi] Recognize a few incorrect outputs
Date: Fri, 28 Sep 2001 13:38:00 -0000	[thread overview]
Message-ID: <20010928163842.A24766@nevyn.them.org> (raw)
In-Reply-To: <3BB4DEBB.1020906@cygnus.com>

On Fri, Sep 28, 2001 at 04:34:03PM -0400, Andrew Cagney wrote:
> > <gripe>
> > A lot of GDB tests seem to be written with only pass and timeout
> > alternatives, or only with overly-specialized fails.  The hypocrite-alert
> > readers of this message will note that I'm guilty of the same thing; this is
> > Just Enough to make them catch a few errors I could think of, not enough to
> > recognize completely wrong output.  Someday, someone more motivated than I
> > should clean this up.
> > </gripe>
> 
> For the MI, this is a pretty obvious fix.  I've been doing the same 
> thing my self (when I noticed it).  One suggestion, can you make that 
> fail expression less strict so that it picks.  Something like:
> 
> 	<correct-output> (gdb) <more-output> (gdb)
> 		pass
> 
> 	.* (gdb) .* (gdb)
> 		fail
> 
> 	timeout
> 		fail
> 
> alternatively (hmm, better?), keep the expression as you have it but add 
> a comment in paren vis:
> 
> 	fail "continue to incr_a (compiler bug info is wrong)"

Can we do that?  I was under the impression that "(timeout)" was
special.  If we can, I'll add both cases - for the wrong debug info and
for some unknown failing output.  I'm tempted to mark such tests XFAIL
if we can obviously detect that the compiler is at fault; admittedly,
the test isn't perfect, but it's still better than the current state of
affairs...

-- 
Daniel Jacobowitz                           Carnegie Mellon University
MontaVista Software                         Debian GNU/Linux Developer


  parent reply	other threads:[~2001-09-28 13:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-09-28 12:15 Daniel Jacobowitz
     [not found] ` <3BB4DEBB.1020906@cygnus.com>
2001-09-28 13:38   ` Daniel Jacobowitz [this message]
2001-09-28 15:54   ` Daniel Jacobowitz
2001-09-28 16:29     ` Andrew Cagney
2001-10-01  7:28     ` Fernando Nasser
2001-10-01 13:30       ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20010928163842.A24766@nevyn.them.org \
    --to=drow@mvista.com \
    --cc=ac131313@cygnus.com \
    --cc=fnasser@cygnus.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox