From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Molenda To: Andrew Cagney Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA] bug in symtab.c:lookup_block_symbol()'s search method Date: Mon, 17 Sep 2001 23:12:00 -0000 Message-id: <20010917231109.A25642@shell17.ba.best.com> References: <7370175E-AA1B-11D5-94ED-0030657B5340@cgsoftware.com> <20010915140234.A17079@shell17.ba.best.com> <200109160715.JAA07114@is.elta.co.il> <3BA6E214.9020700@cygnus.com> X-SW-Source: 2001-09/msg00218.html On Tue, Sep 18, 2001 at 01:56:36AM -0400, Andrew Cagney wrote: > The suggested criteria for committing something to the 5.1 branch are: > > o does it build (and if not did it build in 5.0/4.18) > > o does ``break main; run'' work If the bar is that high for patches on the release branch, then this change does not meet it. We'll still need to address this on the trunk. > Jason, you've indicate that this seriously hurts Apple's GDB branch. Fear not, it's already patched in the Apple GDB branch. :-) My concern is for (a) environments where pointers to undefined structures are used, and (b) lookups of undefined symbols. Obviously it's not a great travisty if (b) is slow, but (a) will hit anyone who has libraries that try to hide the implementation from the interface in the same way that the Appple Carbon libraries do. I probably won't have time until next weekend, but I'll be sending modified versions of the profiling and symtab patches to incorporate many of the suggestions on the list. Jason