From: Mark Kettenis <kettenis@wins.uva.nl>
To: gdb-patches@sources.redhat.com
Subject: [PATCH]: Remove redundant <unistd.h> from Linux xm.h files
Date: Sat, 08 Sep 2001 03:41:00 -0000 [thread overview]
Message-ID: <200109081041.f88AfYx00436@delius.kettenis.local> (raw)
I already did this for Linux/i386. The comment on the includes is
bogus: R_OK isn't used anywhere in the current sources. And
<unistd.h> is included by defs.h anyway.
Committed as obvious.
Index: ChangeLog
from Mark Kettenis <kettenis@gnu.org>
* config/arm/xm-linux.h, config/ia64/xm-linux.h,
config/m68k/xm-linux.h, config/mips/xm-linux.h,
config/powerpc/xm-linux.h, config/sparc/xm-linux.h: Remove
redundant inclusion of <unistd.h>.
Index: config/arm/xm-linux.h
===================================================================
RCS file: /cvs/src/src/gdb/config/arm/xm-linux.h,v
retrieving revision 1.3
diff -u -p -r1.3 xm-linux.h
--- config/arm/xm-linux.h 2001/07/23 19:21:53 1.3
+++ config/arm/xm-linux.h 2001/09/08 10:36:35
@@ -27,7 +27,4 @@
to get the offset in the core file of the register values. */
#define KERNEL_U_ADDR 0x0
-/* Need R_OK etc, but USG isn't defined. */
-#include <unistd.h>
-
#endif /* XM_ARMLINUX_H */
Index: config/m68k/xm-linux.h
===================================================================
RCS file: /cvs/src/src/gdb/config/m68k/xm-linux.h,v
retrieving revision 1.6
diff -u -p -r1.6 xm-linux.h
--- config/m68k/xm-linux.h 2001/07/28 20:05:15 1.6
+++ config/m68k/xm-linux.h 2001/09/08 10:36:35
@@ -31,7 +31,4 @@
#define HOST_LONG_DOUBLE_FORMAT &floatformat_m68881_ext
-/* Need R_OK etc, but USG isn't defined. */
-#include <unistd.h>
-
#endif /* #ifndef XM_LINUX_H */
Index: config/mips/xm-linux.h
===================================================================
RCS file: /cvs/src/src/gdb/config/mips/xm-linux.h,v
retrieving revision 1.1
diff -u -p -r1.1 xm-linux.h
--- config/mips/xm-linux.h 2001/07/10 20:41:54 1.1
+++ config/mips/xm-linux.h 2001/09/08 10:36:35
@@ -30,7 +30,4 @@
#endif
#endif
-/* Need R_OK etc, but USG isn't defined. */
-#include <unistd.h>
-
#endif /* XM_MIPSLINUX_H */
Index: config/powerpc/xm-linux.h
===================================================================
RCS file: /cvs/src/src/gdb/config/powerpc/xm-linux.h,v
retrieving revision 1.6
diff -u -p -r1.6 xm-linux.h
--- config/powerpc/xm-linux.h 2001/07/23 19:21:55 1.6
+++ config/powerpc/xm-linux.h 2001/09/08 10:36:35
@@ -27,9 +27,6 @@ Foundation, Inc., 59 Temple Place - Suit
to get the offset in the core file of the register values. */
#define KERNEL_U_ADDR 0x0
-/* Need R_OK etc, but USG isn't defined. */
-#include <unistd.h>
-
/* If you expect to use the mmalloc package to obtain mapped symbol files,
for now you have to specify some parameters that determine how gdb places
the mappings in it's address space. See the comments in map_to_address()
Index: config/sparc/xm-linux.h
===================================================================
RCS file: /cvs/src/src/gdb/config/sparc/xm-linux.h,v
retrieving revision 1.3
diff -u -p -r1.3 xm-linux.h
--- config/sparc/xm-linux.h 2001/07/23 19:21:56 1.3
+++ config/sparc/xm-linux.h 2001/09/08 10:36:35
@@ -30,9 +30,6 @@
#define U_REGS_OFFSET 0
-/* Need R_OK etc, but USG isn't defined. */
-#include <unistd.h>
-
/* If you expect to use the mmalloc package to obtain mapped symbol files,
for now you have to specify some parameters that determine how gdb places
the mappings in it's address space. See the comments in map_to_address()
Index: config/ia64/xm-linux.h
===================================================================
RCS file: /cvs/src/src/gdb/config/ia64/xm-linux.h,v
retrieving revision 1.4
diff -u -p -r1.4 xm-linux.h
--- config/ia64/xm-linux.h 2001/07/23 19:21:56 1.4
+++ config/ia64/xm-linux.h 2001/09/08 10:36:35
@@ -27,7 +27,4 @@
to get the offset in the core file of the register values. */
#define KERNEL_U_ADDR 0x0
-/* Need R_OK etc, but USG isn't defined. */
-#include <unistd.h>
-
#endif /* #ifndef XM_LINUX_H */
reply other threads:[~2001-09-08 3:41 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200109081041.f88AfYx00436@delius.kettenis.local \
--to=kettenis@wins.uva.nl \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox