From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Molenda To: gdb-patches@sources.redhat.com Subject: [RFA] A few ui_out formatting bugs with commands-on-breakpoints Date: Fri, 07 Sep 2001 23:40:00 -0000 Message-id: <20010907234014.A10697@shell17.ba.best.com> X-SW-Source: 2001-09/msg00102.html Hi, it looks like there were a few small oversights in the ui support of printing-commands-on-breakpoints. With the current gdb, you enter these commands: (gdb) b main (gdb) comm > if $testval == 0 > print "true" > else > print "false" > end > print "done" > end (gdb) And this is how it's printed: (gdb) info br Num Type Disp Enb Address What 1 breakpoint keep y 0x08071a9e in main at ../../src3/gdb/main.c:714 if if $testval == 0 print "true" elseelse print "false" end end print "done" (gdb) Not quite ideal. :-) With the attached patch, the output is (gdb) info br Num Type Disp Enb Address What 1 breakpoint keep y 0x08070f30 in captured_command_loop at ../../src2/gdb/main.c:1 if $testval == 0 print "true" else print "false" end print "done" (gdb) The 'while' command has a similar problem. There aren't any testsuite regressions with this change. My only concern is that I'm unfamiliar with the UI_OUT suite of functions. Are certain ui_out functions are preferred over others? For instance, we have "end" printed out by both ui_out_field_string() and by ui_out_text(). I removed the first occurrence in each case, but who knows, maybe there's a reason to do it the other way. From what I can tell in the uiout doco, it's six of one and half a dozen of the other. Jason >From kettenis@wins.uva.nl Sat Sep 08 03:19:00 2001 From: Mark Kettenis To: gdb-patches@sources.redhat.com Subject: [PATCH] Add forward declaration of `struct block' to gdbtypes.h Date: Sat, 08 Sep 2001 03:19:00 -0000 Message-id: <200109081019.f88AJOO00300@delius.kettenis.local> X-SW-Source: 2001-09/msg00103.html Content-length: 865 See the #include file policy "discussion" on the discussion list. This makes `gdbtypes.h' (more) self-contained without sucking in `symtab.h'. Checked in. Mark Index: ChangeLog from Mark Kettenis * gdbtypes.h (struct block): Add forward declaration. Index: gdbtypes.h =================================================================== RCS file: /cvs/src/src/gdb/gdbtypes.h,v retrieving revision 1.15 diff -u -p -r1.15 gdbtypes.h --- gdbtypes.h 2001/09/05 23:07:32 1.15 +++ gdbtypes.h 2001/09/08 10:16:03 @@ -23,6 +23,9 @@ #if !defined (GDBTYPES_H) #define GDBTYPES_H 1 +/* Forward declarations for prototypes. */ +struct block; + /* Codes for `fundamental types'. This is a monstrosity based on the bogus notion that there are certain compiler-independent `fundamental types'. None of these is well-defined (how big is