Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Christopher Faylor <cgf@redhat.com>
To: gdb-patches@sources.redhat.com
Subject: Re: [RFA] work around sigsetjmp/siglongjmp macro problems
Date: Tue, 14 Aug 2001 13:08:00 -0000	[thread overview]
Message-ID: <20010814160813.D25516@redhat.com> (raw)
In-Reply-To: <15225.34182.443304.980626@krustylu.cygnus.com>

On Tue, Aug 14, 2001 at 04:09:42PM -0400, Elena Zannoni wrote:
>Keith Seitz writes:
> > On Mon, 13 Aug 2001, Christopher Faylor wrote:
> > 
> > > My proposed patch is below.  It may even be an obvious fix.
> > >
> > > Keith, could you try this out and verify that it fixes the problem?
> > 
> > Yep, works just fine.
> > 
> > Keith
>
>
>Ok, check it in.  I don't think there is need for comments.

Done.

>Maybe in the gdb coding style section of the gdb internal manual, we
>should make this point about macro's arguments.  Eli?

How about this:

Index: gdbint.texinfo
===================================================================
RCS file: /cvs/uberbaum/gdb/doc/gdbint.texinfo,v
retrieving revision 1.34
diff -p -r1.34 gdbint.texinfo
*** gdbint.texinfo	2001/07/31 17:30:56	1.34
--- gdbint.texinfo	2001/08/14 20:07:27
*************** However, use functions with moderation. 
*** 4395,4400 ****
--- 4395,4402 ----
  are just as hard to understand as a single thousand-line function.
  
  @emph{Macros are bad, M'kay.}
+ (But if you have to use a macro, make sure that the macro arguments are
+ protected with parentheses.)
  
  @cindex types
  
cgf


  reply	other threads:[~2001-08-14 13:08 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-08-01 14:01 [RFC] sigsetjmp/siglongjmp on cygwin Keith Seitz
     [not found] ` <s3iae1jjso2.fsf@soliton.wins.uva.nl>
2001-08-01 16:03   ` Keith Seitz
2001-08-01 23:57     ` Eli Zaretskii
2001-08-02 10:25       ` Andrew Cagney
2001-08-02 13:15         ` Mark Kettenis
2001-08-13 14:46           ` Jim Blandy
2001-08-13 15:12             ` Keith Seitz
2001-08-13 15:37               ` Andrew Cagney
2001-08-13 15:43                 ` Keith Seitz
2001-08-13 15:52                   ` Andrew Cagney
2001-08-13 16:27                     ` Keith Seitz
2001-08-13 16:32                       ` Christopher Faylor
     [not found]                         ` <20010813222037.A20589@redhat.com>
2001-08-13 19:40                           ` [RFC] sigsetjmp/siglongjmp on cygwin -- problem tracked down Andrew Cagney
2001-08-13 19:55                             ` Christopher Faylor
2001-08-13 20:10                               ` Daniel Jacobowitz
2001-08-13 20:18                                 ` [RFA] work around sigsetjmp/siglongjmp macro problems Christopher Faylor
2001-08-14  0:06                                   ` Eli Zaretskii
2001-08-14  7:40                                     ` Christopher Faylor
2001-08-14  9:34                                   ` Keith Seitz
2001-08-14 13:01                                     ` Elena Zannoni
2001-08-14 13:08                                       ` Christopher Faylor [this message]
2001-08-14 23:52                                         ` Eli Zaretskii
2001-08-14 23:49                                       ` Eli Zaretskii
2001-08-13 17:11                       ` [RFC] sigsetjmp/siglongjmp on cygwin Andrew Cagney
2001-08-13 17:23                         ` Keith Seitz
2001-08-03  1:33         ` Eli Zaretskii
2001-08-10  0:16           ` Andrew Cagney
2001-08-01 16:16   ` Andrew Cagney
2001-08-02 13:51     ` Christopher Faylor
2001-08-10  0:27 ` Andrew Cagney
2001-08-12 15:49   ` Ben Elliston
2001-08-13  2:03     ` Eli Zaretskii
2001-08-13 15:42       ` Andrew Cagney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20010814160813.D25516@redhat.com \
    --to=cgf@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox