Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Mark Kettenis <kettenis@wins.uva.nl>
To: dj@redhat.com
Cc: gdb-patches@sources.redhat.com
Subject: Re: [PATCH] Include "gdb_regex.h" instead of "gnu-regex.h"
Date: Thu, 02 Aug 2001 14:03:00 -0000	[thread overview]
Message-ID: <200108022103.f72L3re25561@delius.kettenis.local> (raw)
In-Reply-To: <200108022029.QAA08616@greed.delorie.com>

   Date: Thu, 2 Aug 2001 16:29:13 -0400
   From: DJ Delorie <dj@redhat.com>

   Why not "xregex.h" ?

I'm working on that :-).  In fact replacing gnu-regex.{c,h} with
xregex.h is what prompted this change.  We will still need to go
through gdb_regex.h to support --without-included-regex though.

Before we can get rid of the regex code in the gdb subdirectory, there
is one problem to solve though.  GDB uses the BSD re_comp() and
re_exec() instead of the POSIX interfaces.  Unfortunately, that bit of
code isn't currently compiled into the code included in libiberty.

In the long run we probably want to switch to the POSIX interfaces,
but in the meantime, the attached patch would make it possible to use
"xregex.h" in GDB.  I think it is pretty harmless, although it does
involve some name-space pollution.

Mark


Index: ChangeLog
from  Mark Kettenis  <kettenis@gnu.org>

	* xregex.h (_REGEX_RE_COMP): Define.
	(re_comp): Define to xre_comp.
	(re_exec): Define to xre_exec.

Index: xregex.h
===================================================================
RCS file: /cvs/src/src/include/xregex.h,v
retrieving revision 1.1
diff -u -p -r1.1 xregex.h
--- xregex.h 2001/07/11 00:15:17 1.1
+++ xregex.h 2001/08/02 20:57:19
@@ -19,6 +19,10 @@
 #  define re_syntax_options xre_syntax_options
 #  define re_max_failures xre_max_failures
 
+#  define _REGEX_RE_COMP
+#  define re_comp xre_comp
+#  define re_exec xre_exec
+
 #include "xregex2.h"
 
 #endif /* xregex.h */


      reply	other threads:[~2001-08-02 14:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-08-02 13:18 Mark Kettenis
2001-08-02 13:24 ` Fernando Nasser
2001-08-02 13:29 ` DJ Delorie
2001-08-02 14:03   ` Mark Kettenis [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200108022103.f72L3re25561@delius.kettenis.local \
    --to=kettenis@wins.uva.nl \
    --cc=dj@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox