Re: [PATCH] Fix i386 FPU register conversion code

[Mark Kettenis <kettenis@wins.uva.nl>]

   Date: Sat, 28 Jul 2001 12:48:12 -0700
   From: Michael Snyder <msnyder@redhat.com>

   Mark Kettenis wrote:
   > 
   > Fixing the debug register number mapping scheme uncovered a bug in
   > i386-tdep.c:i386_register_convert_to_virtual().  Fixed with the
   > attached patch.
   > 
   > Mark

   Isn't "gdb_assert" rather strong for this use?
   Seems like simply returning without doing anything
   would be sufficient in case we were called with an
   integer register or what-not.  Calling gdb_assert
   will result in the user being asked if he would like
   GDB to abort and dump core (I think...)

Hmm, when I added the assertion, I was under the impression that if
the virtual type wasn't a floating-point type it would be a GDB
internal error, hence the gdb_assert.  However, this is probably not
entirely true, since I now think that bogus debug information (e.g. a
stab that says that  an integer variable that lives in a
floating-point register) might trip the assertion.  Printing a warning
and returning without doing anything is probably better.

The assertion in i386_register_convert_to_raw() still seems
appropriate though.

Mark