From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Jacobowitz To: Andrew Cagney , gdb-patches@sources.redhat.com Subject: Re: [rfa] gdbserver 1/n - PBUFSIZ Date: Thu, 19 Jul 2001 16:16:00 -0000 Message-id: <20010719161609.B30475@nevyn.them.org> References: <20010719113606.A18944@nevyn.them.org> <3B573F83.4050201@cygnus.com> <20010719132118.A23973@nevyn.them.org> X-SW-Source: 2001-07/msg00500.html On Thu, Jul 19, 2001 at 01:21:18PM -0700, Daniel Jacobowitz wrote: > > > Here's the first bit. PBUFSIZ is used as an array initializer, but defined > > > in terms of REGISTER_BYTES - which might not be a constant, and which I'd > > > rather hide anyway. Later on, the design I'm hashing out for gdbserver's > > > register cache will make it very easy to find the maximum value of > > > REGISTER_BYTES, and we can make PBUFSIZ flexible again; for now, I made it > > > "big enough". > > > > > > If I'm correct above, why not just ask your backend how big it thinks > > that register buffer is (via a function call). For some targets it > > looks like it is just (sizeof (inferior_registers) + sizeof > > (inferior_fp_registers)) for others it is a little bit more tricky but > > nothing more. > > Well, the other issue is that it's currently assumed to be a constant. > It's used for, e.g., an array at the top of main(). I could make it a > variable and change all the arrays to alloca(), I suppose, but I'm not > thrilled with that either. [How -do- you manage to reply to one of my messages with the subject and References: of another? :)] Would you prefer I make PBUFSIZ non-constant and change the arrays to alloca(), or simply make it a large constant? Something's got to give :) -- Daniel Jacobowitz Carnegie Mellon University MontaVista Software Debian GNU/Linux Developer