Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <dmj+@andrew.cmu.edu>
To: gdb-patches@sources.redhat.com
Subject: [rfa] gdbserver 1/n - PBUFSIZ
Date: Thu, 19 Jul 2001 11:36:00 -0000	[thread overview]
Message-ID: <20010719113606.A18944@nevyn.them.org> (raw)

The things I've been discussing w.r.t. qRegisters and such need to be done,
but they also need to be done properly, and I certainly won't have time to
do enough testing before 5.1.  It's possible to make gdbserver work in
roughly the right way, such that it will be friendly to the new work when
that's ready, without all the intrusive changes.  I'm going to try to do
that in time for 5.1.

Here's the first bit.  PBUFSIZ is used as an array initializer, but defined
in terms of REGISTER_BYTES - which might not be a constant, and which I'd
rather hide anyway.  Later on, the design I'm hashing out for gdbserver's
register cache will make it very easy to find the maximum value of
REGISTER_BYTES, and we can make PBUFSIZ flexible again; for now, I made it
"big enough".

OK to commit?

-- 
Daniel Jacobowitz                           Carnegie Mellon University
MontaVista Software                         Debian GNU/Linux Developer

2001-07-19  Daniel Jacobowitz  <drow@mvista.com>

	* gdbserver/server.h: Make PBUFSIZ a constant.

Index: server.h
===================================================================
RCS file: /cvs/src/src/gdb/gdbserver/server.h,v
retrieving revision 1.3
diff -u -r1.3 server.h
--- server.h	2001/03/06 08:21:44	1.3
+++ server.h	2001/07/19 18:28:05
@@ -81,6 +81,9 @@
 
 /* Buffer sizes for transferring memory, registers, etc.  Round up PBUFSIZ to
    hold all the registers, at least.  */
+/* FIXME - REGISTER_BYTES is not known at this time.
 #define	PBUFSIZ ((REGISTER_BYTES > MAXBUFBYTES (2000)) \
 		 ? (REGISTER_BYTES * 2 + 32) \
 		 : 2000)
+*/
+#define PBUFSIZ 4096


             reply	other threads:[~2001-07-19 11:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-07-19 11:36 Daniel Jacobowitz [this message]
2001-07-19 13:14 ` Andrew Cagney
2001-07-19 13:21   ` Daniel Jacobowitz
     [not found]     ` <3B575B8F.4050407@cygnus.com>
2001-07-19 16:12       ` Daniel Jacobowitz
2001-07-19 16:16     ` Daniel Jacobowitz
2001-07-20 16:54       ` Andrew Cagney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20010719113606.A18944@nevyn.them.org \
    --to=dmj+@andrew.cmu.edu \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox