Re: [PATCH] Get rid of host <signal.h> in config/tm-linux.h

Daniel Jacobowitz
2001-07-11T14:44:00Z

On Wed, Jul 11, 2001 at 10:19:35AM +0200, Mark Kettenis wrote:
> As pointed out by Daniel Jacobowitz in his Linux/MIPS patch, including
> the host <signal.h> in the tm.h file makes no sense. This moves it to
> the nm.h file and leaves reasonable defaults for REALTIME_LO and
> REALTIME_HI in tm-linux.h.
>
> Daniel, I think this should make it possible for you to include
> tm-linux.h instead of copying over the relevant bits in
> config/mips/tm-linux.h.

Yes, it does. Fixed with the attached patch (committed).

--
Daniel Jacobowitz Carnegie Mellon University
MontaVista Software Debian GNU/Linux Developer

2001-07-11 Daniel Jacobowitz <drow@mvista.com>

* config/mips/tm-linux.h: Include "tm-linux.h" instead of copying
from it. Move definitions of REALTIME_LO and REALTIME_HI above
include.

Index: tm-linux.h
===================================================================
RCS file: /cvs/src/src/gdb/config/mips/tm-linux.h,v
retrieving revision 1.1
diff -u -r1.1 tm-linux.h
--- tm-linux.h 2001/07/10 20:41:54 1.1
+++ tm-linux.h 2001/07/11 21:41:17
@@ -30,33 +30,17 @@
#undef SKIP_TRAMPOLINE_CODE
#undef IGNORE_HELPER_CALL

-/* FIXME: Do not include "tm-linux.h", because we do not want the host's
- <signal.h>. Instead, copy the non-signal bits for now. */
-
-/* We need this file for the SOLIB_TRAMPOLINE stuff. */
-
-#include "tm-sysv4.h"
-
-/* We define SVR4_SHARED_LIBS unconditionally, on the assumption that
- link.h is available on all linux platforms. For I386 and SH3/4,
- we hard-code the information rather than use link.h anyway (for
- the benefit of cross-debugging). We may move to doing that for
- other architectures as well. */
+/* Linux/MIPS has __SIGRTMAX == 127. */

-#define SVR4_SHARED_LIBS
-#include "solib.h" /* Support for shared libraries. */
+#define REALTIME_LO 32
+#define REALTIME_HI 128

-/* End from "tm-linux.h". */
+#include "tm-linux.h"

/* There's an E_MIPS_ABI_O32 flag in e_flags, but we don't use it - in
fact, using it may violate the o32 ABI. */

#define MIPS_DEFAULT_ABI MIPS_ABI_O32
-
-/* Linux/MIPS has __SIGRTMAX == 127. */
-
-#define REALTIME_LO 32
-#define REALTIME_HI 128

/* Use target_specific function to define link map offsets. */