From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Jacobowitz To: Andrew Cagney Cc: gdb-patches@sources.redhat.com Subject: Re: [rfa] MIPS/Linux, take 3 Date: Tue, 10 Jul 2001 12:55:00 -0000 Message-id: <20010710125526.A22365@nevyn.them.org> References: <20010706151402.A14469@nevyn.them.org> <3B4A003B.2090201@cygnus.com> <20010709205048.A4346@nevyn.them.org> <3B4B5C9D.4030807@cygnus.com> X-SW-Source: 2001-07/msg00235.html On Tue, Jul 10, 2001 at 03:50:53PM -0400, Andrew Cagney wrote: > > On Mon, Jul 09, 2001 at 03:04:27PM -0400, Andrew Cagney wrote: > > > >> > + supply_register ((regi - EF_REG0), (char *)(regp + regi)); > > > >> > >> Just FYI, you don't need the cast and in general people are removing > >> them. > > > > > > I don't get it. What do you mean by "don't need the cast"? I get a > > warning without it. > > > Grumph, sorry, never mind. > > regcache.h:extern void supply_register (int regnum, char *val); > > Feel motivated enough to file a PR against it? Sure. I'm still not entirely clear what the right thing to do is, though. Play with void* instead? It's hard to say what type the incoming data should really be, if not char*. -- Daniel Jacobowitz Carnegie Mellon University MontaVista Software Debian GNU/Linux Developer