From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Jacobowitz To: Andrew Cagney Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA] Add mips_software_single_step Date: Thu, 05 Jul 2001 15:05:00 -0000 Message-id: <20010705150511.A27593@nevyn.them.org> References: <20010704115630.A16310@nevyn.them.org> <3B44E116.4070009@cygnus.com> X-SW-Source: 2001-07/msg00119.html On Thu, Jul 05, 2001 at 05:50:14PM -0400, Andrew Cagney wrote: > > This function's pretty straightforward; the Linux port uses it. Ok to > > commit? > > > How does the linux port use it? As a tweek to the multi-arch vector or > as a macro/function? If the former then it should be static, if the > latter than a declaration in mips-tdep.h or tm-mips.h (?) is needed. As a macro: #define SOFTWARE_SINGLE_STEP_P() 1 extern void mips_software_single_step (unsigned int, int); #define SOFTWARE_SINGLE_STEP(sig,bp_p) mips_software_single_step (sig, bp_p) I'm sensing that this belongs in the multi-arch vector, though. I'll change that. The question this raises is how to do it. I'd rather do it in mips-linux-tdep.c than mips-tdep.c, and mips-tdep shouldn't know we're compiling for a Linux target (it already does, via MIPS_DEFAULT_ABI, but I'll address that in a bit). How can I modify the gdbarch vector in a second place? > The function is almost ok. It just needs to be updated to meet GDB's > current coding conventions (ISO-C, indentation). Right. I'll do that too. > With regard to the linux code, you should probably look over > http://sources.redhat.com/gdb/ari/ and check any new code for potential > regressions or errors. Just remember to ignore any of the warnings :-) I think I'm OK on most of those; I'll go over it again later. -- Daniel Jacobowitz Carnegie Mellon University MontaVista Software Debian GNU/Linux Developer