From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eli Zaretskii To: Fernando Nasser Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA] Improve completion of locations Date: Mon, 04 Jun 2001 23:15:00 -0000 Message-id: <200106050617.JAA27884@is.elta.co.il> References: <9743-Sat05May2001210007+0300-eliz@is.elta.co.il> X-SW-Source: 2001-06/msg00038.html > Date: Sat, 05 May 2001 21:00:08 +0300 > From: "Eli Zaretskii" > > I'm seeking approval for the patches below, which improve GDB's > completion of locations in commands like "break LOCATION". The two > main improvements are: > > - GDB now considers file names as well as symbol names when you > type, e.g., "break foo". If there's a symbol foo_bar and a file > foo-bar.c, both will be shown in the list of possible completions. > Only files recorded in the debug info are used for completing file > names for these commands. > > - When the user types "break foo.c:bar TAB", only symbols defined in > the source file foo.c whose names begin with "bar" will be > considered for completion. This reduces the number of possible > completions by a large factor in many typical situations (I'd even > dare to say that it makes symbol completion a useful feature ;-). > > This is the last installment of my recent completion-related frenzy. > I'm now quite happy with GDB's completion ;-) > > AFAICS, the responsible maintainers who need to approve these patches > are Fernando, Elena, Michael Snyder, and someone for printcmd.c and > infcmd.c. > > 2001-05-05 Eli Zaretskii > > * completer.c (gdb_completer_loc_break_characters): New variable. > (line_completion_function): If we are completing on locations, > back up the start of word pointer past all characters which can > appear in a location spec. > (location_completer): New function. > > * completer.h: Add prototype for location_completer. It's been a month since I asked for approval of these patches, but the changes for completer.[ch] are still not approved nor rejected. Let me know how can I help you review these changes. TIA