Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@act-europe.fr>
To: Andrew Cagney <ac131313@cygnus.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: patch to gdb on Tru64 5.1
Date: Thu, 10 May 2001 17:03:00 -0000	[thread overview]
Message-ID: <20010511020332.H15086@act-europe.fr> (raw)
In-Reply-To: <3AF9B89F.2090007@cygnus.com>

> > Index: gdb/alpha-nat.c
> > ===================================================================
> > RCS file: /cvs/src/src/gdb/alpha-nat.c,v
> > retrieving revision 1.7
> > diff -c -3 -p -r1.7 alpha-nat.c
> > *** alpha-nat.c	2001/03/06 08:21:05	1.7
> > --- alpha-nat.c	2001/05/09 05:33:21
> > ***************
> > *** 29,35 ****
> >   #include <asm/reg.h>
> > #include <alpha/ptrace.h>
> > #else
> > ! #include <machine/reg.h>
> > #endif
> >   #include <sys/user.h>
> > --- 29,35 ----
> >   #include <asm/reg.h>
> > #include <alpha/ptrace.h>
> > #else
> > ! #include <alpha/coreregs.h>
> > #endif
> >   #include <sys/user.h>
> 
> Is this safe?  Hmm, looking at that part of the header:
> 
> #ifdef __linux__
> #include <asm/reg.h>
> #include <alpha/ptrace.h>
> #else
> #include <machine/reg.h>
> #endif
> 
> the whole thing is somewhat bogus.  Anyway, you need to be certain that 
> your change doesn't break at least the immediatly previous OS.

I tried to compile the code on a machine running 4.0f, and it actually
works much better with this change.

> In the above, half of core_reg_mapping[] is determined by the macro
> NFC_REGS.
> 
> Can you instead define both tables and select the correct one at
> runtime?

I don't understand your suggestion. The conditionalization is needed in
order to successfully compile on Tru64 5.1. If I had 2 tables, one of
them would not compile.

-- 
Joel


  reply	other threads:[~2001-05-10 17:03 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-05-08 23:22 Joel Brobecker
2001-05-09  7:41 ` Christopher Faylor
2001-05-09 10:57   ` Joel Brobecker
2001-05-09 13:56     ` Christopher Faylor
2001-05-10  8:32   ` Andrew Cagney
2001-05-09 11:07 ` Jim Blandy
2001-05-10  8:32 ` Andrew Cagney
2001-05-10 17:03   ` Joel Brobecker [this message]
2001-05-11 15:29     ` Andrew Cagney
2001-05-12 19:30       ` Nick Duffek
2001-05-10  9:56 ` Nick Duffek
2001-05-10 17:06   ` Joel Brobecker
2001-05-10 17:20     ` Nick Duffek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20010511020332.H15086@act-europe.fr \
    --to=brobecker@act-europe.fr \
    --cc=ac131313@cygnus.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox