From: "Paul N. Hilfinger" <hilfingr@otisco.mckusick.com>
To: fnasser@redhat.com
Cc: gdb-patches@sources.redhat.com
Subject: Side-effects of double-parsing patch
Date: Sun, 29 Apr 2001 04:11:00 -0000 [thread overview]
Message-ID: <200104291111.EAA26063@localhost.localdomain> (raw)
Fernando,
The patch of 2001-01-26 to fix double parsing of filenames causes some
other changes, and I'm not certain which are intentional. [A quick
review for the general audience: GDB used to call symbol_file_command
in a number of places for, well, reading the symbol file. However,
when called "internally" (that is, for purposes other than
implementing the symbol-file command), this caused file names to get
parsed twice, with odd effects in some cases. These calls were therefore
changed to calls to symbol_file_add_main, which immediately calls
symbol_file_add with some filled-in arguments.]
Now here's my question: symbol_file_command eventually calls
symbol_file_add, too, but it then goes on to call RESET_HP_UX_GLOBALS,
reinit_cache_frame, and set_initial_language. This no longer happens
for the "internal" calls. One side effect is that set_initial_language is
not called when GDB starts up, so that one now always starts in C (I think).
Unfortunately, this turns out to be a slight problem in the changes I am
making for Ada. This could be just a peculiarity of Ada, of course, so before
I do anything kludgey, may I ask what the reasoning was behind dispensing with
these three calls?
Thanks.
Paul Hilfinger
next reply other threads:[~2001-04-29 4:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-04-29 4:11 Paul N. Hilfinger [this message]
2001-04-29 9:24 ` Fernando Nasser
2001-04-29 20:48 ` Paul N. Hilfinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200104291111.EAA26063@localhost.localdomain \
--to=hilfingr@otisco.mckusick.com \
--cc=fnasser@redhat.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox