From: Mark Kettenis <kettenis@wins.uva.nl>
To: eliz@is.elta.co.il
Cc: gdb-patches@sources.redhat.com
Subject: Re: [PATCH] Use `unsigned long' for Linux/x86 debug registers
Date: Sun, 01 Apr 2001 08:04:00 -0000 [thread overview]
Message-ID: <200104011410.f31EAZ110855@delius.kettenis.local> (raw)
In-Reply-To: <Pine.SUN.3.91.1010401130258.17003B@is>
Date: Sun, 1 Apr 2001 13:04:44 +0200 (IST)
From: Eli Zaretskii <eliz@is.elta.co.il>
On Sun, 1 Apr 2001, Mark Kettenis wrote:
> It just occurred to me that Linux/x86 should really be using `unsigned
> long' instead of `long' as the type for debug register values.
They should indeed be unsigned, but why `unsigned long' instead of
`unsigned int'? i386-nat.c uses the latter, and ia32 debug registers
are 32-bit wide.
Well an `unsigned int' *might* be 16-bits, wheras ISO C guarantees
that `unsigned long' is at least 32-bits. All that matters, is that
the variables that we use to store ia32 debug registers are at least
32-bit wide. I was planning on changing i386-nat.c to use `unsigned
long' in the relevant places. This all doesn't really matter for
native stuff, but if we ever move this code to i386-tdep.c it might
matter. Better fix it now than be sorry later :-).
Mark
prev parent reply other threads:[~2001-04-01 8:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-04-01 3:59 Mark Kettenis
2001-04-01 4:06 ` Eli Zaretskii
2001-04-01 8:04 ` Mark Kettenis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200104011410.f31EAZ110855@delius.kettenis.local \
--to=kettenis@wins.uva.nl \
--cc=eliz@is.elta.co.il \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox