Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Peter.Schauer" <Peter.Schauer@regent.e-technik.tu-muenchen.de>
To: fnasser@cygnus.com (Fernando Nasser)
Cc: chastain@cygnus.com, dberlin@redhat.com, fnasser@redhat.com,
	gdb-patches@sources.redhat.com
Subject: Re: [RFA] testsuite/gdb.c++/ref-types.exp: use runto
Date: Fri, 16 Mar 2001 15:14:00 -0000	[thread overview]
Message-ID: <200103162314.AAA13573@reisser.regent.e-technik.tu-muenchen.de> (raw)
In-Reply-To: <3AB283AC.FD95FEEE@cygnus.com>

If you look at the CVS history of these tests, you will note that not all of
those tests were XFAIL'ed in the past.

gdb-4.17/gcc-2.8.1 handled most of these tests just fine, and they got
broken by the HP snowball, so it's not simply a matter of old-abi.

> Michael Elizabeth Chastain wrote:
> > 
> > Mmmm, a philosophical dispute.
> > 
> > Daniel Berlin writes:
> > > They need to be xfail'd for old-abi, but not for new-abi.
> > 
> > I believe that when gdb has a bug which is under its control, that the
> > test suite should issue a FAIL, not an XFAIL.
> > 
> 
> Yes, but what Dan is trying to say (I guess) is that this is _not_ under GDB's control. I.e., it was not possible for GDB to do the right thing because of insufficient information from the compiler.  Is that right Dan?
> 
> If that is the case, it is correct to mark those as XFAILs. Something besides GDB -- something in the execution environment or on another piece of the toolchain -- causes this test to fail and there is not that can be done inside GDB, so the "expected fai> lure".
> 
> Maybe you guys can come up with a simple quick test to determine if we are dealing with v2 or v3.  It would be useful to condition tests.
> 
> 
> > Here is a gdb log entry for gcc 2.95.2, gdb CVS, Red Hat Linux 7 native,
> > stabs:
> > 
> >   (gdb) print pAe->f()
> >   $1 = 134547192
> >   (gdb) XFAIL: gdb.c++/virtfunc.exp: print pAe->f()
> > 
> > If gdb said "I'm sorry, but pAe->f() is too complex for me", I would
> > accept that as an XFAIL.  But when gdb prints wrong answers, that should
> > be a FAIL.
> > 
> > I'm interested in other maintainer's opinions on this because I'm
> > planning to submit patches to change such XFAIL's to FAIL's, so that
> > the test suite can actually report what is broken in C++ support.
> > 
> > Michael
> 
> -- 
> Fernando Nasser
> Red Hat - Toronto                       E-Mail:  fnasser@redhat.com
> 2323 Yonge Street, Suite #300
> Toronto, Ontario   M4P 2C9
> 
> 


-- 
Peter Schauer			pes@regent.e-technik.tu-muenchen.de


  reply	other threads:[~2001-03-16 15:14 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-03-16 13:15 Michael Elizabeth Chastain
2001-03-16 13:21 ` Fernando Nasser
2001-03-16 15:14   ` Peter.Schauer [this message]
2001-03-16 15:17     ` Daniel Berlin
2001-03-16 15:45       ` Michael Snyder
2001-03-16 15:49         ` Daniel Berlin
2001-03-16 15:19   ` Andrew Cagney
2001-03-16 15:21     ` Daniel Berlin
2001-03-17  7:56   ` Daniel Berlin
  -- strict thread matches above, loose matches on Subject: below --
2001-03-17 14:37 Michael Elizabeth Chastain
2001-03-17 12:42 Michael Elizabeth Chastain
2001-03-17 15:31 ` Daniel Berlin
2001-03-17 12:35 Michael Elizabeth Chastain
2001-03-17 14:23 ` Daniel Berlin
2001-03-16 21:00 Michael Elizabeth Chastain
2001-03-17 11:12 ` Daniel Berlin
2001-03-16 16:03 Michael Elizabeth Chastain
2001-03-16 14:50 Michael Elizabeth Chastain
2001-03-16 14:55 ` Daniel Berlin
2001-03-16 14:49 Michael Elizabeth Chastain
2001-03-16 14:55 ` Daniel Berlin
     [not found] ` <20010316215907.A3607@redhat.com>
2001-03-17 11:59   ` Daniel Berlin
2001-03-16 14:35 Michael Elizabeth Chastain
2001-03-16 14:40 ` Fernando Nasser
2001-03-16 14:43 ` Daniel Berlin
2001-03-16 14:44 ` Daniel Berlin
     [not found] <200103161807.KAA06081@bosch.cygnus.com>
2001-03-16 12:00 ` Fernando Nasser
2001-03-16 13:00 ` Daniel Berlin
2001-03-16 14:29   ` Michael Snyder
2001-03-04 15:25 Michael Elizabeth Chastain
2001-02-24  0:16 Michael Elizabeth Chastain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200103162314.AAA13573@reisser.regent.e-technik.tu-muenchen.de \
    --to=peter.schauer@regent.e-technik.tu-muenchen.de \
    --cc=chastain@cygnus.com \
    --cc=dberlin@redhat.com \
    --cc=fnasser@cygnus.com \
    --cc=fnasser@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox