Re: [PATCH] Cleanup i386-tdep.c

[Mark Kettenis <kettenis@wins.uva.nl>]

   Date: Sun, 18 Feb 2001 22:32:49 +0200
   From: "Eli Zaretskii" <eliz@is.elta.co.il>

   > Date: Sun, 18 Feb 2001 11:17:48 +0100
   > From: Mark Kettenis <kettenis@wins.uva.nl>
   > 
   > Please create i386-nat.c (and i386-nat.h, for the exported
   > interfaces).

   Is it okay to use preprocessor symbols, like i386-tdep.c does, to get
   the watchpoint code included only in those x86 ports which support
   this kind of watchpoints?  I mean, i386-nat.c, once created, will
   probably be added to NATDEPFILES of every native x86 platform, right?
   However, some of them might not support watchpoints through debug
   registers (I think Solaris doesn't).

In principle, I think we don't want to introduce any additional
preprocessor symbols if we can avoid it.  Since we only include
i386-nat.c in NATDEPFILES for configurations that actually use code
from that file, we don't need them yet.  If we ever add more code to
i386-nat.c and we want to elide the unused debug register code, we can
always introduce a preprocessor symbol at that moment.

Mark