From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eli Zaretskii To: fnasser@redhat.com Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA] More completion improvements Date: Sun, 18 Feb 2001 07:58:00 -0000 Message-id: <200102181558.KAA11803@indy.delorie.com> References: <3A8FE260.217C0FB1@redhat.com> X-SW-Source: 2001-02/msg00337.html > Date: Sun, 18 Feb 2001 09:55:28 -0500 > From: Fernando Nasser > > In the general case, it is always nice to see if the maintainer of the > file has some objection though, as he/she may have a better idea of how > something should be used or some other detail that requires a "field > expert" opinion. > This does not apply to your patch though. You are just giving extra > information to the CLI so it can do a smarter completion. Okay, thanks for clarifying this. I think I'll wait for a day or two, to let others chance to send comments, just to be on the safe side. > The exception would be the extra help lines you've added. Ahm... what extra help lines? I don't think I added anything, I just changed indentation a bit where it was required by calling a different function (e.g., add_set_enum_cmd instead of add_set_cmd), which moves the left parenthesis a bit, and thus changes indentation of the following lines. > I am a completion addict That makes two of us. I'm so addicted to completion I cannot use any interface that lacks it without being disgusted.