From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Frank Ch. Eigler" To: Andrew Cagney Cc: Fernando Nasser , GDB Patches Subject: Re: Write after approval additions Date: Wed, 14 Feb 2001 07:54:00 -0000 Message-id: <20010214105436.B20615@redhat.com> References: <3A817ED7.60A7B32C@cygnus.com> <3A81AC7D.22AC2232@cygnus.com> <3A8986A4.783810A6@cygnus.com> <20010214072421.A3608@redhat.com> <3A8AA859.BA1755BD@cygnus.com> X-SW-Source: 2001-02/msg00208.html Hi - On Wed, Feb 14, 2001 at 10:46:33AM -0500, Andrew Cagney wrote: : [...] : > But that's a separate issue! Vetting a patch based on whether : > the contributor has a filed copyright assignment occurs before : > the patch is approved. The MAINTAINERS file does not list all : > people with assignments. : : So? It doesn't need to. It just needs to reflect the current status of : people activly contributing to GDB. But again, the question was about the value of the various restrictions on write-after-approval status. What happens *prior* to patch approval (e.g., copyright assignment checking) is irrelevant to that question. - FChE -- -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.4 (GNU/Linux) Comment: For info see http://www.gnupg.org iD8DBQE6iqo8VZbdDOm/ZT0RAhtdAJwJUMsTRrbhrUbdFwQgJcDPDY/FlQCfcpkm KAYNF8ITTc8hpFxOlDbHL1w= =S4+z -----END PGP SIGNATURE----- >From keiths@cygnus.com Wed Feb 14 08:25:00 2001 From: Keith Seitz To: gdb-patches@sources.redhat.com Subject: [RFA] Assuming malloc exists in callfwmall.exp Date: Wed, 14 Feb 2001 08:25:00 -0000 Message-id: X-SW-Source: 2001-02/msg00209.html Content-length: 4509 (let me try to get the right mailing list this time :-) Hi, The problem: When doing an inferior function call with a struct/array/string argument (aka 'print foo({2,1})' or 'print foo("bar")', gdb requires "malloc" in the executable... This leads to some trivial testsuite failures. 2001-02-13 Keith Seitz * gdb.base/callfwmall.exp: Check for the existence of malloc. (do_function_calls): Do not do an inferior function call which requires malloc if malloc doesn't exist. Patch: Index: testsuite/gdb.base/callfwmall.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.base/callfwmall.exp,v retrieving revision 1.1.1.3 diff -p -r1.1.1.3 callfwmall.exp *** testsuite/gdb.base/callfwmall.exp 1999/09/09 00:00:21 1.1.1.3 --- testsuite/gdb.base/callfwmall.exp 2001/02/14 01:11:52 *************** proc set_lang_c {} { *** 99,105 **** proc do_function_calls {} { global prototypes global gcc_compiled ! global gdb_prompt # We need to up this because this can be really slow on some boards. set timeout 60; --- 99,105 ---- proc do_function_calls {} { global prototypes global gcc_compiled ! global gdb_prompt have_malloc_p # We need to up this because this can be really slow on some boards. set timeout 60; *************** proc do_function_calls {} { *** 169,183 **** gdb_test "p t_string_values(string_val2,string_val1)" " = 0" gdb_test "p t_string_values(string_val1,string_val2)" " = 1" ! gdb_test "p t_string_values(\"string 1\",\"string 2\")" " = 1" ! gdb_test "p t_string_values(\"string 1\",string_val2)" " = 1" ! gdb_test "p t_string_values(string_val1,\"string 2\")" " = 1" gdb_test "p t_char_array_values(char_array_val2,char_array_val1)" " = 0" gdb_test "p t_char_array_values(char_array_val1,char_array_val2)" " = 1" ! gdb_test "p t_char_array_values(\"carray 1\",\"carray 2\")" " = 1" ! gdb_test "p t_char_array_values(\"carray 1\",char_array_val2)" " = 1" ! gdb_test "p t_char_array_values(char_array_val1,\"carray 2\")" " = 1" gdb_test "p doubleit(4)" " = 8" gdb_test "p add(4,5)" " = 9" --- 169,187 ---- gdb_test "p t_string_values(string_val2,string_val1)" " = 0" gdb_test "p t_string_values(string_val1,string_val2)" " = 1" ! if {$have_malloc_p} { ! gdb_test "p t_string_values(\"string 1\",\"string 2\")" " = 1" ! gdb_test "p t_string_values(\"string 1\",string_val2)" " = 1" ! gdb_test "p t_string_values(string_val1,\"string 2\")" " = 1" ! } gdb_test "p t_char_array_values(char_array_val2,char_array_val1)" " = 0" gdb_test "p t_char_array_values(char_array_val1,char_array_val2)" " = 1" ! if {$have_malloc_p} { ! gdb_test "p t_char_array_values(\"carray 1\",\"carray 2\")" " = 1" ! gdb_test "p t_char_array_values(\"carray 1\",char_array_val2)" " = 1" ! gdb_test "p t_char_array_values(char_array_val1,\"carray 2\")" " = 1" ! } gdb_test "p doubleit(4)" " = 8" gdb_test "p add(4,5)" " = 9" *************** proc do_function_calls {} { *** 222,231 **** gdb_test "p t_enum_value2(enum_val2)" " = 1" gdb_test "p t_enum_value2(enum_val1)" " = 0" ! gdb_test "p sum_args(1,{2})" " = 2" ! gdb_test "p sum_args(2,{2,3})" " = 5" ! gdb_test "p sum_args(3,{2,3,4})" " = 9" ! gdb_test "p sum_args(4,{2,3,4,5})" " = 14" gdb_test "p sum10 (1, 2, 3, 4, 5, 6, 7, 8, 9, 10)" " = 55" gdb_test "p t_structs_c(struct_val1)" "= 120 'x'" \ --- 226,237 ---- gdb_test "p t_enum_value2(enum_val2)" " = 1" gdb_test "p t_enum_value2(enum_val1)" " = 0" ! if {$have_malloc_p} { ! gdb_test "p sum_args(1,{2})" " = 2" ! gdb_test "p sum_args(2,{2,3})" " = 5" ! gdb_test "p sum_args(3,{2,3,4})" " = 9" ! gdb_test "p sum_args(4,{2,3,4,5})" " = 14" ! } gdb_test "p sum10 (1, 2, 3, 4, 5, 6, 7, 8, 9, 10)" " = 55" gdb_test "p t_structs_c(struct_val1)" "= 120 'x'" \ *************** gdb_load ${binfile} *** 255,260 **** --- 261,273 ---- gdb_test "set print sevenbit-strings" "" gdb_test "set print address off" "" gdb_test "set width 0" "" + + # Note whether malloc exists + set have_malloc_p 1 + send_gdb "p malloc\n" + gdb_expect { + "No symbol \"malloc\"" { set have_malloc_p 0 } + } if { $hp_aCC_compiler } { # Do not set language explicitly to 'C'. This will cause aCC