Re: [RFA] fix child_xfer_memory in hppah-nat.c

[Christopher Faylor <cgf@redhat.com>]

On Sat, Feb 03, 2001 at 10:19:21PM -0800, Michael Elizabeth Chastain wrote:
>This patch fixes hppah-nat.c:xfer_child_memory to declare the new
>'struct mem_attrib *' argument.
>
>This patch is needed to build sourceware gdb on hpux 10.20.
>
>Jeff Law is the maintainer of "hpux, hp pa native", but Jeff is on
>vacation right now.  So I appeal to one of the blanket write maintainers
>for approval.
>
>I tested this patch by building on an hpux 10.20 machine.
>
>This patch does not make hpux gdb actually work.  When I run a child
>process, gdb goes catatonic.  This is the same behavior that sourceware
>gdb had in the 2001-01-22 version (a day before the interface change to
>child_xfer_memory).  By using an older gdb to debug both the 2001-01-22
>gdb and today's gdb with my patch applied, I saw that neither of them
>got as far as child_xfer_memory.
>
>OK to commit?

You might want to add an ATTRIBUTE_UNUSED to 'struct mem_attrib *mem' to
stop a potential compiler warning.

cgf

>Michael Elizabeth Chastain
><chastain@redhat.com>
>"love without fear"
>
>===
>
>2001-02-03  Michael Chastain  <chastain@redhat.com>
>
>	* hppah-nat.c (xfer_child_memory): Add parameter 'struct mem_attrib *'
>	to conform with interface change.
>
>====
>
>Index: gdb/hppah-nat.c
>===================================================================
>RCS file: /cvs/src/src/gdb/hppah-nat.c,v
>retrieving revision 1.6
>diff -c -3 -p -r1.6 hppah-nat.c
>*** gdb/hppah-nat.c	2000/12/15 01:01:47	1.6
>--- gdb/hppah-nat.c	2001/02/03 20:32:50
>*************** fetch_register (int regno)
>*** 266,271 ****
>--- 266,272 ----
>  
>  int
>  child_xfer_memory (CORE_ADDR memaddr, char *myaddr, int len, int write,
>+ 		   struct mem_attrib *mem,
>  		   struct target_ops *target)
>  {
>    register int i;

-- 
cgf@cygnus.com                        Red Hat, Inc.
http://sources.redhat.com/            http://www.redhat.com/
From chastain@cygnus.com Sun Feb 04 12:00:00 2001
From: Michael Elizabeth Chastain <chastain@cygnus.com>
To: cgf@redhat.com, gdb-patches@sources.redhat.com
Subject: Re: [RFA] fix child_xfer_memory in hppah-nat.c
Date: Sun, 04 Feb 2001 12:00:00 -0000
Message-id: <200102042000.MAA02222@bosch.cygnus.com>
X-SW-Source: 2001-02/msg00041.html
Content-length: 421

Chris Faylor writes:
> You might want to add an ATTRIBUTE_UNUSED to 'struct mem_attrib *mem' to
> stop a potential compiler warning.

I thought about that.  There are no other ATTRIBUTE_UNUSED in hppah-nat.c.
The specific function child_xfer_memory already has one unused parameter,
"struct target_ops *target", and it is not marked ATTRIBUTE_UNUSED.

Michael Elizabeth Chastain
<chastain@redhat.com>
"love without fear"
From philb@gnu.org Sun Feb 04 13:06:00 2001
From: Philip Blundell <philb@gnu.org>
To: gdb-patches@sources.redhat.com
Subject: patch for ARM GNU/Linux
Date: Sun, 04 Feb 2001 13:06:00 -0000
Message-id: <E14PWEF-0006Yz-00@kings-cross.london.uk.eu.org>
X-SW-Source: 2001-02/msg00042.html
Content-length: 3424

I needed this patch to build the current code on an arm-linux machine.

p.

2001-02-04  Philip Blundell  <philb@gnu.org>

	* config/arm/linux.mh (NATDEPFILES): Add proc-service.o,
	thread-db.o, lin-lwp.o; remove lin-thread.o, linux-thread.o.
	* config/arm/nm-linux (PREPARE_TO_PROCEED, ATTACH_LWP,
	GET_THREAD_SIGNALS): Define.
	* arm-linux-nat.c (fill_gregset): Correct type of argument.
	(supply_gregset): Likewise.
	(fill_fpregset): Likewise.
	(supply_fpregset): Likewise.

Index: arm-linux-nat.c
===================================================================
RCS file: /cvs/src/src/gdb/arm-linux-nat.c,v
retrieving revision 1.7
diff -u -p -u -p -r1.7 arm-linux-nat.c
--- arm-linux-nat.c	2000/05/26 23:22:40	1.7
+++ arm-linux-nat.c	2001/02/04 20:47:02
@@ -575,7 +575,7 @@ store_inferior_registers (int regno)
    If regno is -1, do this for all registers.  */
 
 void
-fill_gregset (gregset_t *gregsetp, int regno)
+fill_gregset (gdb_gregset_t *gregsetp, int regno)
 {
   if (-1 == regno)
     {
@@ -607,7 +607,7 @@ fill_gregset (gregset_t *gregsetp, int r
    in *gregsetp.  */
 
 void
-supply_gregset (gregset_t *gregsetp)
+supply_gregset (gdb_gregset_t *gregsetp)
 {
   int regno, reg_pc;
 
@@ -628,7 +628,7 @@ supply_gregset (gregset_t *gregsetp)
    If regno is -1, do this for all registers.  */
 
 void
-fill_fpregset (fpregset_t *fpregsetp, int regno)
+fill_fpregset (gdb_fpregset_t *fpregsetp, int regno)
 {
   FPA11 *fp = (FPA11 *) fpregsetp;
   
@@ -654,7 +654,7 @@ fill_fpregset (fpregset_t *fpregsetp, in
    in *fpregsetp.  */
 
 void
-supply_fpregset (fpregset_t *fpregsetp)
+supply_fpregset (gdb_fpregset_t *fpregsetp)
 {
   int regno;
   FPA11 *fp = (FPA11 *) fpregsetp;
Index: config/arm/linux.mh
===================================================================
RCS file: /cvs/src/src/gdb/config/arm/linux.mh,v
retrieving revision 1.6
diff -u -p -u -p -r1.6 linux.mh
--- linux.mh	2000/10/30 22:35:46	1.6
+++ linux.mh	2001/02/04 20:47:02
@@ -4,8 +4,9 @@ XM_FILE= xm-linux.h
 XDEPFILES=
 
 NAT_FILE= nm-linux.h
-NATDEPFILES= infptrace.o inftarg.o fork-child.o corelow.o \
-	     core-regset.o arm-linux-nat.o linux-thread.o lin-thread.o
+NATDEPFILES= infptrace.o inftarg.o fork-child.o corelow.o	\
+	core-regset.o arm-linux-nat.o				\
+	proc-service.o thread-db.o lin-lwp.o
 
 LOADLIBES= -ldl -rdynamic
 
Index: config/arm/nm-linux.h
===================================================================
RCS file: /cvs/src/src/gdb/config/arm/nm-linux.h,v
retrieving revision 1.2
diff -u -p -u -p -r1.2 nm-linux.h
--- nm-linux.h	2000/04/20 21:13:19	1.2
+++ nm-linux.h	2001/02/04 20:47:02
@@ -30,4 +30,20 @@ extern int kernel_u_size (void);
 /* Override copies of {fetch,store}_inferior_registers in infptrace.c.  */
 #define FETCH_INFERIOR_REGISTERS
 
+/* FIXME: kettenis/2000-09-03: This should be moved to ../nm-linux.h
+   once we have converted all Linux targets to use the new threads
+   stuff (without the #undef of course).  */
+
+extern int lin_lwp_prepare_to_proceed (void);
+#undef PREPARE_TO_PROCEED
+#define PREPARE_TO_PROCEED(select_it) lin_lwp_prepare_to_proceed ()
+
+extern void lin_lwp_attach_lwp (int pid, int verbose);
+#define ATTACH_LWP(pid, verbose) lin_lwp_attach_lwp ((pid), (verbose))
+
+#include <signal.h>
+
+extern void lin_thread_get_thread_signals (sigset_t *mask);
+#define GET_THREAD_SIGNALS(mask) lin_thread_get_thread_signals (mask)
+
 #endif /* NM_ARMLINUX_H */