From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Frank Ch. Eigler" To: Ben Elliston Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA] Patch for cgen_rtx_error() Date: Sat, 07 Oct 2000 18:51:00 -0000 Message-id: <20001007215114.D31946@redhat.com> References: <200010080038.LAA27334@dublin.cygnus.com> X-SW-Source: 2000-10/msg00027.html On Sun, Oct 08, 2000 at 11:38:00AM +1100, Ben Elliston wrote: > The following patch implements the cgen_rtx_error function [...] > [...] > +/* Emit an error message from CGEN RTL. */ > + > +void > +cgen_rtx_error (SIM_CPU *cpu, const char * fmt, ...) > +{ > + va_list ap; > + va_start(ap, fmt); > + sim_io_printf (CPU_STATE (cpu), fmt, ap); > + va_end(ap); > + sim_io_printf (CPU_STATE (cpu), "\n"); > +} Rather than just print the given message (is it really a varargs function?), it would be good to do a sim_engine_halt() there too. - FChE -- -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.2 (GNU/Linux) Comment: For info see http://www.gnupg.org iD8DBQE539MSVZbdDOm/ZT0RAqiBAJ0VrugoZUSWacpG6GmCx0wiHfUgowCeIqUv iqSY2nfAuyws+PB/4aMDDXg= =TF1H -----END PGP SIGNATURE----- >From cgf@cygnus.com Sat Oct 07 19:07:00 2000 From: Chris Faylor To: gdb-patches@sources.redhat.com Subject: Re: [RFA] Makefile.in tweak Date: Sat, 07 Oct 2000 19:07:00 -0000 Message-id: <20001007220647.C31591@cygnus.com> References: X-SW-Source: 2000-10/msg00028.html Content-length: 984 On Sun, Oct 08, 2000 at 10:30:21AM +1100, Ben Elliston wrote: >The following patch is a very minor change -- it replaces leading spaces >with a single hard tab in Makefile.in so that Emacs doesn't complain about a >possible Makefile syntax error. Okay to commit? Sure. Go ahead. cgf >--- Makefile.in 2000/09/15 10:21:14 1.791 >+++ Makefile.in 2000/10/07 23:28:17 >@@ -646,7 +646,7 @@ > ui-out.o cli-out.o \ > varobj.o wrapper.o \ > jv-lang.o jv-valprint.o jv-typeprint.o \ >- m2-lang.o p-lang.o p-typeprint.o p-valprint.o \ >+ m2-lang.o p-lang.o p-typeprint.o p-valprint.o \ > scm-exp.o scm-lang.o scm-valprint.o complaints.o typeprint.o \ > c-typeprint.o ch-typeprint.o f-typeprint.o m2-typeprint.o \ > c-valprint.o cp-valprint.o ch-valprint.o f-valprint.o m2-valprint.o \ > >Ben -- cgf@cygnus.com Cygnus Solutions, a Red Hat company http://sourceware.cygnus.com/ http://www.redhat.com/ >From bje@redhat.com Sun Oct 08 14:32:00 2000 From: Ben Elliston To: "Frank Ch. Eigler" Cc: gdb-patches@sources.redhat.com, cgen development Subject: Re: [RFA] Patch for cgen_rtx_error() Date: Sun, 08 Oct 2000 14:32:00 -0000 Message-id: References: <20001007215114.D31946@redhat.com> X-SW-Source: 2000-10/msg00029.html Content-length: 900 fche wrote: On Sun, Oct 08, 2000 at 11:38:00AM +1100, Ben Elliston wrote: > +/* Emit an error message from CGEN RTL. */ > + > +void > +cgen_rtx_error (SIM_CPU *cpu, const char * fmt, ...) > +{ > + va_list ap; > + va_start(ap, fmt); > + sim_io_printf (CPU_STATE (cpu), fmt, ap); > + va_end(ap); > + sim_io_printf (CPU_STATE (cpu), "\n"); > +} Rather than just print the given message (is it really a varargs function?), it would be good to do a sim_engine_halt() there too. Upon further inspection, it seems that the CGEN `error' rtx accepts only a single argument, so this function need not accept varargs. Right, Doug? Without making assumptions about the architecture of any given port, what are you proposing that I pass for the `pc' argument to sim_engine_halt? It's wrong to assume that GET_H_PC() and friends will be present. Ben