[PATCH] Linux/x86 2.4 SSE support

[Mark Kettenis <kettenis@wins.uva.nl>]

OK, here's the Linux part.  It removes support for the old Cygnus
kernel patch in favor of the stuff that actually ended up in the Linux
2.4 test releases.  As I said, the actual SSE stuff is untested, so
I'd appreciate if people running Linux 2.4 and glibc 2.2 test releases
could give it a try.

Mark


2000-08-10  Mark Kettenis  <kettenis@gnu.org>

	Adapt support for SSE registers in Linux/x86 for Linux 2.4.
	* i386-linux-nat.c: Various doc fixes.  Include "i387-nat.h".
	(GETFPXREGS_SUPPLIES): Renamed from GETXFPREGS_SUPPLIES.
	(have_ptrace_getfpxregs): Renamed from have_ptrace_getxfpregs.
	(convert_to_gregset): Removed.  Moved logic to ...
	(fill_gregset): ... here.  Simplified function.
	(fetch_regs): Use perror_with_name for error reporting.
	(store_regs): Add `regno' parameter.  Use perror_with_name for
	error reporting.  Call fill_gregset instead of convert_to_gregset.
	(FPREG_ADDR): Remove.
	(supply_fpregset): Implement by calling i387_supply_fsave.
	(convert_to_fpregset): Remove.
	(fill_fpregset): Implement by calling i387_fill_fsave.
	(fetch_fpregs): Use perror_with_name fro error reporting.
	(store_fpregs) Add `regno' parameter.  Use perror_with_name fro
	error reporting.  Call fill_fpregset instead of
	convert_to_fpregset.
	(supply_xfpregset, convert_to_xfpregset): Removed.
	(supply_fpxregset, fill_fpxregset): New functions.
	(fetch_fpxregs): Renamed from fetch_xfpregs.  Use perror_with_name
	for error reporting.  Call supply_fpxregset instead of
	supply_xfpregset.
	(store_xfpregs): Removed.
	(store_fpxregs): New function.
	(fetch_inferior_registers): Adjust for xfp -> fpx change.  Tweak
	message in call to internal_error.
	(store_inferior_registers): Adjust for xfp ->fpx change.  Pass
	REGNO to store_regs, store_fpregs and store_fpxregs.
	(fetch_core_registers): Adjust for xfp -> fpx change.
	* acconfig.h (HAVE_PTRACE_GETFPXREGS): Renamed from
	HAVE_PTRACE_GETXFPREGS.
	* config.in: Regenerated.
	* configure.in: Replace check for PTRACE_GETXFPREGS with check for
	PTRACE_GETFPXREGS.  Remove comment about Cygnus SSE extensions.
	* configure: Regenerated.
	* config/i386/linux.mh (NATDEPFILES): Add i387-nat.o.
	* config/i386/tm-linux.h: Base definition of HAVE_SSE_REGS on
	HAVE_PTRACE_GETFPXREGS instead of HAVE_PTRACE_GETXFPREGS.


Index: i386-linux-nat.c
===================================================================
RCS file: /cvs/src/src/gdb/i386-linux-nat.c,v
retrieving revision 1.13
diff -u -p -r1.13 i386-linux-nat.c
--- i386-linux-nat.c	2000/07/30 01:48:25	1.13
+++ i386-linux-nat.c	2000/08/10 16:57:03
@@ -1,5 +1,5 @@
-/* Native-dependent code for Linux running on i386's, for GDB.
-   Copyright (C) 1999, 2000 Free Software Foundation, Inc.
+/* Native-dependent code for Linux/x86.
+   Copyright 1999, 2000 Free Software Foundation, Inc.
 
    This file is part of GDB.
 
@@ -35,9 +35,12 @@
 #include <sys/reg.h>
 #endif
 
-/* Prototypes for supply_gregset etc. */
+/* Prototypes for supply_gregset etc.  */
 #include "gregset.h"
 
+/* Prototypes for i387_supply_fsave etc.  */
+#include "i387-nat.h"
+
 /* On Linux, threads are implemented as pseudo-processes, in which
    case we may be tracing more than one process at a time.  In that
    case, inferior_pid will contain the main process ID and the
@@ -49,7 +52,7 @@
 #define PIDGET(PID)	PID
 #define TIDGET(PID)	0
 #endif
-
+\f
 
 /* The register sets used in Linux ELF core-dumps are identical to the
    register sets in `struct user' that is used for a.out core-dumps,
@@ -79,7 +82,7 @@ static int regmap[] = 
   (0 <= (regno) && (regno) <= 15)
 #define GETFPREGS_SUPPLIES(regno) \
   (FP0_REGNUM <= (regno) && (regno) <= LAST_FPU_CTRL_REGNUM)
-#define GETXFPREGS_SUPPLIES(regno) \
+#define GETFPXREGS_SUPPLIES(regno) \
   (FP0_REGNUM <= (regno) && (regno) <= MXCSR_REGNUM)
 
 /* Does the current host support the GETREGS request?  */
@@ -91,30 +94,23 @@ int have_ptrace_getregs =
 #endif
 ;
 
-/* Does the current host support the GETXFPREGS request?  The header
+/* Does the current host support the GETFPXREGS request?  The header
    file may or may not define it, and even if it is defined, the
    kernel will return EIO if it's running on a pre-SSE processor.
 
-   PTRACE_GETXFPREGS is a Cygnus invention, since we wrote our own
-   Linux kernel patch for SSE support.  That patch may or may not
-   actually make it into the official distribution.  If you find that
-   years have gone by since this stuff was added, and Linux isn't
-   using PTRACE_GETXFPREGS, that means that our patch didn't make it,
-   and you can delete this, and the related code.
-
    My instinct is to attach this to some architecture- or
    target-specific data structure, but really, a particular GDB
    process can only run on top of one kernel at a time.  So it's okay
    for this to be a simple variable.  */
-int have_ptrace_getxfpregs =
-#ifdef HAVE_PTRACE_GETXFPREGS
+int have_ptrace_getfpxregs =
+#ifdef HAVE_PTRACE_GETFPXREGS
   1
 #else
   0
 #endif
 ;
-
 \f
+
 /* Fetching registers directly from the U area, one at a time.  */
 
 /* FIXME: kettenis/2000-03-05: This duplicates code from `inptrace.c'.
@@ -269,8 +265,8 @@ old_store_inferior_registers (int regno)
 	}
     }
 }
-
 \f
+
 /* Transfering the general-purpose registers between GDB, inferiors
    and core files.  */
 
@@ -281,49 +277,25 @@ void
 supply_gregset (elf_gregset_t *gregsetp)
 {
   elf_greg_t *regp = (elf_greg_t *) gregsetp;
-  int regi;
+  int i;
 
-  for (regi = 0; regi < NUM_GREGS; regi++)
-    supply_register (regi, (char *) (regp + regmap[regi]));
+  for (i = 0; i < NUM_GREGS; i++)
+    supply_register (i, (char *) (regp + regmap[i]));
 }
 
-/* Convert the valid general-purpose register values in GDB's register
-   array to `struct user' format and store them in *GREGSETP.  The
-   array VALID indicates which register values are valid.  If VALID is
-   NULL, all registers are assumed to be valid.  */
-
-static void
-convert_to_gregset (elf_gregset_t *gregsetp, signed char *valid)
-{
-  elf_greg_t *regp = (elf_greg_t *) gregsetp;
-  int regi;
-
-  for (regi = 0; regi < NUM_GREGS; regi++)
-    if (! valid || valid[regi])
-      *(regp + regmap[regi]) = * (int *) &registers[REGISTER_BYTE (regi)];
-}
-
 /* Fill register REGNO (if it is a general-purpose register) in
    *GREGSETPS with the value in GDB's register array.  If REGNO is -1,
    do this for all registers.  */
+
 void
 fill_gregset (elf_gregset_t *gregsetp, int regno)
 {
-  if (regno == -1)
-    {
-      convert_to_gregset (gregsetp, NULL);
-      return;
-    }
-
-  if (GETREGS_SUPPLIES (regno))
-    {
-      signed char valid[NUM_GREGS];
-
-      memset (valid, 0, sizeof (valid));
-      valid[regno] = 1;
+  elf_greg_t *regp = (elf_greg_t *) gregsetp;
+  int i;
 
-      convert_to_gregset (gregsetp, valid);
-    }
+  for (i = 0; i < NUM_GREGS; i++)
+    if ((regno == -1 || regno == i))
+      *(regp + regmap[i]) = *(elf_greg_t *) &registers[REGISTER_BYTE (i)];
 }
 
 #ifdef HAVE_PTRACE_GETREGS
@@ -335,10 +307,8 @@ static void
 fetch_regs (int tid)
 {
   elf_gregset_t regs;
-  int ret;
 
-  ret = ptrace (PTRACE_GETREGS, tid, 0, (int) &regs);
-  if (ret < 0)
+  if (ptrace (PTRACE_GETREGS, tid, 0, (int) &regs) < 0)
     {
       if (errno == EIO)
 	{
@@ -348,8 +318,7 @@ fetch_regs (int tid)
 	  return;
 	}
 
-      warning ("Couldn't get registers.");
-      return;
+      perror_with_name ("Couldn't get registers");
     }
 
   supply_gregset (&regs);
@@ -359,127 +328,36 @@ fetch_regs (int tid)
    into the process/thread specified by TID.  */
 
 static void
-store_regs (int tid)
+store_regs (int tid, int regno)
 {
   elf_gregset_t regs;
-  int ret;
 
-  ret = ptrace (PTRACE_GETREGS, tid, 0, (int) &regs);
-  if (ret < 0)
-    {
-      warning ("Couldn't get registers.");
-      return;
-    }
-
-  convert_to_gregset (&regs, register_valid);
+  if (ptrace (PTRACE_GETREGS, tid, 0, (int) &regs) < 0)
+    perror_with_name ("Couldn't get registers");
 
-  ret = ptrace (PTRACE_SETREGS, tid, 0, (int) &regs);
-  if (ret < 0)
-    {
-      warning ("Couldn't write registers.");
-      return;
-    }
+  fill_gregset (&regs, regno);
+  
+  if (ptrace (PTRACE_SETREGS, tid, 0, (int) &regs) < 0)
+    perror_with_name ("Couldn't write registers");
 }
 
 #else
 
 static void fetch_regs (int tid) {}
-static void store_regs (int tid) {}
+static void store_regs (int tid, int regno) {}
 
 #endif
-
 \f
-/* Transfering floating-point registers between GDB, inferiors and cores.  */
 
-/* What is the address of st(N) within the floating-point register set F?  */
-#define FPREG_ADDR(f, n) ((char *) &(f)->st_space + (n) * 10)
+/* Transfering floating-point registers between GDB, inferiors and cores.  */
 
 /* Fill GDB's register array with the floating-point register values in
    *FPREGSETP.  */
 
 void 
 supply_fpregset (elf_fpregset_t *fpregsetp)
-{
-  int reg;
-  long l;
-
-  /* Supply the floating-point registers.  */
-  for (reg = 0; reg < 8; reg++)
-    supply_register (FP0_REGNUM + reg, FPREG_ADDR (fpregsetp, reg));
-
-  /* We have to mask off the reserved bits in *FPREGSETP before
-     storing the values in GDB's register file.  */
-#define supply(REGNO, MEMBER)                                           \
-  l = fpregsetp->MEMBER & 0xffff;                                       \
-  supply_register (REGNO, (char *) &l)
-
-  supply (FCTRL_REGNUM, cwd);
-  supply (FSTAT_REGNUM, swd);
-  supply (FTAG_REGNUM, twd);
-  supply_register (FCOFF_REGNUM, (char *) &fpregsetp->fip);
-  supply (FDS_REGNUM, fos);
-  supply_register (FDOFF_REGNUM, (char *) &fpregsetp->foo);
-
-#undef supply
-
-  /* Extract the code segment and opcode from the  "fcs" member.  */
-  l = fpregsetp->fcs & 0xffff;
-  supply_register (FCS_REGNUM, (char *) &l);
-
-  l = (fpregsetp->fcs >> 16) & ((1 << 11) - 1);
-  supply_register (FOP_REGNUM, (char *) &l);
-}
-
-/* Convert the valid floating-point register values in GDB's register
-   array to `struct user' format and store them in *FPREGSETP.  The
-   array VALID indicates which register values are valid.  If VALID is
-   NULL, all registers are assumed to be valid.  */
-
-static void
-convert_to_fpregset (elf_fpregset_t *fpregsetp, signed char *valid)
 {
-  int reg;
-
-  /* Fill in the floating-point registers.  */
-  for (reg = 0; reg < 8; reg++)
-    if (!valid || valid[reg])
-      memcpy (FPREG_ADDR (fpregsetp, reg),
-	      &registers[REGISTER_BYTE (FP0_REGNUM + reg)],
-	      REGISTER_RAW_SIZE(FP0_REGNUM + reg));
-
-  /* We're not supposed to touch the reserved bits in *FPREGSETP.  */
-
-#define fill(MEMBER, REGNO)						\
-  if (! valid || valid[(REGNO)])					\
-    fpregsetp->MEMBER                                                   \
-      = ((fpregsetp->MEMBER & ~0xffff)                                  \
-         | (* (int *) &registers[REGISTER_BYTE (REGNO)] & 0xffff))
-
-#define fill_register(MEMBER, REGNO)                                    \
-  if (! valid || valid[(REGNO)])                                        \
-    memcpy (&fpregsetp->MEMBER, &registers[REGISTER_BYTE (REGNO)],      \
-            sizeof (fpregsetp->MEMBER))
-
-  fill (cwd, FCTRL_REGNUM);
-  fill (swd, FSTAT_REGNUM);
-  fill (twd, FTAG_REGNUM);
-  fill_register (fip, FCOFF_REGNUM);
-  fill (foo, FDOFF_REGNUM);
-  fill_register (fos, FDS_REGNUM);
-
-#undef fill
-#undef fill_register
-
-  if (! valid || valid[FCS_REGNUM])
-    fpregsetp->fcs
-      = ((fpregsetp->fcs & ~0xffff)
-	 | (* (int *) &registers[REGISTER_BYTE (FCS_REGNUM)] & 0xffff));
-
-  if (! valid || valid[FOP_REGNUM])
-    fpregsetp->fcs
-      = ((fpregsetp->fcs & 0xffff)
-	 | ((*(int *) &registers[REGISTER_BYTE (FOP_REGNUM)] & ((1 << 11) - 1))
-	    << 16));
+  i387_supply_fsave ((char *) fpregsetp);
 }
 
 /* Fill register REGNO (if it is a floating-point register) in
@@ -489,21 +367,7 @@ convert_to_fpregset (elf_fpregset_t *fpr
 void
 fill_fpregset (elf_fpregset_t *fpregsetp, int regno)
 {
-  if (regno == -1)
-    {
-      convert_to_fpregset (fpregsetp, NULL);
-      return;
-    }
-
-  if (GETFPREGS_SUPPLIES(regno))
-    {
-      signed char valid[MAX_NUM_REGS];
-      
-      memset (valid, 0, sizeof (valid));
-      valid[regno] = 1;
-	      
-      convert_to_fpregset (fpregsetp, valid);
-    }
+  i387_fill_fsave ((char *) fpregsetp, regno);
 }
 
 #ifdef HAVE_PTRACE_GETREGS
@@ -515,14 +379,9 @@ static void
 fetch_fpregs (int tid)
 {
   elf_fpregset_t fpregs;
-  int ret;
 
-  ret = ptrace (PTRACE_GETFPREGS, tid, 0, (int) &fpregs);
-  if (ret < 0)
-    {
-      warning ("Couldn't get floating point status.");
-      return;
-    }
+  if (ptrace (PTRACE_GETFPREGS, tid, 0, (int) &fpregs) < 0)
+    perror_with_name ("Couldn't get floating point status");
 
   supply_fpregset (&fpregs);
 }
@@ -531,199 +390,96 @@ fetch_fpregs (int tid)
    into the process/thread specified by TID.  */
 
 static void
-store_fpregs (int tid)
+store_fpregs (int tid, int regno)
 {
   elf_fpregset_t fpregs;
-  int ret;
 
-  ret = ptrace (PTRACE_GETFPREGS, tid, 0, (int) &fpregs);
-  if (ret < 0)
-    {
-      warning ("Couldn't get floating point status.");
-      return;
-    }
+  if (ptrace (PTRACE_GETFPREGS, tid, 0, (int) &fpregs) < 0)
+    perror_with_name ("Couldn't get floating point status");
 
-  convert_to_fpregset (&fpregs, register_valid);
+  fill_fpregset (&fpregs, regno);
 
-  ret = ptrace (PTRACE_SETFPREGS, tid, 0, (int) &fpregs);
-  if (ret < 0)
-    {
-      warning ("Couldn't write floating point status.");
-      return;
-    }
+  if (ptrace (PTRACE_SETFPREGS, tid, 0, (int) &fpregs) < 0)
+    perror_with_name ("Couldn't write floating point status");
 }
 
 #else
 
 static void fetch_fpregs (int tid) {}
-static void store_fpregs (int tid) {}
+static void store_fpregs (int tid, int regno) {}
 
 #endif
-
 \f
-/* Transfering floating-point and SSE registers to and from GDB.  */
 
-/* PTRACE_GETXFPREGS is a Cygnus invention, since we wrote our own
-   Linux kernel patch for SSE support.  That patch may or may not
-   actually make it into the official distribution.  If you find that
-   years have gone by since this code was added, and Linux isn't using
-   PTRACE_GETXFPREGS, that means that our patch didn't make it, and
-   you can delete this code.  */
+/* Transfering floating-point and SSE registers to and from GDB.  */
 
-#ifdef HAVE_PTRACE_GETXFPREGS
+#ifdef HAVE_PTRACE_GETFPXREGS
 
 /* Fill GDB's register array with the floating-point and SSE register
-   values in *XFPREGS.  */
+   values in *FPXREGSETP.  */
 
 static void
-supply_xfpregset (struct user_xfpregs_struct *xfpregs)
+supply_fpxregset (elf_fpxregset_t *fpxregsetp)
 {
-  int reg;
-
-  /* Supply the floating-point registers.  */
-  for (reg = 0; reg < 8; reg++)
-    supply_register (FP0_REGNUM + reg, (char *) &xfpregs->st_space[reg]);
-
-  {
-    supply_register (FCTRL_REGNUM, (char *) &xfpregs->cwd);
-    supply_register (FSTAT_REGNUM, (char *) &xfpregs->swd);
-    supply_register (FTAG_REGNUM,  (char *) &xfpregs->twd);
-    supply_register (FCOFF_REGNUM, (char *) &xfpregs->fip);
-    supply_register (FDS_REGNUM,   (char *) &xfpregs->fos);
-    supply_register (FDOFF_REGNUM, (char *) &xfpregs->foo);
-  
-    /* Extract the code segment and opcode from the  "fcs" member.  */
-    {
-      long l;
-      
-      l = xfpregs->fcs & 0xffff;
-      supply_register (FCS_REGNUM, (char *) &l);
-
-      l = (xfpregs->fcs >> 16) & ((1 << 11) - 1);
-      supply_register (FOP_REGNUM, (char *) &l);
-    }
-  }
-
-  /* Supply the SSE registers.  */
-  for (reg = 0; reg < 8; reg++)
-    supply_register (XMM0_REGNUM + reg, (char *) &xfpregs->xmm_space[reg]);
-  supply_register (MXCSR_REGNUM, (char *) &xfpregs->mxcsr);
+  i387_supply_fxsave ((char *) fpxregsetp);
 }
 
-/* Convert the valid floating-point and SSE registers in GDB's
-   register array to `struct user' format and store them in *XFPREGS.
-   The array VALID indicates which registers are valid.  If VALID is
-   NULL, all registers are assumed to be valid.  */
+/* Fill register REGNO (if it is a floating-point or SSE register) in
+   *FPXREGSETP with the value in GDB's register array.  If REGNO is
+   -1, do this for all registers.  */
 
 static void
-convert_to_xfpregset (struct user_xfpregs_struct *xfpregs,
-		      signed char *valid)
+fill_fpxregset (elf_fpxregset_t *fpxregsetp, int regno)
 {
-  int reg;
-
-  /* Fill in the floating-point registers.  */
-  for (reg = 0; reg < 8; reg++)
-    if (!valid || valid[reg])
-      memcpy (&xfpregs->st_space[reg],
-	      &registers[REGISTER_BYTE (FP0_REGNUM + reg)],
-	      REGISTER_RAW_SIZE(FP0_REGNUM + reg));
-
-#define fill(MEMBER, REGNO)						\
-  if (! valid || valid[(REGNO)])					\
-    memcpy (&xfpregs->MEMBER, &registers[REGISTER_BYTE (REGNO)],	\
-	    sizeof (xfpregs->MEMBER))
-
-  fill (cwd, FCTRL_REGNUM);
-  fill (swd, FSTAT_REGNUM);
-  fill (twd, FTAG_REGNUM);
-  fill (fip, FCOFF_REGNUM);
-  fill (foo, FDOFF_REGNUM);
-  fill (fos, FDS_REGNUM);
-
-#undef fill
-
-  if (! valid || valid[FCS_REGNUM])
-    xfpregs->fcs
-      = ((xfpregs->fcs & ~0xffff)
-	 | (* (int *) &registers[REGISTER_BYTE (FCS_REGNUM)] & 0xffff));
-
-  if (! valid || valid[FOP_REGNUM])
-    xfpregs->fcs
-      = ((xfpregs->fcs & 0xffff)
-	 | ((*(int *) &registers[REGISTER_BYTE (FOP_REGNUM)] & ((1 << 11) - 1))
-	    << 16));
-
-  /* Fill in the XMM registers.  */
-  for (reg = 0; reg < 8; reg++)
-    if (! valid || valid[reg])
-      memcpy (&xfpregs->xmm_space[reg],
-	      &registers[REGISTER_BYTE (XMM0_REGNUM + reg)],
-	      REGISTER_RAW_SIZE (XMM0_REGNUM + reg));
+  i387_fill_fxsave ((char *) fpxregsetp, regno);
 }
 
-/* Fetch all registers covered by the PTRACE_SETXFPREGS request from
+/* Fetch all registers covered by the PTRACE_GETFPXREGS request from
    process/thread TID and store their values in GDB's register array.
    Return non-zero if successful, zero otherwise.  */
 
 static int
-fetch_xfpregs (int tid)
+fetch_fpxregs (int tid)
 {
-  struct user_xfpregs_struct xfpregs;
-  int ret;
+  elf_fpxregset_t fpxregs;
 
-  if (! have_ptrace_getxfpregs) 
+  if (! have_ptrace_getfpxregs)
     return 0;
 
-  ret = ptrace (PTRACE_GETXFPREGS, tid, 0, &xfpregs);
-  if (ret == -1)
+  if (ptrace (PTRACE_GETFPXREGS, tid, 0, (int) &fpxregs) < 0)
     {
       if (errno == EIO)
 	{
-	  have_ptrace_getxfpregs = 0;
+	  have_ptrace_getfpxregs = 0;
 	  return 0;
 	}
 
-      warning ("Couldn't read floating-point and SSE registers.");
-      return 0;
+      perror_with_name ("Couldn't read floating-point and SSE registers");
     }
 
-  supply_xfpregset (&xfpregs);
+  supply_fpxregset (&fpxregs);
   return 1;
 }
 
 /* Store all valid registers in GDB's register array covered by the
-   PTRACE_SETXFPREGS request into the process/thread specified by TID.
+   PTRACE_SETFPXREGS request into the process/thread specified by TID.
    Return non-zero if successful, zero otherwise.  */
 
 static int
-store_xfpregs (int tid)
+store_fpxregs (int tid, int regno)
 {
-  struct user_xfpregs_struct xfpregs;
-  int ret;
+  elf_fpxregset_t fpxregs;
 
-  if (! have_ptrace_getxfpregs)
+  if (! have_ptrace_getfpxregs)
     return 0;
-
-  ret = ptrace (PTRACE_GETXFPREGS, tid, 0, &xfpregs);
-  if (ret == -1)
-    {
-      if (errno == EIO)
-	{
-	  have_ptrace_getxfpregs = 0;
-	  return 0;
-	}
-
-      warning ("Couldn't read floating-point and SSE registers.");
-      return 0;
-    }
+  
+  if (ptrace (PTRACE_GETFPXREGS, tid, 0, &fpxregs) == -1)
+    perror_with_name ("Couldn't read floating-point and SSE registers");
 
-  convert_to_xfpregset (&xfpregs, register_valid);
+  fill_fpxregset (&fpxregs, regno);
 
-  if (ptrace (PTRACE_SETXFPREGS, tid, 0, &xfpregs) < 0)
-    {
-      warning ("Couldn't write floating-point and SSE registers.");
-      return 0;
-    }
+  if (ptrace (PTRACE_SETFPXREGS, tid, 0, &fpxregs) == -1)
+    perror_with_name ("Couldn't write floating-point and SSE registers");
 
   return 1;
 }
@@ -749,15 +505,13 @@ dummy_sse_values (void)
 
 #else
 
-/* Stub versions of the above routines, for systems that don't have
-   PTRACE_GETXFPREGS.  */
-static int store_xfpregs (int tid) { return 0; }
-static int fetch_xfpregs (int tid) { return 0; }
+static int fetch_fpxregs (int tid) {}
+static int store_fpxregs (int tid, int regno) {}
 static void dummy_sse_values (void) {}
-
-#endif
 
+#endif /* HAVE_PTRACE_GETFPXREGS */
 \f
+
 /* Transferring arbitrary registers between GDB and inferior.  */
 
 /* Fetch register REGNO from the child process.  If REGNO is -1, do
@@ -781,9 +535,9 @@ fetch_inferior_registers (int regno)
   if ((tid = TIDGET (inferior_pid)) == 0)
     tid = inferior_pid;		/* Not a threaded program.  */
 
-  /* Use the PTRACE_GETXFPREGS request whenever possible, since it
+  /* Use the PTRACE_GETFPXREGS request whenever possible, since it
      transfers more registers in one system call, and we'll cache the
-     results.  But remember that fetch_xfpregs can fail, and return
+     results.  But remember that fetch_fpxregs can fail, and return
      zero.  */
   if (regno == -1)
     {
@@ -796,7 +550,7 @@ fetch_inferior_registers (int regno)
 	  return;
 	}
 
-      if (fetch_xfpregs (tid))
+      if (fetch_fpxregs (tid))
 	return;
       fetch_fpregs (tid);
       return;
@@ -808,9 +562,9 @@ fetch_inferior_registers (int regno)
       return;
     }
 
-  if (GETXFPREGS_SUPPLIES (regno))
+  if (GETFPXREGS_SUPPLIES (regno))
     {
-      if (fetch_xfpregs (tid))
+      if (fetch_fpxregs (tid))
 	return;
 
       /* Either our processor or our kernel doesn't support the SSE
@@ -824,8 +578,7 @@ fetch_inferior_registers (int regno)
       return;
     }
 
-  internal_error ("i386-linux-nat.c (fetch_inferior_registers): "
-		  "got request for bad register number %d", regno);
+  internal_error ("Got request for bad register number %d.", regno);
 }
 
 /* Store register REGNO back into the child process.  If REGNO is -1,
@@ -848,40 +601,40 @@ store_inferior_registers (int regno)
   if ((tid = TIDGET (inferior_pid)) == 0)
     tid = inferior_pid;		/* Not a threaded program.  */
 
-  /* Use the PTRACE_SETXFPREGS requests whenever possibl, since it
+  /* Use the PTRACE_SETFPXREGS requests whenever possible, since it
      transfers more registers in one system call.  But remember that
-     store_xfpregs can fail, and return zero.  */
+     store_fpxregs can fail, and return zero.  */
   if (regno == -1)
     {
-      store_regs (tid);
-      if (store_xfpregs (tid))
+      store_regs (tid, regno);
+      if (store_fpxregs (tid, regno))
 	return;
-      store_fpregs (tid);
+      store_fpregs (tid, regno);
       return;
     }
 
   if (GETREGS_SUPPLIES (regno))
     {
-      store_regs (tid);
+      store_regs (tid, regno);
       return;
     }
 
-  if (GETXFPREGS_SUPPLIES (regno))
+  if (GETFPXREGS_SUPPLIES (regno))
     {
-      if (store_xfpregs (tid))
+      if (store_fpxregs (tid, regno))
 	return;
 
       /* Either our processor or our kernel doesn't support the SSE
 	 registers, so just write the FP registers in the traditional
 	 way.  */
-      store_fpregs (tid);
+      store_fpregs (tid, regno);
       return;
     }
 
   internal_error ("Got request to store bad register number %d.", regno);
 }
-
 \f
+
 /* Interpreting register set info found in core files.  */
 
 /* Provide registers to GDB from a core file.
@@ -889,7 +642,7 @@ store_inferior_registers (int regno)
    (We can't use the generic version of this function in
    core-regset.c, because Linux has *three* different kinds of
    register set notes.  core-regset.c would have to call
-   supply_xfpregset, which most platforms don't have.)
+   supply_fpxregset, which most platforms don't have.)
 
    CORE_REG_SECT points to an array of bytes, which are the contents
    of a `note' from a core file which BFD thinks might contain
@@ -898,8 +651,7 @@ store_inferior_registers (int regno)
    WHICH says which register set corelow suspects this is:
      0 --- the general-purpose register set, in elf_gregset_t format
      2 --- the floating-point register set, in elf_fpregset_t format
-     3 --- the extended floating-point register set, in struct
-           user_xfpregs_struct format
+     3 --- the extended floating-point register set, in elf_fpxregset_t format
 
    REG_ADDR isn't used on Linux.  */
 
@@ -932,17 +684,17 @@ fetch_core_registers (char *core_reg_sec
 	}
       break;
 
-#ifdef HAVE_PTRACE_GETXFPREGS
+#ifdef HAVE_PTRACE_GETFPXREGS
       {
-	struct user_xfpregs_struct xfpregset;
+	elf_fpxregset_t fpxregset;
 
       case 3:
-	if (core_reg_size != sizeof (xfpregset))
-	  warning ("Wrong size user_xfpregs_struct in core file.");
+	if (core_reg_size != sizeof (fpxregset))
+	  warning ("Wrong size fpxregset in core file.");
 	else
 	  {
-	    memcpy (&xfpregset, core_reg_sect, sizeof (xfpregset));
-	    supply_xfpregset (&xfpregset);
+	    memcpy (&fpxregset, core_reg_sect, sizeof (fpxregset));
+	    supply_fpxregset (&fpxregset);
 	  }
 	break;
       }
@@ -955,8 +707,8 @@ fetch_core_registers (char *core_reg_sec
       break;
     }
 }
-
 \f
+
 /* The instruction for a Linux system call is:
        int $0x80
    or 0xcd 0x80.  */
@@ -1040,8 +792,8 @@ child_resume (int pid, int step, enum ta
   if (ptrace (request, pid, 0, target_signal_to_host (signal)) == -1)
     perror_with_name ("ptrace");
 }
-
 \f
+
 /* Calling functions in shared libraries.  */
 /* FIXME: kettenis/2000-03-05: Doesn't this belong in a
    target-dependent file?  The function
@@ -1077,7 +829,6 @@ find_minsym_and_objfile (char *name, str
   return 0;
 }
 
-
 static CORE_ADDR
 skip_hurd_resolver (CORE_ADDR pc)
 {
@@ -1133,8 +884,8 @@ i386_linux_skip_solib_resolver (CORE_ADD
 
   return 0;
 }
-
 \f
+
 /* Register that we are able to handle Linux ELF core file formats.  */
 
 static struct core_fns linux_elf_core_fns =
Index: acconfig.h
===================================================================
RCS file: /cvs/src/src/gdb/acconfig.h,v
retrieving revision 1.11
diff -u -p -r1.11 acconfig.h
--- acconfig.h	2000/08/02 11:11:46	1.11
+++ acconfig.h	2000/08/10 16:57:04
@@ -110,8 +110,8 @@
 /* Define if <sys/ptrace.h> defines the PTRACE_GETREGS request.  */
 #undef HAVE_PTRACE_GETREGS
 
-/* Define if <sys/ptrace.h> defines the PTRACE_GETXFPREGS request.  */
-#undef HAVE_PTRACE_GETXFPREGS
+/* Define if <sys/ptrace.h> defines the PTRACE_GETFPXREGS request.  */
+#undef HAVE_PTRACE_GETFPXREGS
 
 /* Define if gnu-regex.c included with GDB should be used. */
 #undef USE_INCLUDED_REGEX
Index: configure.in
===================================================================
RCS file: /cvs/src/src/gdb/configure.in,v
retrieving revision 1.41
diff -u -p -r1.41 configure.in
--- configure.in	2000/08/02 11:11:47	1.41
+++ configure.in	2000/08/10 16:57:07
@@ -1,5 +1,5 @@
 dnl Autoconf configure script for GDB, the GNU debugger.
-dnl Copyright 1995, 1996, 1997, 1998, 1999 Free Software Foundation, Inc.
+dnl Copyright 1995, 1996, 1997, 1998, 1999, 2000 Free Software Foundation, Inc.
 dnl
 dnl This file is part of GDB.
 dnl 
@@ -159,22 +159,16 @@ if test $gdb_cv_have_ptrace_getregs = ye
   AC_DEFINE(HAVE_PTRACE_GETREGS)
 fi
 
-dnl See if ptrace.h provides the PTRACE_GETXFPREGS request.
-dnl PTRACE_GETXFPREGS is a Cygnus invention, since we wrote our own
-dnl Linux kernel patch for SSE support.  That patch may or may not
-dnl actually make it into the official distribution.  If you find that
-dnl years have gone by since this configure test was added, and Linux
-dnl isn't using PTRACE_GETXFPREGS, that means that our patch didn't
-dnl make it, and you can delete this code.
-AC_MSG_CHECKING(for PTRACE_GETXFPREGS)
-AC_CACHE_VAL(gdb_cv_have_ptrace_getxfpregs,
+dnl See if ptrace.h provides the PTRACE_GETFPXREGS request.
+AC_MSG_CHECKING(for PTRACE_GETFPXREGS)
+AC_CACHE_VAL(gdb_cv_have_ptrace_getfpxregs,
 [AC_TRY_COMPILE([#include <sys/ptrace.h>],
-		[PTRACE_GETXFPREGS;],
-		[gdb_cv_have_ptrace_getxfpregs=yes],
-		[gdb_cv_have_ptrace_getxfpregs=no])])
-AC_MSG_RESULT($gdb_cv_have_ptrace_getxfpregs)
-if test $gdb_cv_have_ptrace_getxfpregs = yes; then
-  AC_DEFINE(HAVE_PTRACE_GETXFPREGS)
+		[PTRACE_GETFPXREGS;],
+		[gdb_cv_have_ptrace_getfpxregs=yes],
+		[gdb_cv_have_ptrace_getfpxregs=no])])
+AC_MSG_RESULT($gdb_cv_have_ptrace_getfpxregs)
+if test $gdb_cv_have_ptrace_getfpxregs = yes; then
+  AC_DEFINE(HAVE_PTRACE_GETFPXREGS)
 fi
 
 AC_CHECK_LIB(socket, socketpair)
Index: config/i386/linux.mh
===================================================================
RCS file: /cvs/src/src/gdb/config/i386/linux.mh,v
retrieving revision 1.2
diff -u -p -r1.2 linux.mh
--- config/i386/linux.mh	2000/06/12 06:09:05	1.2
+++ config/i386/linux.mh	2000/08/10 16:57:07
@@ -5,6 +5,7 @@ XDEPFILES=
 
 NAT_FILE= nm-linux.h
 NATDEPFILES= infptrace.o solib.o inftarg.o fork-child.o corelow.o \
-	core-aout.o i386v-nat.o i386-linux-nat.o linux-thread.o lin-thread.o
+	core-aout.o i386v-nat.o i386-linux-nat.o linux-thread.o lin-thread.o \
+	i387-nat.o
 
 LOADLIBES = -ldl -rdynamic
Index: config/i386/tm-linux.h
===================================================================
RCS file: /cvs/src/src/gdb/config/i386/tm-linux.h,v
retrieving revision 1.7
diff -u -p -r1.7 tm-linux.h
--- config/i386/tm-linux.h	2000/07/07 00:30:35	1.7
+++ config/i386/tm-linux.h	2000/08/10 16:57:07
@@ -1,5 +1,5 @@
 /* Definitions to target GDB to GNU/Linux on 386.
-   Copyright 1992, 1993 Free Software Foundation, Inc.
+   Copyright 1992, 1993, 2000 Free Software Foundation, Inc.
 
    This file is part of GDB.
 
@@ -23,7 +23,7 @@
 
 #define I386_GNULINUX_TARGET
 #define HAVE_I387_REGS
-#ifdef HAVE_PTRACE_GETXFPREGS
+#ifdef HAVE_PTRACE_GETFPXREGS
 #define HAVE_SSE_REGS
 #endif
 
From ac131313@cygnus.com Thu Aug 10 11:15:00 2000
From: Andrew Cagney <ac131313@cygnus.com>
To: jtc@redback.com
Cc: gdb-patches@sourceware.cygnus.com
Subject: Re: RFA: dcache corruption bug
Date: Thu, 10 Aug 2000 11:15:00 -0000
Message-id: <3992F076.DDCE32EC@cygnus.com>
References: <5mya26p8dt.fsf@jtc.redback.com>
X-SW-Source: 2000-08/msg00204.html
Content-length: 4525

> To fix this problem, I changed dcache_alloc() to initialize the
> address and invalidate the cache line before returning a new block.

Ok.  I suspect they were trying to avoid double writes to the data
section.

> Other related issues:
> 
> * dcache makes no attempt to remove the least-recently-used block when
>   a cache line is recycled.  When a new cache-line is allocated it is
>   added to the tail of the valid list.  If there aren't any cache-lines
>   in the free list, the one from the head of the valid list is recycled.
>   Anyone have any reasons why making this a LRU cache is a bad idea?

From memory, that algorithm isn't totally bad, just less efficient on
average than LRU.  To notice this you must be maxing out the data cache.

> * dcache has a free list and a valid list.  Why not just have one list
>   and invalidate unused cache lines.  When we need a new block, we can
>   just grab a line from the pool.  With a LRU cache, the unused blocks
>   will be the ones subject for re-cycling.

This is just implementation.  If the chain is long then you would want
to be careful to avoid searching through its entire length - host
page/cache problems - more carefully ordered.

> * Is there a generic set of list manipulation macros in libiberty?  I
>   thought there was, but couldn't find anything.

GDB's bcache?

> 2000-08-09  J.T. Conklin  <jtc@redback.com>
> 
>         * dcache.c (dcache_alloc): Changed to take address of line as an
>         argument, and to invalidate cache line before returning.
>         (dcache_peek_byte): Updated.
>         (dcache_poke_byte): Updated.

Ok with me.

	Andrew
> 
> Index: dcache.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/dcache.c,v
> retrieving revision 1.5
> diff -c -r1.5 dcache.c
> *** dcache.c    2000/07/30 01:48:25     1.5
> --- dcache.c    2000/08/09 18:17:28
> ***************
> *** 157,163 ****
> 
>   static int dcache_write_line (DCACHE * dcache, struct dcache_block *db);
> 
> ! static struct dcache_block *dcache_alloc (DCACHE * dcache);
> 
>   static int dcache_writeback (DCACHE * dcache);
> 
> --- 157,163 ----
> 
>   static int dcache_write_line (DCACHE * dcache, struct dcache_block *db);
> 
> ! static struct dcache_block *dcache_alloc (DCACHE * dcache, CORE_ADDR addr);
> 
>   static int dcache_writeback (DCACHE * dcache);
> 
> ***************
> *** 267,281 ****
> 
> 
>   /* Get a free cache block, put or keep it on the valid list,
> !    and return its address.  The caller should store into the block
> !    the address and data that it describes, then remque it from the
> !    free list and insert it into the valid list.  This procedure
> !    prevents errors from creeping in if a memory retrieval is
> !    interrupted (which used to put garbage blocks in the valid
> !    list...).  */
> 
>   static struct dcache_block *
> ! dcache_alloc (DCACHE *dcache)
>   {
>     register struct dcache_block *db;
> 
> --- 267,276 ----
> 
> 
>   /* Get a free cache block, put or keep it on the valid list,
> !    and return its address.  */
> 
>   static struct dcache_block *
> ! dcache_alloc (DCACHE *dcache, CORE_ADDR addr)
>   {
>     register struct dcache_block *db;
> 
> ***************
> *** 297,302 ****
> --- 292,302 ----
>         dcache_write_line (dcache, db);
>       }
> 
> +   db->addr = MASK(addr);
> +   db->refs = 0;
> +   db->anydirty = 0;
> +   memset (db->state, ENTRY_BAD, sizeof (db->data));
> +
>     /* append this line to end of valid list */
>     if (!dcache->valid_head)
>       dcache->valid_head = db;
> ***************
> *** 327,335 ****
>           dcache_write_line (dcache, db);
>         }
>         else
> !       db = dcache_alloc (dcache);
>         immediate_quit++;
> -       db->addr = MASK (addr);
>         while (done < LINE_SIZE)
>         {
>           int try =
> --- 327,335 ----
>           dcache_write_line (dcache, db);
>         }
>         else
> !       db = dcache_alloc (dcache, addr);
> !
>         immediate_quit++;
>         while (done < LINE_SIZE)
>         {
>           int try =
> ***************
> *** 379,387 ****
> 
>     if (!db)
>       {
> !       db = dcache_alloc (dcache);
> !       db->addr = MASK (addr);
> !       memset (db->state, ENTRY_BAD, sizeof (db->data));
>       }
> 
>     db->data[XFORM (addr)] = *ptr;
> --- 379,385 ----
> 
>     if (!db)
>       {
> !       db = dcache_alloc (dcache, addr);
>       }
> 
>     db->data[XFORM (addr)] = *ptr;
> 
> --
> J.T. Conklin
> RedBack Networks
From ac131313@cygnus.com Thu Aug 10 11:27:00 2000
From: Andrew Cagney <ac131313@cygnus.com>
To: jtc@redback.com
Cc: gdb-patches@sourceware.cygnus.com
Subject: Re: RFA: patch to invalidate dcache in .to_open vector
Date: Thu, 10 Aug 2000 11:27:00 -0000
Message-id: <3992F34B.3A42CA3C@cygnus.com>
References: <5m66paowj1.fsf@jtc.redback.com>
X-SW-Source: 2000-08/msg00205.html
Content-length: 1249

"J.T. Conklin" wrote:
> 
> I submit the enclosed patch for approval.
> 
> I found that most of .to_open vectors which call dcache_init() do so
> even if the dcache has been created in an earlier call.  This leads to
> a dcache-sized memory leak each time the target is opened.  Instead,
> the cache should be invalidated ("flushed" using gdb's strange sense
> of the word --- I swear I'm going to change that soon :-).

Yep, thanks.

	Andrew

PS: Just an asside for any one curious.  As mentioned in the TODO file,
this patch highlights a problem with how GDB opens targets. The target
side does too much.  Instead of ``target ...'' calling .to_open()
directly it should call generic GDB code and then that should call
.to_open().  We could then flush these problems.  The TODO tries to
explain the required change.

> 2000-08-09  J.T. Conklin  <jtc@redback.com>
> 
>         * monitor.c (monitor_open): If a dcache has already been created,
>         invalidate it rather than creating another.
>         * ocd.c (ocd_open): Likewise.
>         * remote-nindy.c (nindy_open): Likewise.
>         * remote-sds.c (sds_open): Likewise.
>         * remote-utils.c (gr_open): Likewise.
>         * remote.c (remote_open_1, remote_cisco_open): Likewise.
From ac131313@cygnus.com Thu Aug 10 11:37:00 2000
From: Andrew Cagney <ac131313@cygnus.com>
To: Eli Zaretskii <eliz@is.elta.co.il>
Cc: gdb-patches@sources.redhat.com, kazu@hxi.com
Subject: Re: [patch] gdba.el: Fix a typo.
Date: Thu, 10 Aug 2000 11:37:00 -0000
Message-id: <3992F548.39B61F79@cygnus.com>
References: <200008062138.OAA04842@cygnus.com> <398F6F48.264DC27B@cygnus.com> <200008080645.CAA02421@indy.delorie.com>
X-SW-Source: 2000-08/msg00206.html
Content-length: 613

Eli Zaretskii wrote:
> 
> > Date: Mon, 07 Aug 2000 19:24:09 -0700
> > From: Andrew Cagney <ac131313@cygnus.com>
> >
> > BTW, does any one know if this is the master version of this file or is
> > the master in the EMACS distribution?
> 
> It looks like gdba.el is a *very* old and outdated version of gud.el
> that is part of the standard Emacs distribution.  Why do we need to
> keep gdba.el in GDB?

Ok,

Kazu, can you instead check in a patch that marks the file ``OBSOLETE''
(Don't forget to mention it the NEWS file). (Your free to also fix the
typos).
Eli, does the doco refer to this file at all?

	Andrew
From jtc@redback.com Thu Aug 10 11:41:00 2000
From: jtc@redback.com (J.T. Conklin)
To: Andrew Cagney <ac131313@cygnus.com>
Cc: gdb-patches@sourceware.cygnus.com
Subject: Re: RFA: dcache corruption bug
Date: Thu, 10 Aug 2000 11:41:00 -0000
Message-id: <5mem3xklhr.fsf@jtc.redback.com>
References: <5mya26p8dt.fsf@jtc.redback.com> <3992F076.DDCE32EC@cygnus.com>
X-SW-Source: 2000-08/msg00207.html
Content-length: 1357

>>>>> "Andrew" == Andrew Cagney <ac131313@cygnus.com> writes:
>> Other related issues:
>> 
>> * dcache makes no attempt to remove the least-recently-used block when
>> a cache line is recycled.  When a new cache-line is allocated it is
>> added to the tail of the valid list.  If there aren't any cache-lines
>> in the free list, the one from the head of the valid list is recycled.
>> Anyone have any reasons why making this a LRU cache is a bad idea?

Andrew> From memory, that algorithm isn't totally bad, just less
Andrew> efficient on average than LRU.  To notice this you must be
Andrew> maxing out the data cache.

The case I was thinking of was user-defined functions used to walk
large complicated data structures.  Typically the 'core' nodes are
going to be accessed more often then the leaves.  This assumes, of
course, that someone's going to write traversal scripts, which is
somewhat difficult given today's command language limitations.

Given that, I'll let this sit until it's clear that this is a problem.

>> * Is there a generic set of list manipulation macros in libiberty?  I
>> thought there was, but couldn't find anything.

Andrew> GDB's bcache?

I was thinking of macros like those in *BSD's <sys/queue.h>.  But I'll
think of bcache the next time I need a hash table...  

Thanks,

        --jtc

-- 
J.T. Conklin
RedBack Networks
From ac131313@cygnus.com Thu Aug 10 11:42:00 2000
From: Andrew Cagney <ac131313@cygnus.com>
To: Kazu Hirata <kazu@hxi.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [patch] hppa-tdep.c: Fix a comment typo.
Date: Thu, 10 Aug 2000 11:42:00 -0000
Message-id: <3992F6E3.A3A00021@cygnus.com>
References: <200008070645.XAA17553@cygnus.com>
X-SW-Source: 2000-08/msg00208.html
Content-length: 460

Kazu Hirata wrote:
> 
> Hi,
> 
> Attached is a patch to fix a comment typo in hppa-tdep.c.
> 
> OK to commit?
> 
> Thanks,
> 
> Kazu Hirata
> 
> 2000-08-07  Kazu Hirata  <kazu@hxi.com>
> 
>         * hppa_tdep.c: Fix a comment typo.

Yes, fine.

FYI, there was a colourful (:-) discussion earlier that concluded that
simple spelling typos and the like shouldn't need approval.  Just post
it.  Larger rewrites and the like may need additional comment.

	Andrew
From jtc@redback.com Thu Aug 10 12:11:00 2000
From: jtc@redback.com (J.T. Conklin)
To: gdb-patches@sourceware.cygnus.com
Subject: RFA: patch to fix 'info dcache' crash
Date: Thu, 10 Aug 2000 12:11:00 -0000
Message-id: <5m8zu5kk2r.fsf@jtc.redback.com>
X-SW-Source: 2000-08/msg00209.html
Content-length: 1854

If you enable data caching (set remotecache 1) and then do an `info
dcache' before issuing a target command that creates a dcache, GDB 
crashes.  This patch avoids printing the cache state unless a dcache
has been created.

        --jtc

2000-08-10  J.T. Conklin  <jtc@redback.com>

	* dcache.c (dcache_info): Don't print cache state if last_cache 
	is NULL.

Index: dcache.c
===================================================================
RCS file: /cvs/src/src/gdb/dcache.c,v
retrieving revision 1.6
diff -c -r1.6 dcache.c
*** dcache.c	2000/08/10 18:54:27	1.6
--- dcache.c	2000/08/10 18:58:10
***************
*** 461,481 ****
    printf_filtered ("Dcache enabled, line width %d, depth %d\n",
  		   LINE_SIZE, DCACHE_SIZE);
  
!   printf_filtered ("Cache state:\n");
! 
!   for (p = last_cache->valid_head; p; p = p->p)
      {
!       int j;
!       printf_filtered ("Line at %s, referenced %d times\n",
! 		       paddr (p->addr), p->refs);
  
!       for (j = 0; j < LINE_SIZE; j++)
! 	printf_filtered ("%02x", p->data[j] & 0xFF);
!       printf_filtered ("\n");
  
!       for (j = 0; j < LINE_SIZE; j++)
! 	printf_filtered (" %2x", p->state[j]);
!       printf_filtered ("\n");
      }
  }
  
--- 461,484 ----
    printf_filtered ("Dcache enabled, line width %d, depth %d\n",
  		   LINE_SIZE, DCACHE_SIZE);
  
!   if (last_cache)
      {
!       printf_filtered ("Cache state:\n");
! 
!       for (p = last_cache->valid_head; p; p = p->p)
! 	{
! 	  int j;
! 	  printf_filtered ("Line at %s, referenced %d times\n",
! 			   paddr (p->addr), p->refs);
  
! 	  for (j = 0; j < LINE_SIZE; j++)
! 	    printf_filtered ("%02x", p->data[j] & 0xFF);
! 	  printf_filtered ("\n");
  
! 	  for (j = 0; j < LINE_SIZE; j++)
! 	    printf_filtered (" %2x", p->state[j]);
! 	  printf_filtered ("\n");
! 	}
      }
  }
  

-- 
J.T. Conklin
RedBack Networks
From ac131313@cygnus.com Thu Aug 10 12:26:00 2000
From: Andrew Cagney <ac131313@cygnus.com>
To: jtc@redback.com
Cc: gdb-patches@sourceware.cygnus.com
Subject: Re: RFA: patch to fix 'info dcache' crash
Date: Thu, 10 Aug 2000 12:26:00 -0000
Message-id: <39930144.47ADDC03@cygnus.com>
References: <5m8zu5kk2r.fsf@jtc.redback.com>
X-SW-Source: 2000-08/msg00210.html
Content-length: 58

Ok.

Want to be listed as ``dcache'' maintainer?

	Andrew
From ac131313@cygnus.com Thu Aug 10 16:55:00 2000
From: Andrew Cagney <ac131313@cygnus.com>
To: GDB Patches <gdb-patches@sourceware.cygnus.com>
Subject: [patch] sparc-tdep.c - bad function call
Date: Thu, 10 Aug 2000 16:55:00 -0000
Message-id: <39934033.9377CAF4@cygnus.com>
X-SW-Source: 2000-08/msg00211.html
Content-length: 1321

FYI,

I've checked in the attatched.  Something else that this ISO PARAMS
flushed out.

	Andrew
Thu Aug 10 15:28:17 2000  Andrew Cagney  <cagney@ryobi.cygnus.com>

	* sparc-tdep.c (sparc_init_extra_frame_info): Fix number of
 	arguments to fetch_instruction.

Index: sparc-tdep.c
===================================================================
RCS file: /cvs/cvsfiles/devo/gdb/sparc-tdep.c,v
retrieving revision 1.112
diff -p -r1.112 sparc-tdep.c
*** sparc-tdep.c	2000/07/30 01:49:41	1.112
--- sparc-tdep.c	2000/08/10 23:07:35
*************** sparc_init_extra_frame_info (int fromlea
*** 340,346 ****
           negative number if a flat frame) to the sp.  FIXME: Does not
           handle large frames which will need more than one instruction
           to adjust the sp.  */
!       insn = fetch_instruction (prologue_start, 4);
        if (X_OP (insn) == 2 && X_RD (insn) == 14 && X_OP3 (insn) == 0
  	  && X_I (insn) && X_SIMM13 (insn) < 0)
  	{
--- 340,346 ----
           negative number if a flat frame) to the sp.  FIXME: Does not
           handle large frames which will need more than one instruction
           to adjust the sp.  */
!       insn = fetch_instruction (prologue_start);
        if (X_OP (insn) == 2 && X_RD (insn) == 14 && X_OP3 (insn) == 0
  	  && X_I (insn) && X_SIMM13 (insn) < 0)
  	{
From guo@cup.hp.com Thu Aug 10 17:27:00 2000
From: Jimmy Guo <guo@cup.hp.com>
To: gdb-patches@sourceware.cygnus.com
Subject: [patch] gdb MAINTAINERS
Date: Thu, 10 Aug 2000 17:27:00 -0000
Message-id: <Pine.LNX.4.10.10008101725430.23845-100000@hpcll168.cup.hp.com>
X-SW-Source: 2000-08/msg00212.html
Content-length: 1052

FYI I'll committed the change to MAINTAINERS to use my email address
instead of an alias for hp tests maintainership.

- Jimmy Guo, guo@cup.hp.com

Index: MAINTAINERS
===================================================================
RCS file: /cvs/src/src/gdb/MAINTAINERS,v
retrieving revision 1.45
diff -c -r1.45 MAINTAINERS
*** MAINTAINERS	2000/08/10 19:02:06	1.45
--- MAINTAINERS	2000/08/11 00:23:46
***************
*** 185,191 ****
  			Eli Zaretskii		eliz@gnu.org
  testsuite	 	Stan Shebs		shebs@apple.com
  			Fernando Nasser		fnasser@cygnus.com
!   hp tests (gdb.hp)	Jimmy Guo	 adl-debugger-wdb-merge-guru@cup.hp.com
    Java tests (gdb.java)	Anthony Green 		green@cygnus.com
  Kernel Object Display	Fernando Nasser		fnasser@cygnus.com
  
--- 185,191 ----
  			Eli Zaretskii		eliz@gnu.org
  testsuite	 	Stan Shebs		shebs@apple.com
  			Fernando Nasser		fnasser@cygnus.com
!   hp tests (gdb.hp)	Jimmy Guo		guo@cup.hp.com
    Java tests (gdb.java)	Anthony Green 		green@cygnus.com
  Kernel Object Display	Fernando Nasser		fnasser@cygnus.com