From mboxrd@z Thu Jan 1 00:00:00 1970 From: nsd@cygnus.com To: john@feith.com Cc: cgf@cygnus.com, eliz@delorie.com, gdb-patches@sourceware.cygnus.com, jimb@cygnus.com, msnyder@cygnus.com Subject: Re: GDB 4.17 Patch for stack aligned i386 code Date: Fri, 24 Mar 2000 16:54:00 -0000 Message-id: <200003250054.AAA07709@nog.bosbc.com> References: <200003250030.TAA14328@jwlab.FEITH.COM> X-SW-Source: 2000-03/msg00576.html >I'm not sure what I still have laying around other than a very old patch >for GCC. The idea is to handle a prologue which looks like: Thanks, that makes it clear. At the moment, I don't think my patch would handle that correctly. The "tightening up" that I mentioned earlier might do the trick, though. Nick >From dan@cgsoftware.com Fri Mar 24 18:25:00 2000 From: dan@cgsoftware.com (Daniel Berlin+list.gdb-patches) To: gdb-patches@sourceware.cygnus.com Subject: [RFA] Deprecation fixes Date: Fri, 24 Mar 2000 18:25:00 -0000 Message-id: X-SW-Source: 2000-03/msg00577.html Content-length: 291 This patch fixes a crash if you call "maintenance deprecate" with no arguments. I also added the prototype to make the warnings about it being implicitly declared go away, and removed the unknown escape sequences caused by spaces where they shouldn't be. Fernando, can i check it in? --Dan >From cgf@cygnus.com Fri Mar 24 18:33:00 2000 From: Chris Faylor To: gdb-patches@sourceware.cygnus.com Subject: [PATCH] revert win32-nat.c stack handling to working version Date: Fri, 24 Mar 2000 18:33:00 -0000 Message-id: <20000324213253.A23842@cygnus.com> X-SW-Source: 2000-03/msg00578.html Content-length: 4277 I added some "functionality" to win32-nat.c a while ago while under the mistaken impression that using the Microsoft stack-walking APIs would somehow provide more functionality than what was previously available in gdb. Instead, I just broke things so that stack walking stopped after a few frames. The enclosed patch reverts gdb to its previous behavior and also adds an additional unrelated trap for illegal instructions, which was missing before (I know this should be a separate patch but...). I did not run this through the testsuite because bfd seems to still be badly broken on sourceware so I know that most of the tests would fail. I did verify that the gdb 'bt' command now displays correct information, however. cgf Index: win32-nat.c =================================================================== RCS file: /cvs/src/src/gdb/win32-nat.c,v retrieving revision 1.4 diff -u -p -r1.4 win32-nat.c --- win32-nat.c 2000/02/28 06:43:20 1.4 +++ win32-nat.c 2000/03/25 02:23:28 @@ -601,6 +601,11 @@ handle_exception (struct target_waitstat current_event.u.Exception.ExceptionRecord.ExceptionAddress)); ourstatus->value.sig = TARGET_SIGNAL_TRAP; break; + case EXCEPTION_ILLEGAL_INSTRUCTION: + DEBUG_EXCEPT (("gdb: Target exception SINGLE_ILL at 0x%08x\n", + current_event.u.Exception.ExceptionRecord.ExceptionAddress)); + ourstatus->value.sig = TARGET_SIGNAL_ILL; + break; default: /* This may be a structured exception handling exception. In that case, we want to let the program try to handle it, and @@ -1272,61 +1277,4 @@ cygwin_pid_to_str (int pid) else sprintf (buf, "thread %d.0x%x", current_event.dwProcessId, pid); return buf; -} - -static LPVOID __stdcall -sfta(HANDLE h, DWORD d) -{ - return NULL; -} - -static DWORD __stdcall -sgmb(HANDLE h, DWORD d) -{ -#if 0 - return 4; -#else - return SymGetModuleBase (h, d) ?: 4; -#endif -} - -CORE_ADDR -child_frame_chain(struct frame_info *f) -{ - STACKFRAME *sf = (STACKFRAME *) f->extra_info; - if (!StackWalk (IMAGE_FILE_MACHINE_I386, current_process_handle, - current_thread->h, sf, NULL, NULL, SymFunctionTableAccess, sgmb, NULL) || - !sf->AddrReturn.Offset) - return 0; - return sf->AddrFrame.Offset; -} - -CORE_ADDR -child_frame_saved_pc(struct frame_info *f) -{ - STACKFRAME *sf = (STACKFRAME *) f->extra_info; - return sf->AddrReturn.Offset; -} - -void -child_init_frame(int leaf, struct frame_info *f) -{ - STACKFRAME *sf; - - if (f->next && f->next->extra_info) - f->extra_info = f->next->extra_info; - else if (f->prev && f->prev->extra_info) - f->extra_info = f->prev->extra_info; - else - { - sf = (STACKFRAME *) frame_obstack_alloc (sizeof (*sf)); - f->extra_info = (struct frame_extra_info *) sf; - memset (sf, 0, sizeof(*sf)); - sf->AddrPC.Offset = f->pc; - sf->AddrPC.Mode = AddrModeFlat; - sf->AddrStack.Offset = current_thread->context.Esp; - sf->AddrStack.Mode = AddrModeFlat; - sf->AddrFrame.Offset = f->frame; - sf->AddrFrame.Mode = AddrModeFlat; - } } Index: config/i386/tm-cygwin.h =================================================================== RCS file: /cvs/src/src/gdb/config/i386/tm-cygwin.h,v retrieving revision 1.1.1.5 diff -u -p -r1.1.1.5 tm-cygwin.h --- tm-cygwin.h 1999/12/22 21:45:13 1.1.1.5 +++ tm-cygwin.h 2000/03/25 02:23:28 @@ -1,5 +1,5 @@ /* Macro definitions for i386 running under the win32 API Unix. - Copyright 1995 - 1999 Free Software Foundation, Inc. + Copyright 1995, 1996, 1997, 1998, 1999, 2000 Free Software Foundation, Inc. This file is part of GDB. @@ -29,20 +29,3 @@ extern CORE_ADDR skip_trampoline_code PARAMS ((CORE_ADDR pc, char *name)); extern char *cygwin_pid_to_str PARAMS ((int pid)); - -struct frame_info; -void child_init_frame(int x, struct frame_info *); -CORE_ADDR child_frame_saved_pc(struct frame_info *); -CORE_ADDR child_frame_chain(struct frame_info *); - -#undef FRAME_CHAIN_VALID_ALTERNATE -#define FRAME_CHAIN_VALID_ALTERNATE 1 - -#undef INIT_EXTRA_FRAME_INFO -#define INIT_EXTRA_FRAME_INFO(x, f) child_init_frame(x, f) - -#undef FRAME_CHAIN -#define FRAME_CHAIN child_frame_chain - -#undef FRAME_SAVED_PC -#define FRAME_SAVED_PC child_frame_saved_pc >From cgf@cygnus.com Fri Mar 24 18:34:00 2000 From: Chris Faylor To: gdb-patches@sourceware.cygnus.com Subject: Re: [PATCH] revert win32-nat.c stack handling to working version Date: Fri, 24 Mar 2000 18:34:00 -0000 Message-id: <20000324213441.A23878@cygnus.com> References: <20000324213253.A23842@cygnus.com> X-SW-Source: 2000-03/msg00579.html Content-length: 360 On Fri, Mar 24, 2000 at 09:32:53PM -0500, Chris Faylor wrote: >I did not run this through the testsuite because bfd seems to still >be badly broken on sourceware so I know that most of the tests would >fail. Just to clarify, in case it isn't clear, I was referring to bfd for Win32 being broken. This is a know problem that is being (slowly) worked on. cgf >From ac131313@cygnus.com Fri Mar 24 22:40:00 2000 From: Andrew Cagney To: Geoff Keating Cc: gdb-patches@sourceware.cygnus.com Subject: Re: patch to psim for denormal values Date: Fri, 24 Mar 2000 22:40:00 -0000 Message-id: <38DC5F3A.FE48DC2A@cygnus.com> References: <200003250008.QAA31192@localhost.cygnus.com> X-SW-Source: 2000-03/msg00580.html Content-length: 346 Geoff Keating wrote: > > gcc/testsuite/gcc.c-torture/execute/ieee/20000320-1.c was sending the > sim into a very long (perhaps infinite) loop, because of this typo. Wow! A bug :-) > My copy of the ppc 601 user's manual correctly uses '+' here (on page > F-2). Oops, nothing like copying it down wrong. > OK to commit? Yes. Thanks. Andrew >From ac131313@cygnus.com Fri Mar 24 22:47:00 2000 From: Andrew Cagney To: jtc@redback.com Cc: gdb-patches@sourceware.cygnus.com Subject: Re: RFA: USE_STRUCT_CONVENTION for NetBSD/i386 Date: Fri, 24 Mar 2000 22:47:00 -0000 Message-id: <38DC60DF.CAD050F3@cygnus.com> References: <5msnxieegg.fsf@jtc.redbacknetworks.com> <38DAD990.D91D6D1B@cygnus.com> <5md7okvwfx.fsf@jtc.redbacknetworks.com> X-SW-Source: 2000-03/msg00581.html Content-length: 382 "J.T. Conklin" wrote: > I don't think NetBSD does anything non-standard other than defining > DEFAULT_PCC_STRUCT_RETURN to 0 in its gcc config. So this behavior > should be shared among all x86 targets that do the same: cygwin, > freebsd, linux-aout, and mach. In that case, perhaps the function should live in i386-tdep.c (with a new name). Might as well share it :-) Andrew >From ac131313@cygnus.com Fri Mar 24 23:02:00 2000 From: Andrew Cagney To: jtc@redback.com Cc: Steven Johnson , GDB Patches Subject: Re: RFA: Deprecate remote protocol sequence-ID Date: Fri, 24 Mar 2000 23:02:00 -0000 Message-id: <38DC645E.A6CCB479@cygnus.com> References: <38DAF122.3CA0E862@cygnus.com> <38DB0EE5.831CD611@ozemail.com.au> <38DB24AB.7881FFA1@cygnus.com> <5mhfdwvxcu.fsf@jtc.redbacknetworks.com> X-SW-Source: 2000-03/msg00582.html Content-length: 656 "J.T. Conklin" wrote: > > >>>>> "Andrew" == Andrew Cagney writes: > Andrew> I think a simple reliable separate transport layer is needed. I'd even > Andrew> go as far as a new packet wrapper (replacing $...#NN and +-). > > Here, here! Er, thanks! I suspect it was another of your suggestions that I've since stolen :-) I have a theory .... (obvious Monty Python quote deleted). I have a another theory. If we: o deprecate ``:'' sequence IDs o introduce a transport protocol that works o ban the transport of new/improved packets using the old/broken transport protocol. then there aren't any problems. Andrew >From ac131313@cygnus.com Fri Mar 24 23:15:00 2000 From: Andrew Cagney To: shebs@apple.com Cc: GDB Patches Subject: Re: [PATCH] Fix texinfo problems... Date: Fri, 24 Mar 2000 23:15:00 -0000 Message-id: <38DC6763.563424A2@cygnus.com> References: <38DB1875.4B504618@cygnus.com> <38DBB937.126C95E@apple.com> X-SW-Source: 2000-03/msg00583.html Content-length: 1462 Stan Shebs wrote: > > Andrew Cagney wrote: > > > > Hello, > > > > I've applied the attatched patch. It probably isn't elegant and > > probably isn't the best way of handling this :-/ However, after applying > > it I'm able to use makeinfo versions 3.12, 3.12f and 4.0 :-) > > *Please* don't add the node links back!! I went to some trouble to get > rid of them all, because they make for an utter nightmare when you're > trying to add new material. They're only useful if you want to link > nodes in some fashion other than that implied by the chapter/section > structure, and as of yet I haven't heard anyone come up with a good > rationale for linking in any other way. > > The replication of the TOC node with ifinfo and ifhtml is sufficient > to make the manual generate correctly with three versions of texinfo, > so I'm mystified as to why you think these other changes are necessary... I'm sorry, but please _don't_ delete them until I've cut this 5.0 branch :-) Without top level node entries I found that makeinfo 3.12 I was using failed. As soon as the branch goes through, you're encouraged to strip them out, I'd expect the next relese to require makeinfo 4.0. This is also why I moved the ``chapter'' and ``node'' entries from the included *.texi files into gdb.texinfo. It made it possible for me to add correct entries for those included subjects. (I discovered C-c C-u C-e :-) If there is a correct way, please fix. sorry, Andrew >From ac131313@cygnus.com Fri Mar 24 23:31:00 2000 From: Andrew Cagney To: dan@cgsoftware.com Cc: gdb-patches@sourceware.cygnus.com Subject: Re: [RFA] Deprecation fixes Date: Fri, 24 Mar 2000 23:31:00 -0000 Message-id: <38DC6B04.53CB2589@cygnus.com> References: X-SW-Source: 2000-03/msg00584.html Content-length: 385 "Daniel Berlin+list.gdb-patches" wrote: > > This patch fixes a crash if you call "maintenance deprecate" with no > arguments. > I also added the prototype to make the warnings about it being > implicitly declared go away, and removed the unknown escape sequences > caused by spaces where they shouldn't be. This sounds like it could also do with a testsuite entry. enjoy, Andrew >From ac131313@cygnus.com Fri Mar 24 23:55:00 2000 From: Andrew Cagney To: GDB Patches Subject: [PATCH} maint.c remove quoted trailing space Date: Fri, 24 Mar 2000 23:55:00 -0000 Message-id: <38DC70E4.C2ECB4E9@cygnus.com> X-SW-Source: 2000-03/msg00585.html Content-length: 1461 FYI, I've applied the following. As an aside, we can start using: "a string that" "extends over several lines" Andrew Sat Mar 25 18:51:50 2000 Andrew Cagney * maint.c (_initialize_maint_cmds): Remove quoted trailing space. Index: maint.c =================================================================== RCS file: /cvs/src/src/gdb/maint.c,v retrieving revision 1.2 diff -p -r1.2 maint.c *** maint.c 2000/03/23 23:43:19 1.2 --- maint.c 2000/03/25 07:52:32 *************** If a SOURCE file is specified, dump only *** 573,579 **** "Deprecate a command. Note that this is just in here so the \n\ testsuite can check the comamnd deprecator. You probably shouldn't use this,\n\ rather you should use the C function deprecate_cmd(). If you decide you \n\ ! want to use it: maintenance deprecate 'commandname' \"replacement\". The \n\ replacement is optional.", &maintenancelist); add_cmd ("undeprecate", class_maintenance, maintenance_undeprecate, --- 573,579 ---- "Deprecate a command. Note that this is just in here so the \n\ testsuite can check the comamnd deprecator. You probably shouldn't use this,\n\ rather you should use the C function deprecate_cmd(). If you decide you \n\ ! want to use it: maintenance deprecate 'commandname' \"replacement\". The \n\ replacement is optional.", &maintenancelist); add_cmd ("undeprecate", class_maintenance, maintenance_undeprecate, >From ac131313@cygnus.com Sat Mar 25 00:11:00 2000 From: Andrew Cagney To: Fernando Nasser , David Whedon Cc: GDB Patches Subject: [PATCH] Re-indent maint.c Date: Sat, 25 Mar 2000 00:11:00 -0000 Message-id: <38DC7448.E919C8F2@cygnus.com> X-SW-Source: 2000-03/msg00586.html Content-length: 7712 FYI, I've applied the attatched. It fixes a number of indentation problems that crept into maint.c. enjoy, Andrew Sat Mar 25 18:55:57 2000 Andrew Cagney * maint.c: Re-indent. Index: maint.c =================================================================== RCS file: /cvs/src/src/gdb/maint.c,v retrieving revision 1.3 diff -u -r1.3 maint.c --- maint.c 2000/03/25 07:58:54 1.3 +++ maint.c 2000/03/25 08:05:00 @@ -120,13 +120,13 @@ internal_error ("internal maintenance"); } -/* Someday we should allow demangling for things other than just - explicit strings. For example, we might want to be able to - specify the address of a string in either GDB's process space - or the debuggee's process space, and have gdb fetch and demangle - that string. If we have a char* pointer "ptr" that points to - a string, we might want to be able to given just the name and - have GDB demangle and print what it points to, etc. (FIXME) */ +/* Someday we should allow demangling for things other than just + explicit strings. For example, we might want to be able to specify + the address of a string in either GDB's process space or the + debuggee's process space, and have gdb fetch and demangle that + string. If we have a char* pointer "ptr" that points to a string, + we might want to be able to given just the name and have GDB + demangle and print what it points to, etc. (FIXME) */ static void maintenance_demangle (args, from_tty) @@ -180,9 +180,9 @@ display_space = strtol (args, NULL, 10); } -/* The "maintenance info" command is defined as a prefix, with allow_unknown 0. - Therefore, its own definition is called only for "maintenance info" with - no args. */ +/* The "maintenance info" command is defined as a prefix, with + allow_unknown 0. Therefore, its own definition is called only for + "maintenance info" with no args. */ /* ARGSUSED */ static void @@ -281,9 +281,9 @@ print_symbol_bcache_statistics (); } -/* The "maintenance print" command is defined as a prefix, with allow_unknown - 0. Therefore, its own definition is called only for "maintenance print" - with no args. */ +/* The "maintenance print" command is defined as a prefix, with + allow_unknown 0. Therefore, its own definition is called only for + "maintenance print" with no args. */ /* ARGSUSED */ static void @@ -360,7 +360,8 @@ /* When a comamnd is deprecated the user will be warned the first time - the command is used. If possible, a replacement will be offered. */ + the command is used. If possible, a replacement will be + offered. */ static void maintenance_deprecate (char *args, int from_tty) @@ -371,7 +372,7 @@ the command you want to deprecate, and optionally the replacement command \n\ enclosed in quotes.\n"); } - + maintenance_do_deprecate (args, 1); } @@ -385,86 +386,86 @@ printf_unfiltered ("\"maintenance undeprecate\" takes an argument, \n\ the command you want to undeprecate.\n"); } - + maintenance_do_deprecate (args, 0); - + } + +/* You really shouldn't be using this. It is just for the testsuite. + Rather, you should use deprecate_cmd() when the command is created + in _initialize_blah(). + + This function deprecates a command and optionally assigns it a + replacement. */ + +static void +maintenance_do_deprecate (char *text, int deprecate) +{ + + struct cmd_list_element *alias = NULL; + struct cmd_list_element *prefix_cmd = NULL; + struct cmd_list_element *cmd = NULL; -/* - You really shouldn't be using this. It is just for the testsuite. - Rather, you should use deprecate_cmd() when the command is created - in _initialize_blah(). - - This function deprecates a command and optionally assigns it a - replacement. -*/ - -static void maintenance_do_deprecate(char *text, int deprecate){ - - struct cmd_list_element *alias=NULL; - struct cmd_list_element *prefix_cmd=NULL; - struct cmd_list_element *cmd=NULL; - - char *start_ptr=NULL; - char *end_ptr=NULL; + char *start_ptr = NULL; + char *end_ptr = NULL; int len; - char *replacement=NULL; + char *replacement = NULL; + + if (!lookup_cmd_composition (text, &alias, &prefix_cmd, &cmd)) + { + printf_filtered ("Can't find command '%s' to deprecate.\n", text); + return; + } - if (!lookup_cmd_composition (text, &alias, &prefix_cmd, &cmd)){ - printf_filtered ("Can't find command '%s' to deprecate.\n", text); - return; - } - if (deprecate) { /* look for a replacement command */ if (start_ptr = strchr (text, '\"')) - { - start_ptr++; - if(end_ptr = strrchr (start_ptr, '\"')) - { - len = end_ptr-start_ptr; - start_ptr[len]='\0'; - replacement = xstrdup (start_ptr); - } - } + { + start_ptr++; + if (end_ptr = strrchr (start_ptr, '\"')) + { + len = end_ptr - start_ptr; + start_ptr[len] = '\0'; + replacement = xstrdup (start_ptr); + } + } } - + if (!start_ptr || !end_ptr) replacement = NULL; - - + + /* If they used an alias, we only want to deprecate the alias. - + Note the MALLOCED_REPLACEMENT test. If the command's replacement string was allocated at compile time we don't want to free the - memory. - */ + memory. */ if (alias) { - + if (alias->flags & MALLOCED_REPLACEMENT) - free (alias->replacement); - + free (alias->replacement); + if (deprecate) - alias->flags |= (DEPRECATED_WARN_USER | CMD_DEPRECATED); + alias->flags |= (DEPRECATED_WARN_USER | CMD_DEPRECATED); else - alias->flags &= ~(DEPRECATED_WARN_USER | CMD_DEPRECATED); - alias->replacement=replacement; + alias->flags &= ~(DEPRECATED_WARN_USER | CMD_DEPRECATED); + alias->replacement = replacement; alias->flags |= MALLOCED_REPLACEMENT; return; } else if (cmd) { if (cmd->flags & MALLOCED_REPLACEMENT) - free (cmd->replacement); + free (cmd->replacement); if (deprecate) - cmd->flags |= (DEPRECATED_WARN_USER | CMD_DEPRECATED); + cmd->flags |= (DEPRECATED_WARN_USER | CMD_DEPRECATED); else - cmd->flags &= ~(DEPRECATED_WARN_USER | CMD_DEPRECATED); - cmd->replacement=replacement; + cmd->flags &= ~(DEPRECATED_WARN_USER | CMD_DEPRECATED); + cmd->replacement = replacement; cmd->flags |= MALLOCED_REPLACEMENT; return; } @@ -570,17 +571,17 @@ &maintenancelist); add_cmd ("deprecate", class_maintenance, maintenance_deprecate, - "Deprecate a command. Note that this is just in here so the \n\ + "Deprecate a command. Note that this is just in here so the \n\ testsuite can check the comamnd deprecator. You probably shouldn't use this,\n\ rather you should use the C function deprecate_cmd(). If you decide you \n\ want to use it: maintenance deprecate 'commandname' \"replacement\". The \n\ replacement is optional.", &maintenancelist); add_cmd ("undeprecate", class_maintenance, maintenance_undeprecate, - "Undeprecate a command. Note that this is just in here so the \n\ + "Undeprecate a command. Note that this is just in here so the \n\ testsuite can check the comamnd deprecator. You probably shouldn't use this,\n\ -If you decide you want to use it: maintenance undeprecate 'commandname'", - &maintenancelist); +If you decide you want to use it: maintenance undeprecate 'commandname'", + &maintenancelist); add_show_from_set ( add_set_cmd ("watchdog", class_maintenance, var_zinteger, (char *) &watchdog, >From toddpw@windriver.com Sat Mar 25 00:39:00 2000 From: Todd Whitesel To: jtc@redback.com Cc: phdm@macqel.be (Philippe De Muyter), gdb-patches@sourceware.cygnus.com (gdb-patches@sourceware.cygnus.com), dan@cgsoftware.com Subject: Re: regerror link error Date: Sat, 25 Mar 2000 00:39:00 -0000 Message-id: <200003250839.AAA10592@alabama.wrs.com> References: <5m8zz8vviv.fsf@jtc.redbacknetworks.com> X-SW-Source: 2000-03/msg00587.html Content-length: 395 > I think the __regerror() function in gnu-regex.c needs to be renamed > regerror(). Absolutely agree. The __ should only be used (and must be used) if the file is part of a library provided with a compiler. If the file is part of our app, then we should not be defining a __ symbol because ANSI C reserves all __ symbols for the compiler's library! -- Todd Whitesel toddpw @ windriver.com >From fnasser@redhat.com Sat Mar 25 05:33:00 2000 From: Fernando Nasser To: Andrew Cagney Cc: dan@cgsoftware.com, gdb-patches@sourceware.cygnus.com Subject: Re: [RFA] Deprecation fixes Date: Sat, 25 Mar 2000 05:33:00 -0000 Message-id: <38DCBFB5.20AD581A@redhat.com> References: <38DC6B04.53CB2589@cygnus.com> X-SW-Source: 2000-03/msg00588.html Content-length: 511 Andrew Cagney wrote: > > This sounds like it could also do with a testsuite entry. > Andrew is right. But I don't want to let the crash possibility make into 5.0. Daniel, please check this in. But as soon as possible, do you mind writing a little testcase for it? Thank you very much. -- Fernando Nasser Red Hat, Inc. - Toronto E-Mail: fnasser@redhat.com 2323 Yonge Street, Suite #300 Tel: 416-482-2661 ext. 311 Toronto, Ontario M4P 2C9 Fax: 416-482-6299 >From dan@cgsoftware.com Sat Mar 25 07:35:00 2000 From: dan@cgsoftware.com (Daniel Berlin+list.gdb-patches) To: Andrew Cagney Cc: dan@cgsoftware.com, gdb-patches@sourceware.cygnus.com Subject: Re: [RFA] Deprecation fixes Date: Sat, 25 Mar 2000 07:35:00 -0000 Message-id: <1z4zdpvk.fsf@dan.resnet.rochester.edu> References: <38DC6B04.53CB2589@cygnus.com> X-SW-Source: 2000-03/msg00589.html Content-length: 767 Andrew Cagney writes: > "Daniel Berlin+list.gdb-patches" wrote: > > > > This patch fixes a crash if you call "maintenance deprecate" with no > > arguments. > > I also added the prototype to make the warnings about it being > > implicitly declared go away, and removed the unknown escape sequences > > caused by spaces where they shouldn't be. > > This sounds like it could also do with a testsuite entry. Committed, with a testsuite entry. Just FYI, the original patch had some reindentation (IE it fixed the indentation of the deprecate command so that the function name always appear fist on the line). Since you reindented it, i just redid the change on the new indented version, without the indentation changes. > > enjoy, > Andrew >From dan@cgsoftware.com Sat Mar 25 07:36:00 2000 From: dan@cgsoftware.com (Daniel Berlin+list.gdb-patches) To: Fernando Nasser Cc: Andrew Cagney , dan@cgsoftware.com, gdb-patches@sourceware.cygnus.com Subject: Re: [RFA] Deprecation fixes Date: Sat, 25 Mar 2000 07:36:00 -0000 Message-id: References: <38DC6B04.53CB2589@cygnus.com> <38DCBFB5.20AD581A@redhat.com> X-SW-Source: 2000-03/msg00590.html Content-length: 470 Fernando Nasser writes: > Andrew Cagney wrote: > > > > This sounds like it could also do with a testsuite entry. > > > > Andrew is right. But I don't want to let the crash possibility make > into 5.0. > Daniel, please check this in. But as soon as possible, do you mind > writing a > little testcase for it? I added a testcase when i checked it in (after verifying it failed before the patch, and passed after). > > Thank you very much. >From dima@Chg.RU Sat Mar 25 09:44:00 2000 From: Dmitry Sivachenko To: gdb-patches@sourceware.cygnus.com Subject: typo in annotate.texi Date: Sat, 25 Mar 2000 09:44:00 -0000 Message-id: <200003251744.UAA14592@netserv1.chg.ru> X-SW-Source: 2000-03/msg00591.html Content-length: 1086 Hello! Please apply this patch to annotate.texi. The changed reference is obviously wrong, despite it points to the valid node. --dima --- annotate.1.2.texi Sat Mar 18 22:57:10 2000 +++ annotate.1.2.texi.new Sat Mar 25 15:05:26 2000 @@ -58,7 +58,7 @@ @node Annotations @chapter @value{GDBN} Annotations -This chapter describes annotations in @value{GDBN}, the GNU symbolic debugger. +This chapter describes annotations in @value{GDBN}, the @sc{gnu} symbolic debugger. Annotations are designed to interface @value{GDBN} to graphical user interfaces or other similar programs which want to interact with @value{GDBN} at a relatively high level. @@ -398,7 +398,7 @@ Then, if source is to actually be displayed for this frame (for example, this is not true for output from the @code{backtrace} command), then a -@code{source} annotation (@pxref{Source}) is displayed. Unlike most +@code{source} annotation (@pxref{Source Annotations}) is displayed. Unlike most annotations, this is output instead of the normal text which would be output, not in addition. @end itemize >From cgf@cygnus.com Sat Mar 25 16:30:00 2000 From: Chris Faylor To: Andrew Cagney Cc: GDB Patches Subject: Re: [PATCH} maint.c remove quoted trailing space Date: Sat, 25 Mar 2000 16:30:00 -0000 Message-id: <20000325193022.H802@cygnus.com> References: <38DC70E4.C2ECB4E9@cygnus.com> X-SW-Source: 2000-03/msg00592.html Content-length: 279 On Sat, Mar 25, 2000 at 06:55:16PM +1100, Andrew Cagney wrote: >I've applied the following. As an aside, we can start using: > > "a string that" > "extends over several lines" But this only works in ISO C! Oh. Wait. Never mind. I always forget that you can do this... cgf >From eliz@gnu.org Sat Mar 25 18:42:00 2000 From: Eli Zaretskii To: ac131313@cygnus.com Cc: meissner@cygnus.com, gdb-patches@sourceware.cygnus.com Subject: Re: -Wall -Wno-unused-param Date: Sat, 25 Mar 2000 18:42:00 -0000 Message-id: <200003260242.VAA20607@mescaline.gnu.org> References: <38D9A096.E4FFC223@cygnus.com> <20000323132841.28903@cse.cygnus.com> <38DAC122.D2155F0A@cygnus.com> X-SW-Source: 2000-03/msg00593.html Content-length: 502 With regard to ATTRIBUTE_UNUSED, GDB is sitting at a cross road where people could either go through and add that everywhere or just require people to use a state-of-the-art compiler to check for warnings. I like the latter, its easier overall :-) For reasons I'd pefer not to go into here, I (still) don't trust GCC 2.95.x enough to rely on the latest version of the compiler. I've already changed go32-nat.c and ser-go32.c to use ATTRIBUTE_UNUSED so as to shut up the compiler. YMMV. >From eliz@gnu.org Sat Mar 25 20:43:00 2000 From: Eli Zaretskii To: ac131313@cygnus.com Cc: shebs@apple.com, gdb-patches@sourceware.cygnus.com Subject: Re: [PATCH] Fix texinfo problems... Date: Sat, 25 Mar 2000 20:43:00 -0000 Message-id: <200003260443.XAA26499@mescaline.gnu.org> References: <38DB1875.4B504618@cygnus.com> <38DBB937.126C95E@apple.com> <38DC6763.563424A2@cygnus.com> X-SW-Source: 2000-03/msg00594.html Content-length: 1105 > *Please* don't add the node links back!! I went to some trouble to get > rid of them all, because they make for an utter nightmare when you're > trying to add new material. They're only useful if you want to link > nodes in some fashion other than that implied by the chapter/section > structure, and as of yet I haven't heard anyone come up with a good > rationale for linking in any other way. > > The replication of the TOC node with ifinfo and ifhtml is sufficient > to make the manual generate correctly with three versions of texinfo, > so I'm mystified as to why you think these other changes are necessary... I'm sorry, but please _don't_ delete them until I've cut this 5.0 branch :-) Without top level node entries I found that makeinfo 3.12 I was using failed. I tested with Texinfo 3.12 the patches that only duplicated the Top node and the menu, and they worked for me. Perhaps you could post the error messages you get with those patches, and we could then find out how to solve that. (Are you sure you used Texinfo 3.12 without any patches?) >From eliz@gnu.org Sat Mar 25 21:16:00 2000 From: Eli Zaretskii To: shebs@apple.com Cc: msnyder@cygnus.com, jtc@redback.com, gdb-patches@sourceware.cygnus.com Subject: Re: gdb.texinfo broken? Date: Sat, 25 Mar 2000 21:16:00 -0000 Message-id: <200003260516.AAA27674@mescaline.gnu.org> References: <38D6CF69.6844@cygnus.com> <200003211819.NAA12435@indy.delorie.com> <200003221655.LAA14175@indy.delorie.com> <38DA7A75.2E59FB7B@apple.com> X-SW-Source: 2000-03/msg00595.html Content-length: 505 To make this even more entertaining, there are patched versions of 3.12; so for instance my RH 6.1 machine comes with a patched texinfo 3.12f (or 3.12h?, it's not in front of me) where this bug is fixed. Ys, this was corrected in 3.12d, I think. Eli, could you commit this patch please? Thanks... I'm currently on the road with no access to the machine where I have the ssh setup. So either please until March 30, or someone else could install the change. Sorry about the inconvenience. >From dima@Chg.RU Sun Mar 26 10:19:00 2000 From: Dmitry Sivachenko To: gdb-patches@sourceware.cygnus.com Subject: gdb.texinfo: cosmetique Date: Sun, 26 Mar 2000 10:19:00 -0000 Message-id: <200003261819.WAA40439@netserv1.chg.ru> X-SW-Source: 2000-03/msg00596.html Content-length: 13698 --- gdb.1.4.texinfo Wed Mar 22 22:55:21 2000 +++ gdb.1.4.texinfo.new Sun Mar 26 19:43:23 2000 @@ -1195,7 +1195,7 @@ command. If you just want to see the list of alternatives in the first place, you -can press @kbd{M-?} rather than pressing @key{TAB} twice. @kbd{M-?} +can press @kbd{M-?} rather than pressing @key{TAB} twice. @kbd{M-?} means @kbd{@key{META} ?}. You can type this either by holding down a key designated as the @key{META} shift on your keyboard (if there is one) while typing @kbd{?}, or as @key{ESC} followed by @kbd{?}. @@ -1277,7 +1277,7 @@ stack -- Examining the stack status -- Status inquiries support -- Support facilities -tracepoints -- Tracing of program execution without@* +tracepoints -- Tracing of program execution without stopping the program user-defined -- User-defined commands @@ -2860,7 +2860,7 @@ Break conditions can have side effects, and may even call functions in your program. This can be useful, for example, to activate functions that log program progress, or to use your own print functions to -format special data structures. The effects are completely predictable +format special data structures. The effects are completely predictable unless there is another enabled breakpoint at the same address. (In that case, @value{GDBN} might see the other breakpoint first and stop your program without checking the condition of this one.) Note that @@ -3537,7 +3537,7 @@ particular, whenever you ask @value{GDBN} for the value of a variable in your program, the value is found in the selected frame. There are special @value{GDBN} commands to select whichever frame you are -interested in. @xref{Selection, ,Selecting a frame}. +interested in. @xref{Selection, ,Selecting a frame}. When your program stops, @value{GDBN} automatically selects the currently executing frame and describes it briefly, similar to the @@ -6418,7 +6418,7 @@ precedence as @code{*}. @item - -Negative. Defined on @code{INTEGER} and @code{REAL} data. +Negative. Defined on @code{INTEGER} and @code{REAL} data. @item ^ Pointer dereferencing. Defined on pointer types. @@ -6771,7 +6771,7 @@ The Chill Datatype- (Mode) support of @value{GDBN} is directly related with the functionality of the @sc{gnu} Chill compiler, and therefore deviates -slightly from the standard specification of the Chill language. The +slightly from the standard specification of the Chill language. The provided modes are: @c FIXME: this @table's contents effectively disable @code by using @r @@ -6819,9 +6819,9 @@ @item @r{@emph{Procedure mode}} The procedure mode is displayed by @code{type = PROC() - EXCEPTIONS ()}. The @code{ EXCEPTIONS ()}. The @code{} is a list of the parameter modes. @code{} indicates -the mode of the result of the procedure if any. The exceptionlist lists +the mode of the result of the procedure if any. The @code{} lists all possible exceptions which can be raised by the procedure. @ignore @@ -6877,7 +6877,7 @@ list>)}. The @code{} consists of names and modes of fields of the structure. Variant structures have the keyword @code{CASE OF ESAC} in their field list. Since the current version -of the GNU Chill compiler doesn't implement tag processing (no runtime +of the @sc{gnu} Chill compiler doesn't implement tag processing (no runtime checks of variant fields, and therefore no debugging info), the output always displays all variant fields. @smallexample @@ -6951,7 +6951,7 @@ braces (@samp{@{@}}). Fields enclosed by @samp{@{,@}} are residing on the same memory location and represent the current values of the memory location in their specific modes. Since no tag processing is done -all variants are displayed. A variant field is printed by +all variants are displayed. A variant field is printed by @code{() = .: }. (who implements the stuff ???) @smallexample @@ -7067,7 +7067,7 @@ An array slice is specified by @code{()}, where @code{} can be either a range specified by expressions or by @code{ up }. @code{} denotes the number of -arrayelements the slice contains. The delivered value is an array value +array elements the slice contains. The delivered value is an array value which is part of the specified array. @item Structure Field Values @@ -7117,7 +7117,7 @@ @item @code{SQRT()} @end table -For a detailed description refer to the GNU Chill implementation manual +For a detailed description refer to the @sc{gnu} Chill implementation manual chapter 1.6. @end ignore @@ -8250,7 +8250,7 @@ @item target remote @var{dev} Remote serial target in GDB-specific protocol. The argument @var{dev} specifies what serial device to use for the connection (e.g. -@file{/dev/ttya}). @xref{Remote, ,Remote debugging}. @code{target remote} +@file{/dev/ttya}). @xref{Remote, ,Remote debugging}. @code{target remote} supports the @code{load} command. This is only useful if you have some other way of getting the stub to the target system, and you can put it somewhere in memory where it won't get clobbered by the download. @@ -8611,7 +8611,7 @@ either obtain it from your hardware manufacturer, or write your own. @end table -If you do not use the GNU C compiler, you may need other standard +If you do not use the @sc{gnu} C compiler, you may need other standard library subroutines as well; this varies from one stub to another, but in general the stubs are likely to use any of the common library subroutines which @code{@value{GCC}} generates as inline code. @@ -8652,7 +8652,7 @@ @noindent but if before calling @code{set_debug_traps}, you set it to point to a function in your program; that function is called when -@code{@value{GDBN}} continues after stopping on a trap (for example, bus +@value{GDBN} continues after stopping on a trap (for example, bus error). The function indicated by @code{exceptionHook} is called with one parameter: an @code{int} which is the exception number. @@ -8802,7 +8802,7 @@ @var{packet-data} consists of a sequence of characters with the exception of @samp{#} and @samp{$} (see @samp{X} packet for an -exception). @samp{:} can not appear as the third character in a packet. +exception). @samp{:} can not appear as the third character in a packet. Fields within the packet should be separated using @samp{,} and @samp{;} (unfortunately some packets chose to use @samp{:}). Except where otherwise noted all numbers are represented in HEX with leading zeros @@ -8872,7 +8872,7 @@ @item set program arguments @strong{(reserved)} @emph{(optional)} @tab @code{A}@var{arglen}@code{,}@var{argnum}@code{,}@var{arg}@code{,...} @tab -Initialized @samp{argv[]} array passed into program. @var{arglen} +Initialized @samp{argv[]} array passed into program. @var{arglen} specifies the number of bytes in the hex encoded byte stream @var{arg}. See @file{gdbserver} for more details. @item @@ -8883,15 +8883,16 @@ @item set baud @strong{(deprecated)} @tab @code{b}@var{baud} @tab -Change the serial line speed to @var{baud}. JTC: @emph{When does the -transport layer state change? When it's received, or after the ACK is -transmitted. In either case, there are problems if the command or the -acknowledgment packet is dropped.} Stan: @emph{If people really wanted -to add something like this, and get it working for the first time, they -ought to modify ser-unix.c to send some kind of out-of-band message to a -specially-setup stub and have the switch happen "in between" packets, so -that from remote protocol's point of view, nothing actually -happened.} +Change the serial line speed to @var{baud}. +@c JTC: @emph{When does the +@c transport layer state change? When it's received, or after the ACK is +@c transmitted. In either case, there are problems if the command or the +@c acknowledgment packet is dropped.} Stan: @emph{If people really wanted +@c to add something like this, and get it working for the first time, they +@c ought to modify ser-unix.c to send some kind of out-of-band message to a +@c specially-setup stub and have the switch happen "in between" packets, so +@c that from remote protocol's point of view, nothing actually +@c happened.} @item set breakpoint @strong{(deprecated)} @tab @code{B}@var{addr},@var{mode} @@ -8903,7 +8904,7 @@ @item continue @tab @code{c}@var{addr} @tab -@var{addr} is address to resume. If @var{addr} is omitted, resume at +@var{addr} is address to resume. If @var{addr} is omitted, resume at current address. @item @tab reply @@ -9048,14 +9049,14 @@ @tab Read @var{length} bytes of memory starting at address @var{addr}. Neither @value{GDBN} nor the stub assume that sized memory transfers are assumed -using word alligned accesses. FIXME: @emph{A word aligned memory +using word alligned accesses. FIXME: @emph{A word aligned memory transfer mechanism is needed.} @item @tab reply @var{XX...} @tab -@var{XX...} is mem contents. Can be fewer bytes than requested if able +@var{XX...} is mem contents. Can be fewer bytes than requested if able to read only part of the data. Neither @value{GDBN} nor the stub assume that -sized memory transfers are assumed using word alligned accesses. FIXME: +sized memory transfers are assumed using word alligned accesses. FIXME: @emph{A word aligned memory transfer mechanism is needed.} @item @tab reply @code{E}@var{NN} @@ -9605,7 +9606,7 @@ the baud rate used by the connection. @var{port} and @var{node} default to 0, @var{baud} defaults to 9600@dmn{bps}. -For example, to debug Emacs with the argument @samp{foo.txt}and +For example, to debug Emacs with the argument @samp{foo.txt} and communicate with @value{GDBN} over serial port number 2 or board 1 using a 19200@dmn{bps} connection: @@ -9618,7 +9619,7 @@ symbols and debugging information. Start up @value{GDBN} as usual, using the name of the local copy of your program as the first argument. (You may also need the @w{@samp{--baud}} option if the serial line is -running at anything other than 9600@dmn{bps}. After that, use @code{target +running at anything other than 9600@dmn{bps}.) After that, use @code{target remote} to establish communications with @code{gdbserve.nlm}. Its argument is a device name (usually a serial device, like @file{/dev/ttyb}). For example: @@ -9796,7 +9797,7 @@ @item VxWorks-timeout @var{args} @kindex vxworks-timeout All VxWorks-based targets now support the option @code{vxworks-timeout}. -This option is set by the user, and @var{args} represents the number of +This option is set by the user, and @var{args} represents the number of seconds @value{GDBN} waits for responses to rpc's. You might use this if your VxWorks target is a slow software simulator or is on the far side of a thin network line. @@ -10279,14 +10280,14 @@ @c only for Unix hosts @kindex device @cindex serial device, Hitachi micros -Use the special @code{@value{GDBN}} command @samp{device @var{port}} if you +Use the special @value{GDBN} command @samp{device @var{port}} if you need to explicitly set the serial device. The default @var{port} is the first available port on your host. This is only necessary on Unix hosts, where it is typically something like @file{/dev/ttya}. @kindex speed @cindex serial line speed, Hitachi micros -@code{@value{GDBN}} has another special command to set the communications +@value{GDBN} has another special command to set the communications speed: @samp{speed @var{bps}}. This command also is only used from Unix hosts; on DOS hosts, set the line speed as usual from outside @value{GDBN} with the DOS @code{mode} command (for instance, @@ -10333,7 +10334,7 @@ @kindex target hms@r{, and serial protocol} Now that serial communications are set up, and the development board is connected, you can start up @value{GDBN}. Call @code{@value{GDBP}} with -the name of your program as the argument. @code{@value{GDBN}} prompts +the name of your program as the argument. @value{GDBN} prompts you, as usual, with the prompt @samp{(@value{GDBP})}. Use two special commands to begin your debugging session: @samp{target hms} to specify cross-debugging to the Hitachi board, and the @code{load} command to @@ -10581,7 +10582,7 @@ @subsection M68k The Motorola m68k configuration includes ColdFire support, and -target command for the following ROM monitors. +@code{target} command for the following ROM monitors. @table @code @@ -10618,7 +10619,7 @@ @end table -[context?] +@c [context?] @table @code @@ -10700,7 +10701,6 @@ @end table - @noindent @value{GDBN} also supports these special commands for MIPS targets: @@ -10857,7 +10857,7 @@ @item timeout @var{args} @kindex remotetimeout @value{GDBN} supports the option @code{remotetimeout}. -This option is set by the user, and @var{args} represents the number of +This option is set by the user, and @var{args} represents the number of seconds @value{GDBN} waits for responses. @end table @@ -11304,7 +11304,7 @@ @end ifset Since @kbd{!} is also the logical not operator in C, history expansion -is off by default. If you decide to enable history expansion with the +is off by default. If you decide to enable history expansion with the @code{set history expansion on} command, you may sometimes need to follow @kbd{!} (when it is used as logical not, in an expression) with a space or a tab to prevent it from being expanded. The readline >From jtc@redback.com Sun Mar 26 11:27:00 2000 From: jtc@redback.com (J.T. Conklin) To: gdb-patches@sourceware.cygnus.com Subject: RFA: i386nbsd-nat.c, m68knbsd-nat.c: core dump support Date: Sun, 26 Mar 2000 11:27:00 -0000 Message-id: <5mg0tdpm5s.fsf@jtc.redbacknetworks.com> X-SW-Source: 2000-03/msg00597.html Content-length: 2709 I submit the enclosed patch for approval. The change to i386nbsd-nat.c makes the fetch_core_registers function static, as there is no need for it to be global. The same is done for m68knbsd-nat.c, but it also adds the missing glue which enables core dump reading. --jtc 2000-03-26 J.T. Conklin * i386nbsd-nat.c (fetch_core_registers): Make static. * m68knbsd-nat.c (fetch_core_registers): Make static. (m68knbsd_core_fns, _initialize_m68knbsd_nat): Added. Index: i386nbsd-nat.c =================================================================== RCS file: /cvs/src/src/gdb/i386nbsd-nat.c,v retrieving revision 1.2 diff -c -3 -p -r1.2 i386nbsd-nat.c *** i386nbsd-nat.c 2000/03/24 23:06:57 1.2 --- i386nbsd-nat.c 2000/03/26 19:06:54 *************** struct md_core *** 164,170 **** struct env387 freg; }; ! void fetch_core_registers (core_reg_sect, core_reg_size, which, ignore) char *core_reg_sect; unsigned core_reg_size; --- 164,170 ---- struct env387 freg; }; ! static void fetch_core_registers (core_reg_sect, core_reg_size, which, ignore) char *core_reg_sect; unsigned core_reg_size; Index: m68knbsd-nat.c =================================================================== RCS file: /cvs/src/src/gdb/m68knbsd-nat.c,v retrieving revision 1.1.1.2 diff -c -3 -p -r1.1.1.2 m68knbsd-nat.c *** m68knbsd-nat.c 1999/07/07 20:07:51 1.1.1.2 --- m68knbsd-nat.c 2000/03/26 19:06:54 *************** struct md_core *** 70,76 **** struct fpreg freg; }; ! void fetch_core_registers (core_reg_sect, core_reg_size, which, ignore) char *core_reg_sect; unsigned core_reg_size; --- 70,76 ---- struct fpreg freg; }; ! static void fetch_core_registers (core_reg_sect, core_reg_size, which, ignore) char *core_reg_sect; unsigned core_reg_size; *************** fetch_core_registers (core_reg_sect, cor *** 85,88 **** --- 85,106 ---- /* Floating point registers */ memcpy (®isters[REGISTER_BYTE (FP0_REGNUM)], &core_reg->freg, sizeof (struct fpreg)); + } + + /* Register that we are able to handle m68knbsd core file formats. + FIXME: is this really bfd_target_unknown_flavour? */ + + static struct core_fns m68knbsd_core_fns = + { + bfd_target_unknown_flavour, /* core_flavour */ + default_check_format, /* check_format */ + default_core_sniffer, /* core_sniffer */ + fetch_core_registers, /* core_read_registers */ + NULL /* next */ + }; + + void + _initialize_m68knbsd_nat () + { + add_core_fns (&m68knbsd_core_fns); } -- J.T. Conklin RedBack Networks >From kettenis@wins.uva.nl Sun Mar 26 14:26:00 2000 From: Mark Kettenis To: gdb-patches@sourceware.cygnus.com Cc: eliz@is.elta.co.il Subject: [PATCH] Provide `long double' support for most i386 targets Date: Sun, 26 Mar 2000 14:26:00 -0000 Message-id: <200003262226.e2QMQQu07762@delius.kettenis.local> X-SW-Source: 2000-03/msg00598.html Content-length: 12946 Hi, I just checked in the changes I discussed a few weeks ago that should make `long double' support available in most i386 targets. It gets rid of most of the Linux-specific cruft. The various i386 maintainers may want to put a #define HOST_LONG_DOUBLE_FORMAT &floatformat_i387_ext in their host file. This will optimize things a bit. I'll take care of Linux and the Hurd. Eli may want to remove the REGISTER_CONVERT_TO_VIRTUAL, REGISTER_CONVERT_TO_RAW and TARGET_LONG_DOUBLE_BIT stuff from tm-go32.h. The LD_I387 definition can probably also be removed. Its only purpose would be the HEX_LONG_DOUBLE_INPUT macro, but that macro is never used in the GDB sources. By the way Eli, the I386_DJGPP_TARGET macro is redundant too now I've changed i386_extract_return_value(). Mark 2000-03-27 Mark Kettenis * config/i386/tm-i386.h: Fix typo. It is TARGET_LONG_DOUBLE_BIT instead of TARGET_LONG_DOUBLE_BITS. * config/i386/tm-i386mk.h: Likewise. 2000-03-26 Mark Kettenis Provide `long double' support for most i386 targets. * config/i386/tm-i386.h (TARGET_LONG_DOUBLE_FORMAT): Define as &floatformat_i387_ext. (TARGET_LONG_DOUBLE_BITS): Define as 96. (REGISTER_VIRTUAL_TYPE): Change type for FPU registers to `builtin_type_long_double'. (REGISTER_CONVERT_TO_VIRTUAL): Call i386_register_convert_to_virtual. (REGISTER_CONVERT_TO_RAW): Call i386_register_convert_to_raw. (i387_to_double, double_to_i387): Remove prototypes. (i386_extract_return_value): Change prototype to match definition in i386-tdep.c. * config/i386/tm-i386mk.h (TARGET_LONG_DOUBLE_FORMAT): #undef. (TARGET_LONG_DOUBLE_BITS): #undef. * config/i386/tm-linux.h (TARGET_LONG_DOUBLE_BIT): Remove. [HAVE_LONG_DOUBLE && HOST_I386] (LD_I387): Remove. (i387_extract_floating, i387_store_floating): Remove prototypes. (TARGET_EXTRACT_FLOATING, TARGET_STORE_FLOATING): Remove. (REGISTER_CONVERT_TO_VIRTUAL, REGOISTER_CONVERT_TO_RAW): Remove. (REGISTER_VIRTUAL_TYPE): Remove. * i386-tdep.c (i386_register_convert_to_virtual): New function. (i386_register_convert_to_raw): New function. * i387-tdep.c [LD_I387] (i387_extract_floating): Remove. (i387_store_floating): Remove. Index: i386-tdep.c =================================================================== RCS file: /cvs/src/src/gdb/i386-tdep.c,v retrieving revision 1.8 retrieving revision 1.9 diff -u -p -r1.8 -r1.9 --- i386-tdep.c 2000/03/22 09:45:01 1.8 +++ i386-tdep.c 2000/03/26 21:21:50 1.9 @@ -761,6 +761,32 @@ i386_extract_return_value (struct type * } } +/* Convert data from raw format for register REGNUM in buffer FROM to + virtual format with type TYPE in buffer TO. In principle both + formats are identical except that the virtual format has two extra + bytes appended that aren't used. We set these to zero. */ + +void +i386_register_convert_to_virtual (int regnum, struct type *type, + char *from, char *to) +{ + /* Copy straight over, but take care of the padding. */ + memcpy (to, from, FPU_REG_RAW_SIZE); + memset (to + FPU_REG_RAW_SIZE, 0, TYPE_LENGTH (type) - FPU_REG_RAW_SIZE); +} + +/* Convert data from virtual format with type TYPE in buffer FROM to + raw format for register REGNUM in buffer TO. Simply omit the two + unused bytes. */ + +void +i386_register_convert_to_raw (struct type *type, int regnum, + char *from, char *to) +{ + memcpy (to, from, FPU_REG_RAW_SIZE); +} + + #ifdef I386V4_SIGTRAMP_SAVED_PC /* Get saved user PC for sigtramp from the pushed ucontext on the stack for all three variants of SVR4 sigtramps. */ Index: i387-tdep.c =================================================================== RCS file: /cvs/src/src/gdb/i387-tdep.c,v retrieving revision 1.1.1.6 retrieving revision 1.2 diff -u -p -r1.1.1.6 -r1.2 --- i387-tdep.c 1999/12/08 02:50:38 1.1.1.6 +++ i387-tdep.c 2000/03/26 21:21:50 1.2 @@ -1,5 +1,5 @@ /* Intel 387 floating point stuff. - Copyright (C) 1988, 1989, 1991, 1998, 1999 Free Software Foundation, Inc. + Copyright (C) 1988, 89, 91, 98, 99, 2000 Free Software Foundation, Inc. This file is part of GDB. @@ -387,51 +387,3 @@ i387_float_info (void) printf_filtered ("Opcode: %s\n", local_hex_string_custom (fop ? (fop | 0xd800) : 0, "04")); } - - -/* FIXME: The functions on this page are used to provide `long double' - support for Linux. However, the approach does not seem to be the - right one, and we are planning to solve this in a way that should - work for all i386 targets. These functions will disappear in the - near future, so please don't use them. */ -#ifdef LD_I387 -int -i387_extract_floating (PTR addr, int len, DOUBLEST *dretptr) -{ - if (len == TARGET_LONG_DOUBLE_BIT / 8) - { - if (HOST_LONG_DOUBLE_FORMAT == TARGET_LONG_DOUBLE_FORMAT) - { - DOUBLEST retval; - - memcpy (dretptr, addr, sizeof (retval)); - } - else - floatformat_to_doublest (TARGET_LONG_DOUBLE_FORMAT, addr, dretptr); - - return 1; - } - else - return 0; -} - -int -i387_store_floating (PTR addr, int len, DOUBLEST val) -{ - if (len == TARGET_LONG_DOUBLE_BIT / 8) - { - /* This `if' may be totally stupid. I just put it in here to be - absolutely sure I'm preserving the semantics of the code I'm - frobbing, while I try to maintain portability boundaries; I - don't actually know exactly what it's doing. -JimB, May 1999 */ - if (HOST_LONG_DOUBLE_FORMAT == TARGET_LONG_DOUBLE_FORMAT) - memcpy (addr, &val, sizeof (val)); - else - floatformat_from_doublest (TARGET_LONG_DOUBLE_FORMAT, &val, addr); - - return 1; - } - else - return 0; -} -#endif /* LD_I387 */ Index: config/i386/tm-i386.h =================================================================== RCS file: /cvs/src/src/gdb/config/i386/tm-i386.h,v retrieving revision 1.2 diff -u -p -r1.2 tm-i386.h --- config/i386/tm-i386.h 2000/02/29 13:28:24 1.2 +++ config/i386/tm-i386.h 2000/03/26 22:08:41 @@ -1,5 +1,5 @@ /* Macro definitions for GDB on an Intel i[345]86. - Copyright (C) 1995, 1996 Free Software Foundation, Inc. + Copyright (C) 1995, 1996, 2000 Free Software Foundation, Inc. This file is part of GDB. @@ -28,6 +28,19 @@ struct type; #define TARGET_BYTE_ORDER LITTLE_ENDIAN +/* The format used for `long double' on almost all i386 targets is the + i387 extended floating-point format. In fact, of all targets in the + GCC 2.95 tree, only OSF/1 does it different, and insists on having + a `long double' that's not `long' at all. */ + +#define TARGET_LONG_DOUBLE_FORMAT &floatformat_i387_ext + +/* Although the i386 extended floating-point has only 80 significant + bits, a `long double' actually takes up 96, probably to enforce + alignment. */ + +#define TARGET_LONG_DOUBLE_BIT 96 + /* Used for example in valprint.c:print_floating() to enable checking for NaN's */ @@ -229,7 +242,7 @@ extern int i386_register_virtual_size[]; #define REGISTER_VIRTUAL_TYPE(N) \ (((N) == PC_REGNUM || (N) == FP_REGNUM || (N) == SP_REGNUM) \ ? lookup_pointer_type (builtin_type_void) \ - : IS_FP_REGNUM(N) ? builtin_type_double \ + : IS_FP_REGNUM(N) ? builtin_type_long_double \ : IS_SSE_REGNUM(N) ? builtin_type_v4sf \ : builtin_type_int) @@ -240,25 +253,22 @@ extern int i386_register_virtual_size[]; counterexample, this is still sloppy. */ #define REGISTER_CONVERTIBLE(n) (IS_FP_REGNUM (n)) -/* Convert data from raw format for register REGNUM in buffer FROM - to virtual format with type TYPE in buffer TO. */ -extern void i387_to_double (char *, char *); - -#define REGISTER_CONVERT_TO_VIRTUAL(REGNUM,TYPE,FROM,TO) \ -{ \ - double val; \ - i387_to_double ((FROM), (char *)&val); \ - store_floating ((TO), TYPE_LENGTH (TYPE), val); \ -} - -extern void double_to_i387 (char *, char *); - -#define REGISTER_CONVERT_TO_RAW(TYPE,REGNUM,FROM,TO) \ -{ \ - double val = extract_floating ((FROM), TYPE_LENGTH (TYPE)); \ - double_to_i387((char *)&val, (TO)); \ -} +/* Convert data from raw format for register REGNUM in buffer FROM to + virtual format with type TYPE in buffer TO. */ +#define REGISTER_CONVERT_TO_VIRTUAL(regnum, type, from, to) \ + i386_register_convert_to_virtual ((regnum), (type), (from), (to)); +extern void i386_register_convert_to_virtual (int regnum, struct type *type, + char *from, char *to); + +/* Convert data from virtual format with type TYPE in buffer FROM to + raw format for register REGNUM in buffer TO. */ + +#define REGISTER_CONVERT_TO_RAW(type, regnum, from, to) \ + i386_register_convert_to_raw ((type), (regnum), (from), (to)); +extern void i386_register_convert_to_raw (struct type *type, int regnum, + char *from, char *to); + /* Print out the i387 floating point state. */ #ifdef HAVE_I387_REGS extern void i387_float_info (void); @@ -278,11 +288,11 @@ extern void i387_float_info (void); /* Extract from an array REGBUF containing the (raw) register state a function return value of type TYPE, and copy that, in virtual format, into VALBUF. */ - -#define EXTRACT_RETURN_VALUE(TYPE,REGBUF,VALBUF) \ - i386_extract_return_value ((TYPE),(REGBUF),(VALBUF)) -extern void i386_extract_return_value PARAMS ((struct type *, char[], char *)); +#define EXTRACT_RETURN_VALUE(type, regbuf, valbuf) \ + i386_extract_return_value ((type), (regbuf), (valbuf)) +extern void i386_extract_return_value (struct type *type, char *regbuf, + char *valbuf); /* Write into appropriate registers a function return value of type TYPE, given in virtual format. */ Index: config/i386/tm-i386mk.h =================================================================== RCS file: /cvs/src/src/gdb/config/i386/tm-i386mk.h,v retrieving revision 1.1.1.2 diff -u -p -r1.1.1.2 tm-i386mk.h --- config/i386/tm-i386mk.h 1999/07/07 20:13:09 1.1.1.2 +++ config/i386/tm-i386mk.h 2000/03/26 22:08:41 @@ -1,5 +1,5 @@ /* Macro definitions for i386, Mach 3.0, OSF 1/MK - Copyright (C) 1992 Free Software Foundation, Inc. + Copyright (C) 1992, 2000 Free Software Foundation, Inc. This file is part of GDB. @@ -24,3 +24,15 @@ #define MK67 1 #include "i386/tm-i386m3.h" + +/* FIMXE: kettenis/2000-03-26: On OSF 1, `long double' is equivalent + to `double'. However, I'm not sure what is the consequence of: + + #define TARGET_LONG_DOUBLE_FORMAT TARGET_DOUBLE_FORMAT + #define TARGET_LONG_DOUBLE_BIT TARGET_DOUBLE_BIT + + So I'll go with the current status quo instead. It looks like this + target won't compile anyway. Perhaps it should be obsoleted? */ + +#undef TARGET_LONG_DOUBLE_FORMAT +#undef TARGET_LONG_DOUBLE_BIT Index: config/i386/tm-linux.h =================================================================== RCS file: /cvs/src/src/gdb/config/i386/tm-linux.h,v retrieving revision 1.5 diff -u -p -r1.5 tm-linux.h --- config/i386/tm-linux.h 2000/03/22 09:45:01 1.5 +++ config/i386/tm-linux.h 2000/03/26 22:08:41 @@ -30,21 +30,16 @@ #include "i386/tm-i386.h" #include "tm-linux.h" -/* This should probably move to tm-i386.h. */ -#define TARGET_LONG_DOUBLE_BIT 80 +/* FIXME: kettenis/2000-03-26: We should get rid of this last piece of + Linux-specific `long double'-support code, probably by adding code + to valprint.c:print_floating() to recognize various extended + floating-point formats. */ #if defined(HAVE_LONG_DOUBLE) && defined(HOST_I386) /* The host and target are i386 machines and the compiler supports long doubles. Long doubles on the host therefore have the same layout as a 387 FPU stack register. */ -#define LD_I387 -extern int i387_extract_floating (PTR addr, int len, long double *dretptr); -extern int i387_store_floating (PTR addr, int len, long double val); - -#define TARGET_EXTRACT_FLOATING i387_extract_floating -#define TARGET_STORE_FLOATING i387_store_floating - #define TARGET_ANALYZE_FLOATING \ do \ { \ @@ -60,30 +55,6 @@ extern int i387_store_floating (PTR ad && (((high & 0x7fffffff) | low) != 0); \ } \ while (0) - -#undef REGISTER_CONVERT_TO_VIRTUAL -#define REGISTER_CONVERT_TO_VIRTUAL(REGNUM,TYPE,FROM,TO) \ -{ \ - long double val = *((long double *)FROM); \ - store_floating ((TO), TYPE_LENGTH (TYPE), val); \ -} - -#undef REGISTER_CONVERT_TO_RAW -#define REGISTER_CONVERT_TO_RAW(TYPE,REGNUM,FROM,TO) \ -{ \ - long double val = extract_floating ((FROM), TYPE_LENGTH (TYPE)); \ - *((long double *)TO) = val; \ -} - -/* Return the GDB type object for the "standard" data type - of data in register N. */ -#undef REGISTER_VIRTUAL_TYPE -#define REGISTER_VIRTUAL_TYPE(N) \ - (((N) == PC_REGNUM || (N) == FP_REGNUM || (N) == SP_REGNUM) \ - ? lookup_pointer_type (builtin_type_void) \ - : IS_FP_REGNUM(N) ? builtin_type_long_double \ - : IS_SSE_REGNUM(N) ? builtin_type_v4sf \ - : builtin_type_int) #endif >From sbjohnson@ozemail.com.au Sun Mar 26 14:33:00 2000 From: Steven Johnson To: Andrew Cagney , GDB Patches Subject: Re: RFA: Deprecate remote protocol sequence-ID Date: Sun, 26 Mar 2000 14:33:00 -0000 Message-id: <38DE8CA2.A5A862D6@ozemail.com.au> References: <38DAF122.3CA0E862@cygnus.com> <38DB0EE5.831CD611@ozemail.com.au> <38DB24AB.7881FFA1@cygnus.com> <5mhfdwvxcu.fsf@jtc.redbacknetworks.com> <38DC645E.A6CCB479@cygnus.com> X-SW-Source: 2000-03/msg00599.html Content-length: 683 Andrew Cagney wrote: > > "J.T. Conklin" wrote: > > > > >>>>> "Andrew" == Andrew Cagney writes: > > Andrew> I think a simple reliable separate transport layer is needed. I'd even > > Andrew> go as far as a new packet wrapper (replacing $...#NN and +-). > > > > Here, here! > > > I have a another theory. If we: > > o deprecate ``:'' sequence IDs > > o introduce a transport > protocol that works > > o ban the transport of new/improved > packets using the old/broken > transport protocol. > > then there aren't any problems. > > Andrew Its got my vote. >From ac131313@cygnus.com Sun Mar 26 15:30:00 2000 From: Andrew Cagney To: GDB Patches Subject: [MAINT] J.T. NetBSD maintainer Date: Sun, 26 Mar 2000 15:30:00 -0000 Message-id: <38DE9D40.D6CD27B4@cygnus.com> X-SW-Source: 2000-03/msg00600.html Content-length: 100 FYI, I've put J.T. down as the NetBSD maintainer. NetBSD J.T. Conklin jtc@redback.com Andrew >From sbjohnson@ozemail.com.au Sun Mar 26 15:46:00 2000 From: Steven Johnson To: GDB Patches Subject: Re: RFA: Deprecate remote protocol sequence-ID Date: Sun, 26 Mar 2000 15:46:00 -0000 Message-id: <38DE9C5F.84164575@ozemail.com.au> References: <38DAF122.3CA0E862@cygnus.com> <38DB0EE5.831CD611@ozemail.com.au> <38DB24AB.7881FFA1@cygnus.com> <5mhfdwvxcu.fsf@jtc.redbacknetworks.com> <38DC645E.A6CCB479@cygnus.com> <38DE8CA2.A5A862D6@ozemail.com.au> X-SW-Source: 2000-03/msg00601.html Content-length: 1437 Is it just me, or does there seem to be a fair amount of interest in creating a new and improved transport layer for the GDB Remote Protocol? If this happens, then might I make a few suggestions. 1. Don't Re-invent the wheel. There are quite a few good existing async transport layers that can be used as a basis. (Preferably one that can send binary data.) Async HDLC and DDCMP spring to mind. - Personally I prefer DDCMP to Async HDLC as it doesn't need to escape binary data, and so makes writing a stub easier. (But it has a fixed message overhead of 10 bytes). 2. We shouldn't get "anal" about a particular transport layer that the new one is based on and should be willing to make minor modifications to ease the desired goal. 3. Build in recoverability from the ground up. Don't make it optional. i.e., every message has a message number (in both directions). 4. Add Compression to the packet data (in both directions.) 5. I Think the function codes and packet data should remain the same as they are now. And yes, rule off the old protocol sand add advanced features to the new one. (Maybe only bring over some messages from the old protocol to the new one that are relevant anymore and drop all the deprecated ones.) This is all motherhood stuff, but I think it is important to start stating some of the obvious stuff so that it doesn't get ignored. Anything else Ive forgotten here? Steven. >From ac131313@cygnus.com Sun Mar 26 15:53:00 2000 From: Andrew Cagney To: Eli Zaretskii Cc: meissner@cygnus.com, gdb-patches@sourceware.cygnus.com Subject: Re: -Wall -Wno-unused-param Date: Sun, 26 Mar 2000 15:53:00 -0000 Message-id: <38DEA2A3.6E683025@cygnus.com> References: <38D9A096.E4FFC223@cygnus.com> <20000323132841.28903@cse.cygnus.com> <38DAC122.D2155F0A@cygnus.com> <200003260242.VAA20607@mescaline.gnu.org> X-SW-Source: 2000-03/msg00602.html Content-length: 724 Eli Zaretskii wrote: > > With regard to ATTRIBUTE_UNUSED, GDB is sitting at a cross road where > people could either go through and add that everywhere or just require > people to use a state-of-the-art compiler to check for warnings. I like > the latter, its easier overall :-) > > For reasons I'd pefer not to go into here, I (still) don't trust GCC > 2.95.x enough to rely on the latest version of the compiler. > > I've already changed go32-nat.c and ser-go32.c to use ATTRIBUTE_UNUSED > so as to shut up the compiler. YMMV. FYI, I've no intention of requiring people to use that compiler. I'll most likely set up a script that counts up compiler warnings and publishes the results. enjoy, Andrew >From ac131313@cygnus.com Sun Mar 26 16:26:00 2000 From: Andrew Cagney To: GDB Patches Subject: [MAINT] Adminstriva - update account needing folk Date: Sun, 26 Mar 2000 16:26:00 -0000 Message-id: <38DEAA55.1370E55B@cygnus.com> X-SW-Source: 2000-03/msg00603.html Content-length: 2679 Just FYI, Andrew Mon Mar 27 10:20:34 2000 Andrew Cagney * MAINTAINERS: Update folks who need accounts. Index: MAINTAINERS =================================================================== RCS file: /cvs/src/src/gdb/MAINTAINERS,v retrieving revision 1.26 diff -p -r1.26 MAINTAINERS *** MAINTAINERS 2000/03/26 23:54:53 1.26 --- MAINTAINERS 2000/03/27 00:22:40 *************** maintainers when resolving more generic *** 55,61 **** The host maintainer ensures that gdb (including mmalloc) can be built as a cross debugger on their platform. ! djgpp native *Eli Zaretskii eliz@gnu.org DJ Delorie dj@cygnus.com MS Windows (N.T., CE, '00) host & native Chris Faylor cgf@cygnus.com --- 55,61 ---- The host maintainer ensures that gdb (including mmalloc) can be built as a cross debugger on their platform. ! djgpp native Eli Zaretskii eliz@gnu.org DJ Delorie dj@cygnus.com MS Windows (N.T., CE, '00) host & native Chris Faylor cgf@cygnus.com *************** defs.h David Taylor taylor@cygnus.com *** 99,107 **** utils.c David Taylor taylor@cygnus.com Scheme support Jim Blandy jimb@cygnus.com svr4 shlibs (solib.c) Jim Blandy jimb@cygnus.com ! coff reader *Philippe De Muyter phdm@macqel.be remote.c Andrew Cagney cagney@cygnus.com ! *J.T. Conklin jtc@redback.com include/remote-sim.h, remote-sim.c Andrew Cagney cagney@cygnus.com sds protocol Fernando Nasser fnasser@cygnus.com --- 99,107 ---- utils.c David Taylor taylor@cygnus.com Scheme support Jim Blandy jimb@cygnus.com svr4 shlibs (solib.c) Jim Blandy jimb@cygnus.com ! coff reader Philippe De Muyter phdm@macqel.be remote.c Andrew Cagney cagney@cygnus.com ! J.T. Conklin jtc@redback.com include/remote-sim.h, remote-sim.c Andrew Cagney cagney@cygnus.com sds protocol Fernando Nasser fnasser@cygnus.com *************** readline/ Master version: ftp://ftp.cwr *** 148,154 **** Write After Approval - *J.T. Conklin jtc@redback.com Jim Kingdon kingdon@redhat.com Jason Molenda jsm@cygnus.com H.J. Lu hjl@lucon.org --- 148,153 ---- *************** Nick Clifton nickc@cygnus.com *** 156,162 **** Jonathan Larmour jlarmour@redhat.co.uk ! * Indicates folks we need to get Kerberos/ssh accounts ready so they can write in the source tree + Indicates folks that have been caught up in a paper trail. --- 155,161 ---- Jonathan Larmour jlarmour@redhat.co.uk ! * Indicates folks we need to get Kerberos/SSH accounts ready so they can write in the source tree + Indicates folks that have been caught up in a paper trail. >From ac131313@cygnus.com Sun Mar 26 20:39:00 2000 From: Andrew Cagney To: Steven Johnson Cc: GDB Patches Subject: Re: RFA: Deprecate remote protocol sequence-ID Date: Sun, 26 Mar 2000 20:39:00 -0000 Message-id: <38DEE5AA.7CC06C34@cygnus.com> References: <38DAF122.3CA0E862@cygnus.com> <38DB0EE5.831CD611@ozemail.com.au> <38DB24AB.7881FFA1@cygnus.com> <5mhfdwvxcu.fsf@jtc.redbacknetworks.com> <38DC645E.A6CCB479@cygnus.com> <38DE8CA2.A5A862D6@ozemail.com.au> <38DE9C5F.84164575@ozemail.com.au> X-SW-Source: 2000-03/msg00604.html Content-length: 1190 Steven Johnson wrote: > > Is it just me, or does there seem to be a fair amount of interest in > creating a new and improved transport layer for the GDB Remote Protocol? It's just you ;-) > If this happens, then might I make a few suggestions. Several broad proposals have been put forward: o do nothing, ignore the problem o fix the existing protocol spec and then slowly evolve it to something better. o start a-new keeping in mind the original protocols criteria (namely human ledgable, kiss, ...) o various shades of the above I've a backlog of doco+bug fix changes to the protocol (dropping ``:'' was just one of them) and I'll slowly trickle them out. For me personally, I'm kept in check by the very important need to move carefully and keep any remove changes upward compatible. There have also been several postings of revised protocols or priliminary proposals at totally new ones. Both more than welcome. Check the mail archives for previous discussions. > This is all motherhood stuff, but I think it is important to start > stating some of > the obvious stuff so that it doesn't get ignored. Anything else Ive > forgotten here? I don't know. Andrew >From ac131313@cygnus.com Sun Mar 26 21:25:00 2000 From: Andrew Cagney To: GDB Patches Subject: [MAINT/PATCH] ChangeLog et.al.: Revert whitespace changes Date: Sun, 26 Mar 2000 21:25:00 -0000 Message-id: <38DEF05E.9D2E79AC@cygnus.com> X-SW-Source: 2000-03/msg00605.html Content-length: 84590 FYI, I've just committed the attatched. It reverts a string of arbitrary whitespace changes made to various files including ChangeLogs. For ChangeLogs, they should be prepend-only. For other files, indentation fixes (via the indent program) are welcome but they should be kept separate. As mentioned before, the best way to commit a patch is to: $ cvs update $ while true ; do > cvs diff -p | less # or -u there should only be your change nothing else > $EDITOR bad changes > done $ cvs commit Why is this important? You soon come to appreciate this when you find yourself mining cvs diffs and ChangeLogs strying to figure out exactly what change (some year ago) caused a failure. By keeping different changes separate, the process is much simpler. Andrew PS: When doing this, a local copy of the CVS repository and ``-D'' are your friend. Mon Mar 27 14:46:37 2000 Andrew Cagney * ChangeLog: Revert whitespace changes. Mon Mar 27 14:46:37 2000 Andrew Cagney * ChangeLog, gdb.base/commands.exp: Revert whitespace changes. Index: ChangeLog =================================================================== RCS file: /cvs/src/src/gdb/ChangeLog,v retrieving revision 1.185 diff -p -r1.185 ChangeLog *** ChangeLog 2000/03/27 00:24:49 1.185 --- ChangeLog 2000/03/27 04:48:38 *************** Fri Mar 24 13:44:57 2000 Andrew Cagney *** 209,226 **** Wed Mar 22 15:09:34 2000 Andrew Cagney * configure.in (CONFIG_INITS): Do not append remote-nrom.c - - 2000-03-21 J.T. Conklin ! * i386/nbsd.mh (NATDEPFILES): Change i386b-nat.o to i386nbsd-nat.o. ! * i386nbsd-nat.c: New file. ! ! * i386/tm-nbsd.h (NUM_REGS): Removed. ! (HAVE_I387_REGS): Defined. ! * i386/nm-nbsd.h (FLOAT_INFO): Removed. ! ! * tm-nbsd.h (IN_SOLIB_CALL_TRAMPOLINE): Define if not ! SVR4_SHARED_LIBS. Wed Mar 22 11:18:59 2000 Andrew Cagney --- 213,230 ---- Wed Mar 22 15:09:34 2000 Andrew Cagney * configure.in (CONFIG_INITS): Do not append remote-nrom.c ! 2000-03-21 J.T. Conklin ! ! * i386/nbsd.mh (NATDEPFILES): Change i386b-nat.o to i386nbsd-nat.o. ! * i386nbsd-nat.c: New file. ! ! * i386/tm-nbsd.h (NUM_REGS): Removed. ! (HAVE_I387_REGS): Defined. ! * i386/nm-nbsd.h (FLOAT_INFO): Removed. ! ! * tm-nbsd.h (IN_SOLIB_CALL_TRAMPOLINE): Define if not ! SVR4_SHARED_LIBS. Wed Mar 22 11:18:59 2000 Andrew Cagney *************** Wed Mar 22 11:18:59 2000 Andrew Cagney *** 271,277 **** (bpstat_stop_status, can_use_hardware_watchpoint): Don't insert, remove, or check status of hardware watchpoints for entire structs and arrays unless the user explicitly asked to watch that struct ! or array. (insert_breakpoints): Try to insert watchpoints for all the values on the value chain, even if some of them fail to insert. --- 275,281 ---- (bpstat_stop_status, can_use_hardware_watchpoint): Don't insert, remove, or check status of hardware watchpoints for entire structs and arrays unless the user explicitly asked to watch that struct ! or array. (insert_breakpoints): Try to insert watchpoints for all the values on the value chain, even if some of them fail to insert. *************** Wed Mar 22 11:18:59 2000 Andrew Cagney *** 284,290 **** Implement the extra thread info query for "info threads". (remote_threads_info): clean up a bit. (use_threadinfo_query, use_threadextra_query): new variables. ! Control whether GDB will use the new or old protocol for thread info queries. (remote_open_1): initialize new variables. (remote_async_open_1): ditto. --- 288,294 ---- Implement the extra thread info query for "info threads". (remote_threads_info): clean up a bit. (use_threadinfo_query, use_threadextra_query): new variables. ! Control whether GDB will use the new or old protocol for thread info queries. (remote_open_1): initialize new variables. (remote_async_open_1): ditto. *************** Fri Mar 17 11:06:59 2000 Philippe De Mu *** 429,435 **** * config/i386/tm-linux.h (I386_LINUX_SIGTRAMP): No need to define this any more, since we're not enabling OS-specific code in a OS-independent file. ! 2000-03-16 Eli Zaretskii * Makefile.in (go32-nat.o): Add prerequisites. --- 433,439 ---- * config/i386/tm-linux.h (I386_LINUX_SIGTRAMP): No need to define this any more, since we're not enabling OS-specific code in a OS-independent file. ! 2000-03-16 Eli Zaretskii * Makefile.in (go32-nat.o): Add prerequisites. *************** Fri Mar 17 11:06:59 2000 Philippe De Mu *** 467,473 **** * solib.c (special_symbol_handling): Delete argument; it's not used. ! Changes from Peter Schauer : * solib.c (SOLIB_EXTRACT_ADDRESS): New macro to extract addresses --- 471,477 ---- * solib.c (special_symbol_handling): Delete argument; it's not used. ! Changes from Peter Schauer : * solib.c (SOLIB_EXTRACT_ADDRESS): New macro to extract addresses *************** Mon Mar 13 21:21:41 2000 Andrew Cagney *** 505,531 **** 2000-03-13 James Ingham ! Add support for a variable object that tries to evaluate itself in the currently selected frame, rather than in a fixed frame. ! * wrapper.c,h (gdb_parse_exp_1): Added a wrapper for gdb_parse_exp_1. ! * varobj.h: Added USE_CURRENT_FRAME to varobj_type & changed def'n of varobj_create. * varobj.c (varobj_list): Return type indicates whether the variable's type has changed (for current frame variables). (varobj_update): Handle the case where the variable's type has changed. ! (delete_variable_1): Allow for deletion of variables that have not been installed yet. (new_root_variable): Initialize use_selected_frame variable. ! (value_of_root): This is where most of the work to handle "current frame" variables was added. Most of the complexity involves handling the case where the type of the variable has changed. (varobj_create): Add a "type" argument, to tell if the variable is one of these "current frame" variables. Also protect call to parse_exp_1 from long jumping. ! 2000-03-13 Eli Zaretskii * go32-nat.c (struct env387): Remove declaration. --- 509,535 ---- 2000-03-13 James Ingham ! Add support for a variable object that tries to evaluate itself in the currently selected frame, rather than in a fixed frame. ! * wrapper.c,h (gdb_parse_exp_1): Added a wrapper for gdb_parse_exp_1. ! * varobj.h: Added USE_CURRENT_FRAME to varobj_type & changed def'n of varobj_create. * varobj.c (varobj_list): Return type indicates whether the variable's type has changed (for current frame variables). (varobj_update): Handle the case where the variable's type has changed. ! (delete_variable_1): Allow for deletion of variables that have not been installed yet. (new_root_variable): Initialize use_selected_frame variable. ! (value_of_root): This is where most of the work to handle "current frame" variables was added. Most of the complexity involves handling the case where the type of the variable has changed. (varobj_create): Add a "type" argument, to tell if the variable is one of these "current frame" variables. Also protect call to parse_exp_1 from long jumping. ! 2000-03-13 Eli Zaretskii * go32-nat.c (struct env387): Remove declaration. *************** Mon Mar 13 18:54:42 2000 Andrew Cagney *** 574,580 **** * gdbtypes.c (rank_one_type): Add comment on how to eliminate the #ifdef DEBUG_OLOAD. ! 2000-03-11 Mark Kettenis * gnu-nat.c: Fix the formatting where indent misinterpreted `&' as --- 578,584 ---- * gdbtypes.c (rank_one_type): Add comment on how to eliminate the #ifdef DEBUG_OLOAD. ! 2000-03-11 Mark Kettenis * gnu-nat.c: Fix the formatting where indent misinterpreted `&' as *************** Sat Mar 4 10:57:25 2000 Andrew Cagney *** 776,782 **** other function typedefs. Document as not be used out side of make_cleanup code. Use in make_cleanup declarations. (null_cleanup): Replace PTR with void*. ! * utils.c (make_cleanup, make_final_cleanup, make_run_cleanup, make_exec_cleanup, make_exec_error_cleanup, make_my_cleanup, null_cleanup): Change K&R definition to ISO-C using void* and --- 780,786 ---- other function typedefs. Document as not be used out side of make_cleanup code. Use in make_cleanup declarations. (null_cleanup): Replace PTR with void*. ! * utils.c (make_cleanup, make_final_cleanup, make_run_cleanup, make_exec_cleanup, make_exec_error_cleanup, make_my_cleanup, null_cleanup): Change K&R definition to ISO-C using void* and *************** Fri Mar 3 15:39:34 2000 Andrew Cagney *** 801,807 **** (all-gdbtk, clean-gdbtk): New targets. (all): Add CONFIG_ALL as dependency. (clean): Add CONFIG_CLEAN as dependency. ! * configure.in (CONFIG_ALL, CONFIG_CLEAN): Define. (LN_S): Define. Delete GDBtk's link code. --- 805,811 ---- (all-gdbtk, clean-gdbtk): New targets. (all): Add CONFIG_ALL as dependency. (clean): Add CONFIG_CLEAN as dependency. ! * configure.in (CONFIG_ALL, CONFIG_CLEAN): Define. (LN_S): Define. Delete GDBtk's link code. *************** Fri Mar 3 13:12:34 2000 Andrew Cagney *** 841,847 **** Thu Mar 2 09:04:46 2000 Andrew Cagney ! * MAINTAINERS: Daniel Berlin is C++ maintainer. Thu Mar 2 08:55:35 2000 Andrew Cagney --- 845,851 ---- Thu Mar 2 09:04:46 2000 Andrew Cagney ! * MAINTAINERS: Daniel Berlin is C++ maintainer. Thu Mar 2 08:55:35 2000 Andrew Cagney *************** Thu Mar 2 08:55:35 2000 Andrew Cagney *** 851,860 **** Solaris/x86. Wed Mar 1 22:12:35 2000 Andrew Cagney ! From Wed 23 Feb 2000 Fernando Nasser : * remote-sim.c (gdbsim_close): Call generic_mourn_inferior. ! * remote-rdi.c (arm_rdi_close): Ditto. Wed Mar 1 19:31:32 2000 Andrew Cagney --- 855,864 ---- Solaris/x86. Wed Mar 1 22:12:35 2000 Andrew Cagney ! From Wed 23 Feb 2000 Fernando Nasser : * remote-sim.c (gdbsim_close): Call generic_mourn_inferior. ! * remote-rdi.c (arm_rdi_close): Ditto. Wed Mar 1 19:31:32 2000 Andrew Cagney *************** Tue Feb 29 15:14:56 2000 Andrew Cagney *** 950,959 **** as in the Linux kernel. Modified prototype to get rid of unused parameters. (store_nw_fpe_*): Renamed to store_nwfpe_* to use the same ! naming convention as in the Linux kernel. Fixed calls to fetch_nwfpe_*. (store_fpregs): Fixed calls to store_nwfpe_*. Removed ! unused variable. Mon Feb 28 18:24:32 2000 Andrew Cagney --- 954,963 ---- as in the Linux kernel. Modified prototype to get rid of unused parameters. (store_nw_fpe_*): Renamed to store_nwfpe_* to use the same ! naming convention as in the Linux kernel. Fixed calls to fetch_nwfpe_*. (store_fpregs): Fixed calls to store_nwfpe_*. Removed ! unused variable. Mon Feb 28 18:24:32 2000 Andrew Cagney *************** Thu Feb 24 18:42:15 2000 Andrew Cagney *** 1065,1071 **** * configure.in (CONFIG_INSTALL, CONFIG_UNINSTALL): Set to $(SUBDIR_*_INSTALL) when so configured. * configure: Regenerate. ! * Makefile.in (CONFIG_INSTALL, CONFIG_UNINSTALL): Define using configure. (install-only): Add dependency on $(CONFIG_INSTALL). Delete code --- 1069,1075 ---- * configure.in (CONFIG_INSTALL, CONFIG_UNINSTALL): Set to $(SUBDIR_*_INSTALL) when so configured. * configure: Regenerate. ! * Makefile.in (CONFIG_INSTALL, CONFIG_UNINSTALL): Define using configure. (install-only): Add dependency on $(CONFIG_INSTALL). Delete code *************** Thu Feb 24 18:19:52 2000 Andrew Cagney *** 1079,1085 **** * configure.in (SUBDIR_MI_CFLAGS): Fix typo, wrong brace. * configure: Regenerate. ! 2000-02-24 Christopher Faylor * configure.tgt: Add arm, mips, sh wince targets. --- 1083,1089 ---- * configure.in (SUBDIR_MI_CFLAGS): Fix typo, wrong brace. * configure: Regenerate. ! 2000-02-24 Christopher Faylor * configure.tgt: Add arm, mips, sh wince targets. *************** Mon Feb 21 13:57:27 2000 Andrew Cagney *** 1133,1139 **** interface. * configure: Regenerate. ! * Makefile.in (SUBDIR_MI_OBS, SUBDIR_MI_SRCS, SUBDIR_MI_DEPS, SUBDIR_MI_INITS, SUBDIR_MI_LDFLAGS, SUBDIR_MI_CFLAGS): New macros. (CONFIG_OBS, CONFIG_SRCS, CONFIG_DEPS, CONFIG_INITS, --- 1137,1143 ---- interface. * configure: Regenerate. ! * Makefile.in (SUBDIR_MI_OBS, SUBDIR_MI_SRCS, SUBDIR_MI_DEPS, SUBDIR_MI_INITS, SUBDIR_MI_LDFLAGS, SUBDIR_MI_CFLAGS): New macros. (CONFIG_OBS, CONFIG_SRCS, CONFIG_DEPS, CONFIG_INITS, *************** Mon Feb 21 11:03:01 2000 Andrew Cagney *** 1254,1260 **** Andrew Cagney, Elena Zannoni and Fernando Nasser; Web pages - Jim Kingdon. * MAINTAINERS: Add Nick Clifton to write after approval list. ! Mon Feb 21 10:30:39 2000 Andrew Cagney * MAINTAINERS: Add note on multiple maintainers. --- 1258,1264 ---- Andrew Cagney, Elena Zannoni and Fernando Nasser; Web pages - Jim Kingdon. * MAINTAINERS: Add Nick Clifton to write after approval list. ! Mon Feb 21 10:30:39 2000 Andrew Cagney * MAINTAINERS: Add note on multiple maintainers. *************** Wed Feb 16 19:00:02 2000 Andrew Cagney *** 1351,1357 **** code to also handle the PowerOpen ABI. (ppc_push_return_address): Enable for all ports. * config/powerpc/tm-ppc-aix.h (USE_GENERIC_DUMMY_FRAMES, ! PUSH_DUMMY_FRAME, PUSH_RETURN_ADDRESS, GET_SAVED_REGISTER, CALL_DUMMY_BREAKPOINT_OFFSET, CALL_DUMMY_LOCATION, CALL_DUMMY_ADDRESS, CALL_DUMMY_START_OFFSET): Override defaults provided by generic RS6000 definitions so that call dummies --- 1355,1361 ---- code to also handle the PowerOpen ABI. (ppc_push_return_address): Enable for all ports. * config/powerpc/tm-ppc-aix.h (USE_GENERIC_DUMMY_FRAMES, ! PUSH_DUMMY_FRAME, PUSH_RETURN_ADDRESS, GET_SAVED_REGISTER, CALL_DUMMY_BREAKPOINT_OFFSET, CALL_DUMMY_LOCATION, CALL_DUMMY_ADDRESS, CALL_DUMMY_START_OFFSET): Override defaults provided by generic RS6000 definitions so that call dummies *************** Wed Feb 16 19:00:02 2000 Andrew Cagney *** 1374,1380 **** 2000-02-15 Jesper Skov Patch applied by Kevin Buettner ! * rs6000-tdep.c (skip_prologue): skip copying of argument registers to local variable registers. --- 1378,1384 ---- 2000-02-15 Jesper Skov Patch applied by Kevin Buettner ! * rs6000-tdep.c (skip_prologue): skip copying of argument registers to local variable registers. *************** Mon Feb 14 15:20:26 2000 Andrew Cagney *** 1415,1421 **** * configure.tgt (i[3456]86-*-netbsd*): add gdbserver to configdirs. * gdbserver/low-nbsd.c: New file. ! * gdbserver/Makefile.in: convert to autoconf. * gdbserver/configure.in: likewise. * gdbserver/configure: generate. --- 1419,1425 ---- * configure.tgt (i[3456]86-*-netbsd*): add gdbserver to configdirs. * gdbserver/low-nbsd.c: New file. ! * gdbserver/Makefile.in: convert to autoconf. * gdbserver/configure.in: likewise. * gdbserver/configure: generate. *************** Tue Feb 1 00:17:12 2000 Andrew Cagney *** 1621,1627 **** * ui-file.c, ui-file.h: Rename gdb-file.h, gdb-file.c. Rename ``struct gdb_file'' to ``struct ui_file''. Delete typedef GDB_FILE. ! * Makefile.in: Update. * ax-gdb.c, ax-general.c, ax.h, buildsym.c, c-lang.c, c-lang.h, --- 1625,1631 ---- * ui-file.c, ui-file.h: Rename gdb-file.h, gdb-file.c. Rename ``struct gdb_file'' to ``struct ui_file''. Delete typedef GDB_FILE. ! * Makefile.in: Update. * ax-gdb.c, ax-general.c, ax.h, buildsym.c, c-lang.c, c-lang.h, *************** Mon Jan 31 17:14:52 2000 Andrew Cagney *** 1682,1688 **** tui_file_get_strbuf, tui_file_adjust_strbuf, tui_file_flush, fputs_unfiltered_hook): Moved to tui/tui-file.c and tui/tui-file.h. ! * Makefile.in (COMMON_OBS): Add gdb-file.o, tui-file.o. (tui-file.o, gdb-file.o): Add dependencies. (corefile.o, main.o, utils.o, simmisc.o): Update dependencies. --- 1686,1692 ---- tui_file_get_strbuf, tui_file_adjust_strbuf, tui_file_flush, fputs_unfiltered_hook): Moved to tui/tui-file.c and tui/tui-file.h. ! * Makefile.in (COMMON_OBS): Add gdb-file.o, tui-file.o. (tui-file.o, gdb-file.o): Add dependencies. (corefile.o, main.o, utils.o, simmisc.o): Update dependencies. *************** Mon Jan 31 17:14:52 2000 Andrew Cagney *** 1831,1841 **** * infrun.c (normal_stop): Use enum values rather than integers for the source_flag to be passed to show_and_print_stack_frame(). Update copyright. ! * frame.h (print_what): New enum for 'source' argument to print_frame_info_base(). Use this instead of obscure numbers. Update copyright. ! Sun Jan 16 17:58:00 2000 David Taylor * event-top.c (stdin_event_handler): call quit_command rather than --- 1835,1845 ---- * infrun.c (normal_stop): Use enum values rather than integers for the source_flag to be passed to show_and_print_stack_frame(). Update copyright. ! * frame.h (print_what): New enum for 'source' argument to print_frame_info_base(). Use this instead of obscure numbers. Update copyright. ! Sun Jan 16 17:58:00 2000 David Taylor * event-top.c (stdin_event_handler): call quit_command rather than *************** Thu Jan 13 23:34:17 EST 2000 Nicholas D *** 1949,1955 **** (proc_flags): combine flags that UnixWare splits into two locations. (proc_modify_flag): add support for PR_KLC (kill on last close). (proc_[un]set_kill_on_last_close): new functions. ! 2000-01-07 Elena Zannoni * infrun.c (normal_stop): Print out thread id when we stop. --- 1953,1959 ---- (proc_flags): combine flags that UnixWare splits into two locations. (proc_modify_flag): add support for PR_KLC (kill on last close). (proc_[un]set_kill_on_last_close): new functions. ! 2000-01-07 Elena Zannoni * infrun.c (normal_stop): Print out thread id when we stop. Index: testsuite/ChangeLog =================================================================== RCS file: /cvs/src/src/gdb/testsuite/ChangeLog,v retrieving revision 1.13 diff -p -r1.13 ChangeLog *** ChangeLog 2000/03/25 15:32:19 1.13 --- ChangeLog 2000/03/27 04:49:01 *************** *** 37,43 **** 2000-03-13 James Ingham * lib/gdb.exp: Fix the gdbtk_start routine to correctly find all ! the library directories. Mon Feb 21 13:05:36 2000 Andrew Cagney --- 41,47 ---- 2000-03-13 James Ingham * lib/gdb.exp: Fix the gdbtk_start routine to correctly find all ! the library directories. Mon Feb 21 13:05:36 2000 Andrew Cagney *************** Mon Feb 21 13:05:36 2000 Andrew Cagney *** 45,51 **** * configure: Re-generate. * gdb.mi: New directory. ! 2000-02-25 Scott Bambrough * gdb.base/long_long.exp: Correct test suite failure when printing --- 49,55 ---- * configure: Re-generate. * gdb.mi: New directory. ! 2000-02-25 Scott Bambrough * gdb.base/long_long.exp: Correct test suite failure when printing *************** Mon Feb 21 13:05:36 2000 Andrew Cagney *** 106,112 **** * gdb.base/so-indr-cl.exp: Don't execute the test if not on HPUX. Don't use xfail's because that affects only the following test. ! * gdb.base/so-impl-ld.exp: Don't execute the tests if not on hpux, solaris or linux. --- 110,116 ---- * gdb.base/so-indr-cl.exp: Don't execute the test if not on HPUX. Don't use xfail's because that affects only the following test. ! * gdb.base/so-impl-ld.exp: Don't execute the tests if not on hpux, solaris or linux. *************** Mon Feb 21 13:05:36 2000 Andrew Cagney *** 114,120 **** 2000-01-07 Michael Snyder ! * gdb.base/display.exp: Some yacc parsers like to say "A syntax error" rather than "A parse error". Accept both. 2000-01-06 Fernando Nasser --- 118,124 ---- 2000-01-07 Michael Snyder ! * gdb.base/display.exp: Some yacc parsers like to say "A syntax error" rather than "A parse error". Accept both. 2000-01-06 Fernando Nasser *************** Sat Dec 4 15:21:18 1999 Andrew Cagney *** 241,253 **** * gdb.c++/derivation.exp: remove redundant get compiler info code. ! * gdb.base/commands.exp: add '$gdb_prompt $' anchor to 'continue with watch' test point. 1999-11-08 Jim Blandy Merged from p2linux-990323-branch: ! * lib/gdb.exp (gdb_continue_to_breakpoint): New function. Mon Nov 8 23:07:09 1999 Andrew Cagney --- 245,257 ---- * gdb.c++/derivation.exp: remove redundant get compiler info code. ! * gdb.base/commands.exp: add '$gdb_prompt $' anchor to 'continue with watch' test point. 1999-11-08 Jim Blandy Merged from p2linux-990323-branch: ! * lib/gdb.exp (gdb_continue_to_breakpoint): New function. Mon Nov 8 23:07:09 1999 Andrew Cagney *************** Mon Oct 11 13:57:21 1999 Andrew Cagney *** 313,319 **** containing exp_continue into a while within an expect. Don't attempt a start more than three times. Check return value from gdb_load. ! Wed Oct 6 12:05:58 1999 Andrew Cagney * gdb.base/watchpoint.exp: Match fail ``finish from marker1'' with --- 317,323 ---- containing exp_continue into a while within an expect. Don't attempt a start more than three times. Check return value from gdb_load. ! Wed Oct 6 12:05:58 1999 Andrew Cagney * gdb.base/watchpoint.exp: Match fail ``finish from marker1'' with *************** Wed Oct 6 12:05:58 1999 Andrew Cagney *** 328,334 **** 1999-10-01 Fred Fish ! * gdb.base/help.exp (help add-symbol-file): Update to match current gdb output. 1999-09-18 Jim Blandy --- 332,338 ---- 1999-10-01 Fred Fish ! * gdb.base/help.exp (help add-symbol-file): Update to match current gdb output. 1999-09-18 Jim Blandy *************** Tue Aug 10 15:25:16 1999 Andrew Cagney *** 559,565 **** * gdb.c++/virtfunc.cc: Add return type and value for main. * gdb.c++/virtfunc.exp: Run if HP compiler used, add some match alternatives. ! 1999-07-30 Elena Zannoni * gdb.base/display.exp: Fix output of 'p/a &&j' test. --- 563,569 ---- * gdb.c++/virtfunc.cc: Add return type and value for main. * gdb.c++/virtfunc.exp: Run if HP compiler used, add some match alternatives. ! 1999-07-30 Elena Zannoni * gdb.base/display.exp: Fix output of 'p/a &&j' test. *************** Tue Aug 10 15:25:16 1999 Andrew Cagney *** 613,620 **** * gdb.c++/annota2.exp: Fix delete breakpoint query testcase. Fix run to main failures. Watchpoint can be hardware watchpoint. ! ! * gdb.base/annota1.exp: Clean up some more, in case printf has debug info. Deal with lack of signal hanlder info in stack. From Jim Kingdon : --- 617,624 ---- * gdb.c++/annota2.exp: Fix delete breakpoint query testcase. Fix run to main failures. Watchpoint can be hardware watchpoint. ! ! * gdb.base/annota1.exp: Clean up some more, in case printf has debug info. Deal with lack of signal hanlder info in stack. From Jim Kingdon : *************** Fri Jun 25 19:27:28 1999 Andrew Cagney *** 756,762 **** print_double_array(double_array)", "continuing to breakpoint 1018", "print print_double_array(array_d)" and "continuing to 1034" tests. ! 1999-06-24 Jason Molenda (jsm@bugshack.cygnus.com) * Makefile.in: Add empty html and install-html targets. --- 760,766 ---- print_double_array(double_array)", "continuing to breakpoint 1018", "print print_double_array(array_d)" and "continuing to 1034" tests. ! 1999-06-24 Jason Molenda (jsm@bugshack.cygnus.com) * Makefile.in: Add empty html and install-html targets. *************** Wed Jun 2 17:37:05 1999 Andrew Cagney *** 829,837 **** 1999-05-20 Elena Zannoni ! * gdb.base/annota1.exp: Allow any number of "frames-invalid" and "breakpoint-invalid" to be printed. ! * gdb.base/annota2.exp: Revise line number for main breakpoint. Allow any number of "frames-invalid" and "breakpoint-invalid" to be printed. * gdb.base/annota2.cc: Initialize a.x to 0. --- 833,841 ---- 1999-05-20 Elena Zannoni ! * gdb.base/annota1.exp: Allow any number of "frames-invalid" and "breakpoint-invalid" to be printed. ! * gdb.base/annota2.exp: Revise line number for main breakpoint. Allow any number of "frames-invalid" and "breakpoint-invalid" to be printed. * gdb.base/annota2.cc: Initialize a.x to 0. *************** Wed Jun 2 17:37:05 1999 Andrew Cagney *** 848,854 **** "skip_float_tests" is set. * gdb.base/varargs.exp: Skip "print find_max_double(5,1.0,17.0,2.0,3.0,4.0)" when "skip_float_tests" set. ! 1999-05-06 Keith Seitz * gdb.base/annota2.cc: Include stdio.h. --- 852,858 ---- "skip_float_tests" is set. * gdb.base/varargs.exp: Skip "print find_max_double(5,1.0,17.0,2.0,3.0,4.0)" when "skip_float_tests" set. ! 1999-05-06 Keith Seitz * gdb.base/annota2.cc: Include stdio.h. *************** Wed May 5 17:44:31 1999 Stan Shebs * gdb.base/commands.exp: Add test for correct position of '>' ! when issuing the 'commands' command after a 'while' or 'if' command. 1999-03-18 James Ingham --- 953,959 ---- Tue Mar 23 14:56:36 1999 Elena Zannoni * gdb.base/commands.exp: Add test for correct position of '>' ! when issuing the 'commands' command after a 'while' or 'if' command. 1999-03-18 James Ingham *************** Tue Mar 23 14:56:36 1999 Elena Zannoni *** 962,968 **** * gdb.base/watchpoint.exp: Use gdb_continue_to_end. * gdb.base/step-test.exp: Catch a case where finish is broken and ! keep it from killing the rest of the tests. Use gdb_continue_to_end. * gdb.base/sigall.exp: use gdb_continue_to_end. --- 966,972 ---- * gdb.base/watchpoint.exp: Use gdb_continue_to_end. * gdb.base/step-test.exp: Catch a case where finish is broken and ! keep it from killing the rest of the tests. Use gdb_continue_to_end. * gdb.base/sigall.exp: use gdb_continue_to_end. *************** Tue Mar 23 14:56:36 1999 Elena Zannoni *** 971,981 **** * gdb.base/display.exp: use runto_main, not run. ! * gdb.base/default.exp: Check for the current error message in the ! r abbreviation test. Add strongarm to the targets that know info float. ! * gdb.base/condbreak.exp: Use the gdb_run command rather than just run which doesn't work with monitors. * gdb.base/call-ar-st.exp: fixed bogus regexp in continuing to 1034 test. --- 975,985 ---- * gdb.base/display.exp: use runto_main, not run. ! * gdb.base/default.exp: Check for the current error message in the ! r abbreviation test. Add strongarm to the targets that know info float. ! * gdb.base/condbreak.exp: Use the gdb_run command rather than just run which doesn't work with monitors. * gdb.base/call-ar-st.exp: fixed bogus regexp in continuing to 1034 test. *************** Tue Mar 23 14:56:36 1999 Elena Zannoni *** 983,990 **** * gdb.base/break.exp: use the gdb_continue_to_end proc. * lib/gdb.exp: I had added gdb_continue_to_end used to run to the end of a ! program. Traps the case (in Cygmon) when the program never really ! exits. Same as Mark's continue_to_exit, but I had put it in a lot more places, so I used my name. Sorry Mark... * config/monitor.exp (gdb_target_monitor): added another --- 987,994 ---- * gdb.base/break.exp: use the gdb_continue_to_end proc. * lib/gdb.exp: I had added gdb_continue_to_end used to run to the end of a ! program. Traps the case (in Cygmon) when the program never really ! exits. Same as Mark's continue_to_exit, but I had put it in a lot more places, so I used my name. Sorry Mark... * config/monitor.exp (gdb_target_monitor): added another *************** Fri Mar 12 18:06:21 1999 Stan Shebs ! * gdb.base/a2-run.exp: Add expected fails for strongarm-coff. 1999-03-04 Jim Blandy --- 1050,1056 ---- 1999-03-05 Nick Clifton ! * gdb.base/a2-run.exp: Add expected fails for strongarm-coff. 1999-03-04 Jim Blandy *************** Fri Mar 12 18:06:21 1999 Stan Shebs --- 1063,1070 ---- * browser.test: Fixed up to match the new function browser. This is not done yet... ! * srcwin.test: Check for errors when the bbox is called for a text ! item that is not on screen (so bbox is ""). Return something more useful. 1999-03-01 James Ingham *************** Fri Feb 5 12:42:56 1999 Stan Shebs ! * lib/gdb.exp (gdb_preprocess): Remove 'puts' statement. * gdb.c++/method.exp: Add missing close brace. --- 1175,1186 ---- * gdb.base/long_long.c (known_types): Initialize values to zero. * gdb.base/long_long.exp: Step one more line so 'dec' is initialized in "get to known place". GDB removes ! leading zeros. Explicitly ask for hex formatting. Use unique test case names. Tue Feb 2 10:16:08 1999 Elena Zannoni ! * lib/gdb.exp (gdb_preprocess): Remove 'puts' statement. * gdb.c++/method.exp: Add missing close brace. *************** Tue Jan 19 17:20:09 1999 David Taylor *** 1226,1233 **** Fri Jan 15 14:04:57 1999 Elena Zannoni ! * gdb.hp/xdb3.exp: do not execute unless on hppa-hpux platform ! and compiled w/o GCC. * gdb.hp/watch-cmd.exp: ditto. --- 1230,1237 ---- Fri Jan 15 14:04:57 1999 Elena Zannoni ! * gdb.hp/xdb3.exp: do not execute unless on hppa-hpux platform ! and compiled w/o GCC. * gdb.hp/watch-cmd.exp: ditto. *************** Wed Jan 6 18:41:15 1999 David Taylor *** 1367,1373 **** * gdb.c++/ref-types.exp: new file. * gdb.c++/ref-types2.exp: new file. * gdb.c++/userdef.exp: new file. ! Wed Jan 6 13:50:57 1999 Stan Shebs * gdb.base/default.exp: Reflect wording change in remote.c. --- 1371,1377 ---- * gdb.c++/ref-types.exp: new file. * gdb.c++/ref-types2.exp: new file. * gdb.c++/userdef.exp: new file. ! Wed Jan 6 13:50:57 1999 Stan Shebs * gdb.base/default.exp: Reflect wording change in remote.c. *************** Tue Jan 5 13:05:32 1999 David Taylor *** 1405,1426 **** * gdb.c++/ref-types.cc: new file. * gdb.c++/ref-types2.cc: new file. * gdb.c++/userdef.cc: new file. ! * gdb.base/scope.exp: compile one file at a time, then link. * gdb.base/langs.exp: ditto. * gdb.base/list.exp: ditto. ! Mon Jan 4 10:06:43 1999 David Taylor The following changes were made by David Taylor , Elena Zannoni , and Edith Epstein as part of a project to merge in changes by HP. ! * gdb.c++/inherit.exp: if on hppa*-*-hpux* and not using gcc, skip tests. When compiling pass c++ flag to gdb_compile. * gdb.c++/ ! * lib/gdb.exp (get_compiler_info): new, optional argument -- args; test for on hppa*-*-hpux*; use args to see if c++ was specified. (skip_hp_tests): new function. --- 1409,1430 ---- * gdb.c++/ref-types.cc: new file. * gdb.c++/ref-types2.cc: new file. * gdb.c++/userdef.cc: new file. ! * gdb.base/scope.exp: compile one file at a time, then link. * gdb.base/langs.exp: ditto. * gdb.base/list.exp: ditto. ! Mon Jan 4 10:06:43 1999 David Taylor The following changes were made by David Taylor , Elena Zannoni , and Edith Epstein as part of a project to merge in changes by HP. ! * gdb.c++/inherit.exp: if on hppa*-*-hpux* and not using gcc, skip tests. When compiling pass c++ flag to gdb_compile. * gdb.c++/ ! * lib/gdb.exp (get_compiler_info): new, optional argument -- args; test for on hppa*-*-hpux*; use args to see if c++ was specified. (skip_hp_tests): new function. *************** Mon Jan 4 10:06:43 1999 David Taylor *** 1449,1455 **** run the tests. tell gdb_compile that it's a c++ compilation. * gdb.threads/pthreads.exp: fix typo in message. ! * gdb.base/all-bin.exp: new file. * gdb.base/arithmet.exp: new file. * gdb.base/assign.exp: new file. --- 1453,1459 ---- run the tests. tell gdb_compile that it's a c++ compilation. * gdb.threads/pthreads.exp: fix typo in message. ! * gdb.base/all-bin.exp: new file. * gdb.base/arithmet.exp: new file. * gdb.base/assign.exp: new file. *************** Mon Dec 21 14:08:38 1998 David Taylor *** 1533,1539 **** T1::~T1(void) (test_hp_style_demangling): new hp specific demangling test cases. ! Mon Dec 14 15:07:03 1998 Jeffrey A Law (law@cygnus.com) * gdb.trace/actions.exp: Ignore compiler warnings compiling actions.c --- 1537,1543 ---- T1::~T1(void) (test_hp_style_demangling): new hp specific demangling test cases. ! Mon Dec 14 15:07:03 1998 Jeffrey A Law (law@cygnus.com) * gdb.trace/actions.exp: Ignore compiler warnings compiling actions.c *************** Mon Sep 14 20:00:04 1998 Michael Snyder *** 1622,1628 **** * gdb.trace/{packetlen.exp passc-dyn.exp passcount.exp}: New files. * gdb.trace/{report.exp save-trace.exp tracecmd.exp}: New files. * gdb.trace/{while-dyn.exp while-stepping.exp}: New files. ! Fri Sep 11 13:58:02 1998 Michael Snyder * gdb.c++/classes.exp: Change all regular expressions to match --- 1626,1632 ---- * gdb.trace/{packetlen.exp passc-dyn.exp passcount.exp}: New files. * gdb.trace/{report.exp save-trace.exp tracecmd.exp}: New files. * gdb.trace/{while-dyn.exp while-stepping.exp}: New files. ! Fri Sep 11 13:58:02 1998 Michael Snyder * gdb.c++/classes.exp: Change all regular expressions to match *************** Thu Jul 16 18:20:46 1998 Jeffrey A Law *** 1653,1659 **** Thurs Jul 9 11:08:31 1998 Dawn Perchik ! * gdb.base/commands.exp: Break up infrun_breakpoint_command_test into two parts to get around a synchronization problem in expect. Sun Jun 28 22:34:34 1998 Martin M. Hunt --- 1657,1663 ---- Thurs Jul 9 11:08:31 1998 Dawn Perchik ! * gdb.base/commands.exp: Break up infrun_breakpoint_command_test into two parts to get around a synchronization problem in expect. Sun Jun 28 22:34:34 1998 Martin M. Hunt *************** Mon Apr 13 22:32:51 1998 Frank Ch. Eigle *** 1784,1798 **** Fri Apr 10 22:38:12 1998 Peter Schauer (pes@regent.e-technik.tu-muenchen.de) * gdb.base/help.exp: Clean up `help set args' and `help show args' ! tests. * gdb.base/interrupt.exp: Add "i*86-*-solaris2*" xfail for calling ! function when asleep. * gdb.base/signals.exp: Add "i*86-*-solaris2*" xfails. Add comment ! for i*86 Linux and SVR4 signal handling problems. ! Remove linux xfail for `next to handler in signals_tests_1', fixed ! by recent infrun.c change. Limit backtrace to 10 frames to avoid timeout problems with infinite ! stack backtraces. Adjust expect pattern in `handle all print' test to match Apr 28 1997 target.[ch] change. --- 1788,1802 ---- Fri Apr 10 22:38:12 1998 Peter Schauer (pes@regent.e-technik.tu-muenchen.de) * gdb.base/help.exp: Clean up `help set args' and `help show args' ! tests. * gdb.base/interrupt.exp: Add "i*86-*-solaris2*" xfail for calling ! function when asleep. * gdb.base/signals.exp: Add "i*86-*-solaris2*" xfails. Add comment ! for i*86 Linux and SVR4 signal handling problems. ! Remove linux xfail for `next to handler in signals_tests_1', fixed ! by recent infrun.c change. Limit backtrace to 10 frames to avoid timeout problems with infinite ! stack backtraces. Adjust expect pattern in `handle all print' test to match Apr 28 1997 target.[ch] change. *************** Mon Feb 23 08:22:44 1998 Mark Alexander *** 1829,1835 **** * config/mn10300-eval.exp: New file to support MN10300 eval board. Wed Feb 18 16:43:46 1998 Michael Snyder (msnyder@cleaver.cygnus.com) ! * gdb.base/overlays (several files): Merge the two overlay managers into one. Change variables (foox, barx, bazx, grbxx) back into ints but force them to load in their proper sections. --- 1833,1839 ---- * config/mn10300-eval.exp: New file to support MN10300 eval board. Wed Feb 18 16:43:46 1998 Michael Snyder (msnyder@cleaver.cygnus.com) ! * gdb.base/overlays (several files): Merge the two overlay managers into one. Change variables (foox, barx, bazx, grbxx) back into ints but force them to load in their proper sections. *************** Tue Feb 10 17:23:22 1998 Andrew Cagney *** 1852,1858 **** * gdb.base/d10vovly.c (D10VTranslate): New function, handle updated d10v memory VMA/LMA map. (D10VCopy): Call D10VTranslate. ! Fri Feb 6 14:13:12 1998 Andrew Cagney * gdb.base/m32rovly.c: Force variable _novlys into .data section. --- 1856,1862 ---- * gdb.base/d10vovly.c (D10VTranslate): New function, handle updated d10v memory VMA/LMA map. (D10VCopy): Call D10VTranslate. ! Fri Feb 6 14:13:12 1998 Andrew Cagney * gdb.base/m32rovly.c: Force variable _novlys into .data section. *************** Fri Feb 6 14:13:12 1998 Andrew Cagney *** 1866,1877 **** * gdb.base/overlays.exp: Expect variables barx, bazx, foox, grbxx to be arrays. ! Thu Jan 29 14:48:19 1998 Michael Snyder (msnyder@cleaver.cygnus.com) ! * gdb.base/overlays.exp: fix up and get working again. Add tests for backtraces from an overlay function. ! Fri Jan 23 07:52:45 1998 Fred Fish * gdb.base/watchpoint.exp: Set "d10v*-*-*" clear_xfail for --- 1870,1881 ---- * gdb.base/overlays.exp: Expect variables barx, bazx, foox, grbxx to be arrays. ! Thu Jan 29 14:48:19 1998 Michael Snyder (msnyder@cleaver.cygnus.com) ! * gdb.base/overlays.exp: fix up and get working again. Add tests for backtraces from an overlay function. ! Fri Jan 23 07:52:45 1998 Fred Fish * gdb.base/watchpoint.exp: Set "d10v*-*-*" clear_xfail for *************** Tue Nov 25 12:46:36 1997 Andrew Cagney *** 1914,1920 **** target_sizeof_long and target_bigendian_p. (structs_by_value, structs_by_reference): Check values according to targets word size and endianess. ! Mon Nov 24 16:37:06 1997 Andrew Cagney * gdb.base/langs.exp: For "continue to exit" ignore any trailing --- 1918,1924 ---- target_sizeof_long and target_bigendian_p. (structs_by_value, structs_by_reference): Check values according to targets word size and endianess. ! Mon Nov 24 16:37:06 1997 Andrew Cagney * gdb.base/langs.exp: For "continue to exit" ignore any trailing *************** Fri Sep 12 16:56:38 1997 Bob Manson * lib/gdb.exp(default_gdb_exit): Don't give an error if the remote --- 2060,2066 ---- * gdb.c++/inherit.exp: Ditto. * gdb.c++/templates.exp: Ditto. * gdb.c++/virtfunc.exp: Ditto. ! Wed Jun 25 09:08:51 1997 Bob Manson * lib/gdb.exp(default_gdb_exit): Don't give an error if the remote *************** Thu May 1 18:01:50 1997 Bob Manson ! * gdb.base/printcmds.exp: add a couple more tests a la "p 123DEADBEEF", to check parse_number. * top.c: change "to enable to enable" to "to enable" in a couple of help strings. --- 2191,2197 ---- Mon Apr 28 17:27:40 1997 Michael Snyder ! * gdb.base/printcmds.exp: add a couple more tests a la "p 123DEADBEEF", to check parse_number. * top.c: change "to enable to enable" to "to enable" in a couple of help strings. *************** Thu Apr 24 14:38:18 1997 Jeffrey A Law *** 2196,2202 **** * gdb.base/callfuncs.exp: Mark some tests as expected to fail on the mn10300. ! Mon Apr 21 15:05:42 1997 Fred Fish * gdb.base/a2-run.exp: Add arm-*-coff setup_xfails for cases --- 2200,2206 ---- * gdb.base/callfuncs.exp: Mark some tests as expected to fail on the mn10300. ! Mon Apr 21 15:05:42 1997 Fred Fish * gdb.base/a2-run.exp: Add arm-*-coff setup_xfails for cases *************** Thu Apr 3 15:21:26 1997 Michael Snyder *** 2241,2247 **** d10v.ld m32r.ld d10vovly.c m32rovly.c: add test case for overlays. * gdb.base/sigall.c: add usestubs code frag * gdb.base/watchpoint.exp: turn on complex watchpoint test for M32R. ! Thu Apr 3 09:38:53 1997 Bob Manson * lib/gdb.exp(gdb_suppress_tests): Add explanation for subsequent --- 2245,2251 ---- d10v.ld m32r.ld d10vovly.c m32rovly.c: add test case for overlays. * gdb.base/sigall.c: add usestubs code frag * gdb.base/watchpoint.exp: turn on complex watchpoint test for M32R. ! Thu Apr 3 09:38:53 1997 Bob Manson * lib/gdb.exp(gdb_suppress_tests): Add explanation for subsequent *************** Sun Feb 23 19:56:02 1997 Bob Manson --- 2400,2406 ---- * config/vr4300.exp: New file. * gdb.*/*.exp: Call gdb_expect instead of expect. ! * lib/gdb.exp(gdb_expect): New function. Thu Feb 20 13:57:01 1997 Bob Manson *************** Sun Feb 2 00:55:14 1997 Bob Manson * gdb.*/*.exp: Replace $prompt with $gdb_prompt. ! * gdb.base/scope.exp: Use gdb_test. * gdb.c++/classes.exp: Ditto. * gdb.c++/inherit.exp: Ditto. --- 2575,2581 ---- Sat Feb 1 23:51:01 1997 Bob Manson * gdb.*/*.exp: Replace $prompt with $gdb_prompt. ! * gdb.base/scope.exp: Use gdb_test. * gdb.c++/classes.exp: Ditto. * gdb.c++/inherit.exp: Ditto. *************** Thu Jan 30 16:49:25 1997 Bob Manson Major rewrite for testsuite revision. ! * lib/gdb.exp: Remove references to global CC, CXX, B_OPTIONS, TARGET_INCLUDES, LDFLAGS and target_alias. Use gdb_spawn_id instead of relying on spawn_id to always contain a valid --- 2605,2611 ---- Tue Jan 28 14:42:31 1997 Bob Manson Major rewrite for testsuite revision. ! * lib/gdb.exp: Remove references to global CC, CXX, B_OPTIONS, TARGET_INCLUDES, LDFLAGS and target_alias. Use gdb_spawn_id instead of relying on spawn_id to always contain a valid *************** Tue Jan 28 14:42:31 1997 Bob Manson * gdb.c++/inherit.exp (test_print_anon_union): Reenable --- 2706,2712 ---- (xgcc): Set variable to full path of gcc in build tree. Use findfile to verify that gcc exists in build tree, and if so set CC to that gcc and to use B_OPTIONS and TARGET_INCLUDES. ! Tue Nov 12 16:20:13 1996 Fred Fish * gdb.c++/inherit.exp (test_print_anon_union): Reenable *************** Tue Nov 5 10:44:23 1996 Michael Snyder *** 2746,2752 **** * gdb.base/[bitfields.exp crossload.exp funcargs.exp interrupt.exp list.exp scope.exp watchpoint.exp] Make all timeout error msgs explicitly say "(timeout)". ! Mon Nov 4 12:03:06 1996 Michael Snyder * config/monitor.exp: Increase download timeout to 1000 seconds. --- 2750,2756 ---- * gdb.base/[bitfields.exp crossload.exp funcargs.exp interrupt.exp list.exp scope.exp watchpoint.exp] Make all timeout error msgs explicitly say "(timeout)". ! Mon Nov 4 12:03:06 1996 Michael Snyder * config/monitor.exp: Increase download timeout to 1000 seconds. *************** Fri Oct 11 17:05:22 1996 Fred Fish --- 2819,2825 ---- (distclean maintainer-clean realclean): No need to remove files twice. Nuke the duplicates. * gdb.base/Makefile.in (EXECUTABLES): Add "structs". ! * gdb.threads/Makefile.in (distclean maintainer-clean realclean): Remove config.h along with other config files. Mon Sep 30 20:16:22 1996 Fred Fish *************** Mon Sep 30 20:16:22 1996 Fred Fish * gdb.base/a1-selftest.exp: Tweak tests to account for new --- 2844,2850 ---- * lib/gdb.exp (gdb_test): When a gdb aborts, print a more meaningful error message and return -1 so the caller can suppress further tests and avoid a cascade of errors. ! Fri Sep 27 10:34:51 1996 Fred Fish * gdb.base/a1-selftest.exp: Tweak tests to account for new *************** Fri Sep 27 10:34:51 1996 Fred Fish * Makefile.in (VPATH): Add --- 2852,2858 ---- * gdb.base/default.exp: Ditto. * gdb.base/interrupt.exp: Fix problem with cascade of errors if child process dies while calling a function. ! Fri Sep 13 21:43:48 1996 Fred Fish * Makefile.in (VPATH): Add *************** Mon Sep 2 06:36:02 1996 Fred Fish * gdb.threads/pthreads.c (PTHREAD_CREATE_ARG2, --- 2884,2890 ---- executable, give more meaningful message. * gdb.threads/pthreads.c: Hpux also uses old definition of second arg for pthread_create. ! Mon Aug 19 09:58:59 1996 Fred Fish * gdb.threads/pthreads.c (PTHREAD_CREATE_ARG2, *************** Mon Aug 19 09:58:59 1996 Fred Fish --- 2903,2909 ---- for not compiled with gcc. * gdb.base/mips_pro.exp: Only do setup_xfail hppa*-*-* for backtrace when compiled with gcc. ! * lib/gdb.exp (runto_main): Return result of "runto main" rather than always return success. Sat Aug 17 13:28:00 1996 Fred Fish *************** Mon Aug 12 15:29:08 1996 Fred Fish * gdb.base/term.exp: Set 7-bit strings, address off, width to 0, --- 2927,2933 ---- tests. gdb.c++/virtfunc.exp (do_tests): Add "mips-*-irix5*" setup_xfail for "runto test_calls(void)" test. ! Sun Aug 11 13:11:24 1996 Fred Fish * gdb.base/term.exp: Set 7-bit strings, address off, width to 0, *************** Wed Aug 7 11:05:47 1996 Fred Fish * lib/gdb.exp (gdb_test_exact): Turn \n in pattern into \r\n. --- 2966,2972 ---- * gdb.threads/{config.in, pthreads.c, pthreads.exp}: New. * gdb.threads/{Makefile.in, configure.in}: Complete rewrites. * gdb.threads/configure: New, generated with autoconf. ! Tue Aug 6 10:23:04 1996 Tom Tromey * lib/gdb.exp (gdb_test_exact): Turn \n in pattern into \r\n. *************** Tue Jun 25 23:16:58 1996 Jason Molenda *** 3032,3040 **** Tue Jun 25 17:02:39 1996 Jason Molenda (crash@godzilla.cygnus.co.jp) * configure.in (AC_PREREQ): autoconf 2.5 or higher. ! * gdb.{base,c++,chill,disasm,stabs}/Makefile.in (VPATH): set to @srcdir@. ! * gdb.{base,c++,chill,disasm,stabs}/configure.in (AC_PREREQ): autoconf 2.5 or higher. * gdb.{base,c++,chill,disasm,stabs}/configure: Rebuilt. --- 3036,3044 ---- Tue Jun 25 17:02:39 1996 Jason Molenda (crash@godzilla.cygnus.co.jp) * configure.in (AC_PREREQ): autoconf 2.5 or higher. ! * gdb.{base,c++,chill,disasm,stabs}/Makefile.in (VPATH): set to @srcdir@. ! * gdb.{base,c++,chill,disasm,stabs}/configure.in (AC_PREREQ): autoconf 2.5 or higher. * gdb.{base,c++,chill,disasm,stabs}/configure: Rebuilt. *************** Wed May 15 08:47:42 1996 Jeffrey A Law *** 3098,3104 **** * gdb.base/ptype.exp: Likewise. * gdb.base/setvar.exp: Handle sizeof (int) != 4 for h8300. Add h8300 xfails. ! * gdb.base/return.exp: Handle float/double precision problems on the h8300. * gdb.base/funcargs.c: Explicitly make last constant argument to call_after_alloca_subr an unsigned long type. --- 3102,3108 ---- * gdb.base/ptype.exp: Likewise. * gdb.base/setvar.exp: Handle sizeof (int) != 4 for h8300. Add h8300 xfails. ! * gdb.base/return.exp: Handle float/double precision problems on the h8300. * gdb.base/funcargs.c: Explicitly make last constant argument to call_after_alloca_subr an unsigned long type. *************** Wed Mar 20 08:48:03 1996 Fred Fish * gdb.base/corefile.exp: Always regenerate the core file, since we always regenerate the coremaker program. Detect special case where registers cannot be read from core file. ! Tue Mar 19 16:52:49 1996 Fred Fish From Peter Schauer --- 3139,3151 ---- gdb.stabs/weird.exp: Remove use of compiler options "-c -o ..." since some compilers don't allow both options to be given on the same command line. Create object file and move it. ! Tue Mar 19 23:49:31 1996 Fred Fish * gdb.base/corefile.exp: Always regenerate the core file, since we always regenerate the coremaker program. Detect special case where registers cannot be read from core file. ! Tue Mar 19 16:52:49 1996 Fred Fish From Peter Schauer *************** Tue Mar 19 16:52:49 1996 Fred Fish * gdb.base/mips_pro.exp: Create mips_pro.ci to get gcc_compiled --- 3158,3164 ---- * configure: Regenerate. * gdb.base/Makefile.in (clean): Remove generated file twice-tmp.c here, rather than in distclean. ! Sun Mar 17 13:35:31 1996 Fred Fish * gdb.base/mips_pro.exp: Create mips_pro.ci to get gcc_compiled *************** Fri Mar 15 17:49:57 1996 Fred Fish (fn *** 3192,3201 **** * gdb.base/ptype.exp: Change "i*86-*-sysv4*" setup_xfail for "whatis unnamed typedef'd enum (compiler bug in IBM's xlc)" and "ptype t_char_array" to be for native cc only. ! Fri Mar 15 16:17:22 1996 Fred Fish ! * gdb.base/corefile.exp: Remove "alpha-dec-osf2*" native compiled setup_xfail for "print coremaker_bss", "print coremaker_ro", "print func2::coremaker_local", and "backtrace in corefile.exp". --- 3196,3205 ---- * gdb.base/ptype.exp: Change "i*86-*-sysv4*" setup_xfail for "whatis unnamed typedef'd enum (compiler bug in IBM's xlc)" and "ptype t_char_array" to be for native cc only. ! Fri Mar 15 16:17:22 1996 Fred Fish ! * gdb.base/corefile.exp: Remove "alpha-dec-osf2*" native compiled setup_xfail for "print coremaker_bss", "print coremaker_ro", "print func2::coremaker_local", and "backtrace in corefile.exp". *************** Sun Feb 18 11:39:12 1996 Fred Fish Changes in sync with expect: --- 3320,3326 ---- * gdb.stabs/configure.in (alpha-*-*,mips-*-*): Replace [] tests with "test" and enclose string in quotes. * gdb.stabs/configure: Rebuild ! Thu Jan 11 09:43:14 1996 Tom Tromey Changes in sync with expect: *************** Wed Jan 3 01:30:41 1996 Jeffrey A Law *** 3340,3346 **** * gdb.stabs/weird.exp: Use ${target_triplet} to determine which sed script to run. Expect failure for v_comb test on PA targets too. ! Sat Dec 30 16:09:04 1995 Fred Fish * gdb.base/corefile.exp: Remove "i*86-*-linux" xfail for --- 3344,3350 ---- * gdb.stabs/weird.exp: Use ${target_triplet} to determine which sed script to run. Expect failure for v_comb test on PA targets too. ! Sat Dec 30 16:09:04 1995 Fred Fish * gdb.base/corefile.exp: Remove "i*86-*-linux" xfail for *************** Sat Nov 25 11:03:42 1995 Fred Fish * gdb.c++/classes.exp (test_pointers_to_class_members): Add --- 3426,3432 ---- to returns as necessary, arrange for test to compile own testcase executable. * lib/gdb.exp: Changes for testsuite to compile own test cases. ! Tue Nov 21 16:15:45 1995 Fred Fish * gdb.c++/classes.exp (test_pointers_to_class_members): Add *************** Wed Oct 18 11:27:47 1995 Jeffrey A Law *** 3487,3499 **** Tue Oct 17 23:02:12 1995 Jeffrey A Law (law@cygnus.com) ! * Many files: When warning about suppressed tests due to a nonexistant test binary, avoid incrementing the warning count. Tue Oct 10 11:00:41 1995 Fred Fish * Makefile.in (TARGET_FLAGS_TO_PASS): Remove BISON. ! Sun Oct 8 04:23:14 1995 Peter Schauer (pes@regent.e-technik.tu-muenchen.de) * gdb.base/return.exp: Change xfail from "sparc-*-solaris2.*" to --- 3491,3503 ---- Tue Oct 17 23:02:12 1995 Jeffrey A Law (law@cygnus.com) ! * Many files: When warning about suppressed tests due to a nonexistant test binary, avoid incrementing the warning count. Tue Oct 10 11:00:41 1995 Fred Fish * Makefile.in (TARGET_FLAGS_TO_PASS): Remove BISON. ! Sun Oct 8 04:23:14 1995 Peter Schauer (pes@regent.e-technik.tu-muenchen.de) * gdb.base/return.exp: Change xfail from "sparc-*-solaris2.*" to *************** Sat Sep 2 06:41:26 1995 Peter Schauer *** 3599,3605 **** Sat Sep 2 00:17:31 1995 Fred Fish ! * gdb.base/callfuncs.exp (do_function_calls): Remove mips-sgi-irix* xfail for "call inferior func with struct - returns char *" and fix test so that an optional (unsigned char *) cast is --- 3603,3609 ---- Sat Sep 2 00:17:31 1995 Fred Fish ! * gdb.base/callfuncs.exp (do_function_calls): Remove mips-sgi-irix* xfail for "call inferior func with struct - returns char *" and fix test so that an optional (unsigned char *) cast is *************** Fri Sep 1 13:42:01 1995 Fred Fish ! * gdb.base/callfuncs.exp (do_function_calls): Add alpha-dec-osf2* clear_xfail for "p t_float_values2(3.14159,float_val2)" for gcc compiled test. * gdb.base/opaque.exp (setup_xfail_on_opaque_pointer): --- 3619,3625 ---- Sun Aug 27 23:35:35 1995 Fred Fish ! * gdb.base/callfuncs.exp (do_function_calls): Add alpha-dec-osf2* clear_xfail for "p t_float_values2(3.14159,float_val2)" for gcc compiled test. * gdb.base/opaque.exp (setup_xfail_on_opaque_pointer): *************** Sun Aug 27 23:35:35 1995 Fred Fish * gdb.base/callfuncs.exp: Add xfails for the powerpc. --- 3809,3815 ---- Add rs6000-*-* xfail for "up to foo in langs.exp" "up to cppsub_ in langs.exp" and "up to fsub in langs.exp" when not gcc compiled. ! Sat Aug 12 15:05:36 1995 Jeffrey A. Law * gdb.base/callfuncs.exp: Add xfails for the powerpc. *************** Mon Aug 14 09:01:59 1995 Fred Fish From ac131313@cygnus.com Sun Mar 26 22:18:00 2000 From: Andrew Cagney To: Fernando Nasser Cc: GDB Patches Subject: Re: RFA Replace gdb/TODO with issues50 Date: Sun, 26 Mar 2000 22:18:00 -0000 Message-id: <38DEFCC9.E74DC6AF@cygnus.com> References: <38DAED11.C314EA48@cygnus.com> <38DB8ABC.AED03A6B@cygnus.com> X-SW-Source: 2000-03/msg00606.html Content-length: 720 Fernando Nasser wrote: > > Andrew Cagney wrote: > > > > Hello, > > > > I'd like to propose that the file gdb/TODO be emptied and then refilled > > with a heavily edited version of: > > > > http://sourceware.cygnus.com/gdb/issues50.html > > > > To the best of my knowledge large chunks of the existing TODO file are > > either wrong or irrelevant. I think starting from scratch would be more > > useful. > > > > Can't we do the same we do with ChangeLog? Rename TODO to TODO.??? and have the issues50 become the new TODO? We may > have to do this again eventually... I'd rather see TODO as a living document where people actually delete things and over time the list becomes shorter not longer :-) Andrew >From ac131313@cygnus.com Sun Mar 26 22:29:00 2000 From: Andrew Cagney To: Jimmy Guo Cc: gdb-patches@sourceware.cygnus.com Subject: Re: regression analysis: gdb.sum postprocessing script Date: Sun, 26 Mar 2000 22:29:00 -0000 Message-id: <38DEFEB1.EB573B72@cygnus.com> References: X-SW-Source: 2000-03/msg00607.html Content-length: 910 Jimmy Guo wrote: > > Here is a Perl script I wrote to postprocess one or more gdb.sum files > and provide a complete dejagnu test outcome summary (or diff if more > than one gdb.sum files are given). It's most useful if you want to have > a complete view of regression status between two source trees and/or if > you set up your testing to run multiple passes (to see how a test point > behaves in different passes), however you can use it just on one test > run's gdb.sum file and play around with the options to get test outcome > presented in a much organized and useful way than going through the flat > gdb.sum file. I have a personal preference for keeping perl scripts out of the main GDB sources :-( Now if someone rewrote it to use either TCL, DEJAGNU or SH then I'd have to think about it again - they are required to run the testsuite. Perhaps a link/entry on the web page or ftp site. Andrew >From ac131313@cygnus.com Sun Mar 26 22:34:00 2000 From: Andrew Cagney To: James Ingham Cc: "Insight (GDB GUI)" , GDB Patches Subject: Re: RFC: More fixes to insights ln -s Date: Sun, 26 Mar 2000 22:34:00 -0000 Message-id: <38DF009B.4AC2E2ED@cygnus.com> References: <38CF37E7.AADF52CF@cygnus.com> <14543.54628.527337.770021@leda.cygnus.com> X-SW-Source: 2000-03/msg00608.html Content-length: 2889 James Ingham wrote: > > Andrew, > > I haven't really been paying that much attention to this configure > stuff of late, sorry... But now that I think of it, I am pretty sure > all these link machinations are wholly unnecessary. I munged the gdb > startup code around so that gdb will find its library files from the > build directory without using the link at all. Moreover, when you > fail at making the link gdb will still work in GUI mode. So maybe we > can just bag all this? > > However, it would be good to make sure that this is not some wierdness > in my environment that makes it work. What about others? If you > delete the gdbtcl link in your build directory, can you still run gdb > in gui mode from the gdb build directory? If this is true for others > as well, then we should just drop the extra complexity. FYI, I applied the attatched. I don't have the time to look at your environment :-( Andrew Mon Mar 27 16:26:11 2000 Andrew Cagney * Makefile.in (all-gdbtk): Check for an existing link/directory. Re-format warning message. Document that post 5.0 this can be deleted. Index: Makefile.in =================================================================== RCS file: /cvs/src/src/gdb/Makefile.in,v retrieving revision 1.14 diff -p -r1.14 Makefile.in *** Makefile.in 2000/03/20 20:38:22 1.14 --- Makefile.in 2000/03/27 06:29:37 *************** findvar.o: findvar.c $(defs_h) $(gdbcore *** 1260,1274 **** fork-child.o: fork-child.c gdb_wait.h $(defs_h) $(gdbcore_h) \ $(inferior_h) target.h terminal.h gdbthread.h gdb_string.h all-gdbtk: ! if test "$(LN_S)" = "ln -s" -a ! -d gdbtcl/images ; then \ ! echo linking ${srcdir}/gdbtk/library to gdbtcl ; \ ! $(LN_S) ${srcdir}/gdbtk/library gdbtcl ; \ ! else \ ! echo Warning: Unable to link ${srcdir}/gdbtk/library to gdbtcl. ; \ ! echo " " You will need to do a ; \ ! echo " " make install before you are able to run the GUI. ; \ ! fi clean-gdbtk: rm -f gdbtcl --- 1260,1282 ---- fork-child.o: fork-child.c gdb_wait.h $(defs_h) $(gdbcore_h) \ $(inferior_h) target.h terminal.h gdbthread.h gdb_string.h + # FIXME: cagney/2000-03-27: Post 5.0 this link code can be removed. + # It should now be possible to run GDBtk from the build directory + # without the link in place. all-gdbtk: ! @if test ! -d gdbtcl/images ; then \ ! if test "$(LN_S)" = "ln -s" ; then \ ! echo linking ${srcdir}/gdbtk/library to gdbtcl ; \ ! rm -f gdbtcl ; \ ! test ! -r gdbtcl || exit 1 ; \ ! $(LN_S) ${srcdir}/gdbtk/library gdbtcl ; \ ! else \ ! echo "Warning:" ; \ ! echo "Unable to link ${srcdir}/gdbtk/library to gdbtcl." ; \ ! echo "You will need to do a \`make install' before you are" ; \ ! echo "able to run the GUI." ; \ ! fi ; \ ! else true ; fi clean-gdbtk: rm -f gdbtcl >From ac131313@cygnus.com Sun Mar 26 22:53:00 2000 From: Andrew Cagney To: GDB Patches Subject: [PATCH] Create destdirs... Date: Sun, 26 Mar 2000 22:53:00 -0000 Message-id: <38DF0500.F897F66A@cygnus.com> X-SW-Source: 2000-03/msg00609.html Content-length: 126 FYI, I've applied the attatched. The sequence: gmake all-gdb cd gdb && gmake install install-info should work. Andrew >From ac131313@cygnus.com Sun Mar 26 22:58:00 2000 From: Andrew Cagney To: GDB Patches Subject: Re: [PATCH] Create destdirs... Date: Sun, 26 Mar 2000 22:58:00 -0000 Message-id: <38DF064A.46917D25@cygnus.com> References: <38DF0500.F897F66A@cygnus.com> X-SW-Source: 2000-03/msg00610.html Content-length: 1046 Attempt two. Andrew Cagney wrote: > > FYI, > > I've applied the attatched. The sequence: > > gmake all-gdb > cd gdb && gmake install install-info > > should work. > > Andrew Mon Mar 27 16:43:35 2000 Andrew Cagney * Makefile.in (install-only): Create $(bindir) and $(man1dir) before installing GDB. Index: Makefile.in =================================================================== RCS file: /cvs/src/src/gdb/Makefile.in,v retrieving revision 1.15 diff -p -r1.15 Makefile.in *** Makefile.in 2000/03/27 06:42:08 1.15 --- Makefile.in 2000/03/27 06:49:50 *************** install-only: $(CONFIG_INSTALL) *** 687,693 **** --- 687,695 ---- else \ true ; \ fi ; \ + $(srcdir)/../mkinstalldirs $(bindir) ; \ $(INSTALL_PROGRAM) gdb$(EXEEXT) $(bindir)/$$transformed_name$(EXEEXT) ; \ + $(srcdir)/../mkinstalldirs $(man1dir) ; \ $(INSTALL_DATA) $(srcdir)/gdb.1 $(man1dir)/$$transformed_name.1 @$(MAKE) DO=install "DODIRS=$(SUBDIRS)" $(FLAGS_TO_PASS) subdir_do >From ac131313@cygnus.com Sun Mar 26 23:35:00 2000 From: Andrew Cagney To: GDB Patches Subject: [PATCH] acconfig.h tweeks - HAVE_PTRACE_GETREGS Date: Sun, 26 Mar 2000 23:35:00 -0000 Message-id: <38DF0EDF.9927F6CC@cygnus.com> X-SW-Source: 2000-03/msg00611.html Content-length: 803 FYI, The attatched moves the #undef HAVE_PTRACE_GETREGS to (hopefully) the correct place. Andrew Mon Mar 27 17:20:25 2000 Andrew Cagney * acconfig.h: Provide default for HAVE_PTRACE_GETREGS. * config.h: Regenerate. Index: acconfig.h =================================================================== RCS file: /cvs/src/src/gdb/acconfig.h,v retrieving revision 1.1.1.5 diff -p -r1.1.1.5 acconfig.h *** acconfig.h 2000/01/06 03:06:35 1.1.1.5 --- acconfig.h 2000/03/27 07:24:20 *************** *** 84,87 **** --- 84,90 ---- #undef HAVE_STRUCT_MEMBER_SS_WIDE /* Define if defines the PTRACE_GETXFPREGS request. */ + #undef HAVE_PTRACE_GETREGS + + /* Define if defines the PTRACE_GETXFPREGS request. */ #undef HAVE_PTRACE_GETXFPREGS >From ac131313@cygnus.com Mon Mar 27 00:07:00 2000 From: Andrew Cagney To: green@redhat.com Cc: GDB Patches Subject: Re: Patch: java tests Date: Mon, 27 Mar 2000 00:07:00 -0000 Message-id: <38DF1625.5B85E8F1@cygnus.com> References: <200003050136.RAA04638@hoser.cygnus.com> X-SW-Source: 2000-03/msg00612.html Content-length: 753 Anthony, You're now the maintainer for gdb/testsuite/gdb.java so feel free to check this in. Andrew Anthony Green wrote: > > This patch enables the existing java tests, and adds infrastructure > for some real tests. > > AG > > -- > Anthony Green Red Hat > Sunnyvale, California > > 2000-03-04 Anthony Green > > * configure.in (configdirs): Add gdb.java > * gdb.java/jmisc.java: New file. > * gdb.java/jmisc.exp: New file. > * gdb.java/Makefile.in: New file. > * gdb.java/configure: Rebuilt. > * gdb.java/configure.in: New file. > * lib/java.exp: New file. >From ac131313@cygnus.com Mon Mar 27 00:39:00 2000 From: Andrew Cagney To: green@redhat.com Cc: gdb-patches@sourceware.cygnus.com, jimb@cygnus.com, tromey@cygnus.com Subject: Re: Patch: handle N_MAIN stab Date: Mon, 27 Mar 2000 00:39:00 -0000 Message-id: <38DF1DC2.17D53B85@cygnus.com> References: <200003051039.CAA04980@hoser.cygnus.com> X-SW-Source: 2000-03/msg00613.html Content-length: 7737 FYI, I think this patch slipped into limbo as it tweeks a number of files. I believe JimK identified a memory leak. For my part, I'd suggest ``main_name ()'' (or what ever) in symtab.[hc] or source.h (anyway somewhere more applicable then defs.h which as enough fluff :-). enjoy, Andrew > 2000-03-05 Anthony Green > > * defs.h (main_name): Declare. > * dbxread.c (process_one_symbol): Handle the N_MAIN stab by > setting main_name. > * blockframe.c (inside_main_func): Use main_name instead of > "main". > * symtab.c (find_main_psymtab): Ditto. > * source.c (select_source_symtab): Ditto. > * nlmread.c (nlm_symfile_read): Ditto. > * rs6000-tdep.c (skip_prologue): Ditto. > > Index: gdb//blockframe.c > =================================================================== > RCS file: /cvs/src/src/gdb/blockframe.c,v > retrieving revision 1.1.1.11 > diff -p -r1.1.1.11 blockframe.c > *** blockframe.c 1999/12/22 21:45:03 1.1.1.11 > --- blockframe.c 2000/03/05 10:20:27 > *************** inside_main_func (pc) > *** 127,133 **** > { > struct symbol *mainsym; > > ! mainsym = lookup_symbol ("main", NULL, VAR_NAMESPACE, NULL, NULL); > if (mainsym && SYMBOL_CLASS (mainsym) == LOC_BLOCK) > { > symfile_objfile->ei.main_func_lowpc = > --- 127,133 ---- > { > struct symbol *mainsym; > > ! mainsym = lookup_symbol (main_name, NULL, VAR_NAMESPACE, NULL, NULL); > if (mainsym && SYMBOL_CLASS (mainsym) == LOC_BLOCK) > { > symfile_objfile->ei.main_func_lowpc = > Index: gdb//dbxread.c > =================================================================== > RCS file: /cvs/src/src/gdb/dbxread.c,v > retrieving revision 1.1.1.10 > diff -p -r1.1.1.10 dbxread.c > *** dbxread.c 2000/01/06 03:06:36 1.1.1.10 > --- dbxread.c 2000/03/05 10:20:29 > *************** process_one_symbol (type, desc, valu, na > *** 2426,2438 **** > } > break; > > /* The following symbol types can be ignored. */ > case N_OBJ: /* Solaris 2: Object file dir and name */ > /* N_UNDF: Solaris 2: file separator mark */ > /* N_UNDF: -- we will never encounter it, since we only process one > file's symbols at once. */ > case N_ENDM: /* Solaris 2: End of module */ > - case N_MAIN: /* Name of main routine. */ > case N_ALIAS: /* SunPro F77: alias name, ignore for now. */ > break; > } > --- 2426,2442 ---- > } > break; > > + case N_MAIN: /* Name of main routine. */ > + if (name) > + main_name = xstrdup (name); > + break; > + > /* The following symbol types can be ignored. */ > case N_OBJ: /* Solaris 2: Object file dir and name */ > /* N_UNDF: Solaris 2: file separator mark */ > /* N_UNDF: -- we will never encounter it, since we only process one > file's symbols at once. */ > case N_ENDM: /* Solaris 2: End of module */ > case N_ALIAS: /* SunPro F77: alias name, ignore for now. */ > break; > } > Index: gdb//defs.h > =================================================================== > RCS file: /cvs/src/src/gdb/defs.h,v > retrieving revision 1.9 > diff -p -r1.9 defs.h > *** defs.h 2000/03/04 02:23:06 1.9 > --- defs.h 2000/03/05 10:20:30 > *************** enum gdb_rc gdb_list_thread_ids (/* outp > *** 1314,1317 **** > --- 1314,1321 ---- > > /* Switch thread and print notification. */ > #endif > + > + /* From source.c */ > + extern char *main_name; > + > #endif /* #ifndef DEFS_H */ > Index: gdb//nlmread.c > =================================================================== > RCS file: /cvs/src/src/gdb/nlmread.c,v > retrieving revision 1.1.1.4 > diff -p -r1.1.1.4 nlmread.c > *** nlmread.c 1999/08/09 21:33:43 1.1.1.4 > --- nlmread.c 2000/03/05 10:20:31 > *************** nlm_symfile_read (objfile, mainline) > *** 206,212 **** > stabsect_build_psymtabs (objfile, mainline, ".stab", > ".stabstr", ".text"); > > ! mainsym = lookup_symbol ("main", NULL, VAR_NAMESPACE, NULL, NULL); > > if (mainsym > && SYMBOL_CLASS (mainsym) == LOC_BLOCK) > --- 206,212 ---- > stabsect_build_psymtabs (objfile, mainline, ".stab", > ".stabstr", ".text"); > > ! mainsym = lookup_symbol (main_name, NULL, VAR_NAMESPACE, NULL, NULL); > > if (mainsym > && SYMBOL_CLASS (mainsym) == LOC_BLOCK) > Index: gdb//rs6000-tdep.c > =================================================================== > RCS file: /cvs/src/src/gdb/rs6000-tdep.c,v > retrieving revision 1.5 > diff -p -r1.5 rs6000-tdep.c > *** rs6000-tdep.c 2000/02/26 09:30:30 1.5 > --- rs6000-tdep.c 2000/03/05 10:20:32 > *************** skip_prologue (CORE_ADDR pc, struct rs60 > *** 573,579 **** > function as well. */ > > tmp = find_pc_misc_function (pc); > ! if (tmp >= 0 && STREQ (misc_function_vector[tmp].name, "main")) > return pc + 8; > } > } > --- 573,579 ---- > function as well. */ > > tmp = find_pc_misc_function (pc); > ! if (tmp >= 0 && STREQ (misc_function_vector[tmp].name, main_name)) > return pc + 8; > } > } > Index: gdb//source.c > =================================================================== > RCS file: /cvs/src/src/gdb/source.c,v > retrieving revision 1.1.1.12 > diff -p -r1.1.1.12 source.c > *** source.c 2000/02/03 04:14:35 1.1.1.12 > --- source.c 2000/03/05 10:20:35 > *************** static int first_line_listed; > *** 119,124 **** > --- 119,127 ---- > > static struct symtab *last_source_visited = NULL; > static int last_source_error = 0; > + > + /* The default "main" symbol. */ > + char *main_name = "main"; > > > /* Set the source file default for the "list" command to be S. > *************** select_source_symtab (s) > *** 151,159 **** > > /* Make the default place to list be the function `main' > if one exists. */ > ! if (lookup_symbol ("main", 0, VAR_NAMESPACE, 0, NULL)) > { > ! sals = decode_line_spec ("main", 1); > sal = sals.sals[0]; > free (sals.sals); > current_source_symtab = sal.symtab; > --- 154,162 ---- > > /* Make the default place to list be the function `main' > if one exists. */ > ! if (lookup_symbol (main_name, 0, VAR_NAMESPACE, 0, NULL)) > { > ! sals = decode_line_spec (main_name, 1); > sal = sals.sals[0]; > free (sals.sals); > current_source_symtab = sal.symtab; > Index: gdb//symtab.c > =================================================================== > RCS file: /cvs/src/src/gdb/symtab.c,v > retrieving revision 1.2 > diff -p -r1.2 symtab.c > *** symtab.c 2000/02/08 04:39:02 1.2 > --- symtab.c 2000/03/05 10:20:37 > *************** find_main_psymtab () > *** 1172,1178 **** > > ALL_PSYMTABS (objfile, pst) > { > ! if (lookup_partial_symbol (pst, "main", 1, VAR_NAMESPACE)) > { > return (pst); > } > --- 1172,1178 ---- > > ALL_PSYMTABS (objfile, pst) > { > ! if (lookup_partial_symbol (pst, main_name, 1, VAR_NAMESPACE)) > { > return (pst); > } > > -- > Anthony Green Red Hat > Sunnyvale, California >From ac131313@cygnus.com Mon Mar 27 02:24:00 2000 From: Andrew Cagney To: GDB Patches Subject: [PATCH] Add GDB release criteria to TODO Date: Mon, 27 Mar 2000 02:24:00 -0000 Message-id: <38DF3683.76B55769@cygnus.com> X-SW-Source: 2000-03/msg00614.html Content-length: 9755 Per, previous RFC, I've applied the attatched patch to the TODO file. Andrew Mon Mar 27 19:53:29 2000 Andrew Cagney * TODO: Update. Add criteria for next release of GDB. Index: TODO =================================================================== RCS file: /cvs/src/src/gdb/TODO,v retrieving revision 1.1.1.2 diff -p -r1.1.1.2 TODO *** TODO 1999/05/05 14:42:08 1.1.1.2 --- TODO 2000/03/27 10:21:56 *************** bug-gdb@prep.ai.mit.edu. If you would l *** 3,10 **** you should consider sending mail to the same address, to find out whether anyone else is working on it. ! General To Do List ------------------ This list is probably not up to date, and opinions vary about the importance or even desirability of some of the items. --- 3,334 ---- you should consider sending mail to the same address, to find out whether anyone else is working on it. ! ! TODO: GDB 5.0 ! ============= ! ! Here are _all_ the issues that have been raised vis-a-vis the 5.0 ! release. Also check the GDB, and other, mail archives ! ( http://sourceware.cygnus.com/ml/gdb/ ). ! ! If, however, you fix something, then feel free to tweek this file ! (deleting the problem). Just send a note to gdb-patches so that I see ! the change. ! ! The names in paren are those that might know more about the problem. ! They don't necessarily indicate the people that will fix the problem. ! ! -- ! ! GDB 5.0: Must have ------------------ + + These are things that have been identifed as must-have for this + release of GDB. + + -- + + Watch point related patches (Eli Zaretskii, Michael Snyder, ???) + + Eli writes: This doesn't include the watchpoint-related patches I sent + beginning with August or September, and mentioned them again three + weeks ago. Here again are the pointers to the relevant messages: + + Hardware breakpoints and watchpoints: patches + http://sourceware.cygnus.com/ml/gdb-patches/1999-q3/msg00173.html + + Re: Hardware breakpoints and watchpoints: patches + http://sourceware.cygnus.com/ml/gdb-patches/1999-q3/msg00204.html + + Re: Hardware breakpoints and watchpoints: patches + http://sourceware.cygnus.com/ml/gdb-patches/1999-q4/msg00200.html + + Hardware watchpoints for bitfields + http://sourceware.cygnus.com/ml/gdb-patches/1999-q4/msg00201.html + + -- + + Tom's speedups to GDB (Tom Tromey, Jim Blandy) + + I believe that there was a late breaking fix that stopped a coredump. + + http://sourceware.cygnus.com/ml/gdb-patches/2000-q1/msg00869.html + + -- + + Solaris/x86 - which? (Nick Duffek, Peter Schauer, Michael Snyder?) + + Nick D's working through patches from Michael Snyder and Peter S. + + -- + + Texinfo broken/builds (Andrew Cagney, Stan Shebs) + + Cagney probably botched a fix to a botch. + + -- + + x86 linux GDB and SIGALRM + http://sourceware.cygnus.com/ml/gdb/2000-q1/msg00803.html + + -- + + RFA: breakpoint.c: Minor output fixes for hardware watchpoints + http://sourceware.cygnus.com/ml/gdb-patches/2000-q1/msg00558.html + + During implementation of hardware watchpoints on Solaris, I noticed the + following inconsistencies in breakpoint.c output between software and + hardware breakpoints. + + -- + + GDB 5.0: Nice to have + --------------------- + + These are things that might make it in 5.0 but don't sit in the + critical path. If they miss the 5.0 cut then they definitly should + make the follow-on release. + + -- + + Generic: lin-thread cannot handle thread exit (Mark Kettenis, Michael Snyder) + http://sourceware.cygnus.com/ml/gdb/2000-q1/msg00525.html + + The thread_db assisted debugging code doesn't handle exiting threads + properly, at least in combination with glibc 2.1.3 (the framework is + there, just not the actual code). There are at least two problems + that prevent this from working. + + As an additional reference point, the pre thread_db code didn't work + either. + + -- + + Java (Anthony Green, David Taylor) + + Anthony Green has started contributing late breaking Java patches: + + Patch: java tests + http://sourceware.cygnus.com/ml/gdb-patches/2000-q1/msg00512.html + + Patch: java booleans + http://sourceware.cygnus.com/ml/gdb-patches/2000-q1/msg00515.html + + Patch: handle N_MAIN stab + http://sourceware.cygnus.com/ml/gdb-patches/2000-q1/msg00527.html + + It should be able to squeeze these in. + + -- + + Pascal (Pierre Muller, David Taylor) + + The pascal support patches nave been added to the patch data base. I + [cagney] strongly suspect that they are better suited for 5.1. + + -- + + Programs run under GDB have SIGCHLD masked. + + [I think this can be worked around by using the action command - + cagney] + + -- + + GNU/Linux/x86 and random thread signals (and Solaris/SPARC but not + Solaris/x86) + + Christopher Blizzard writes: + + So, I've done some more digging into this and it looks like Jim + Kingdon has reported this problem in the past: + + http://sourceware.cygnus.com/ml/bug-gdb/1999-10/msg00058.html + + I can reproduce this problem both with and without Tom's patch. Has + anyone seen this before? Maybe have a solution for it hanging around? + :) + + There's a test case for this documented at: + + when debugging threaded applications you get extra SIGTRAPs + http://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=9565 + + [There should be a GDB testcase - cagney] + + -- + + IRIX? + + Benjamin Gamsa wrote: + + Has anyone successfully built the latest (from cvs) gdb on IRIX6.4 or + later? The first problem I hit is that proc-api.c includes + sys/user.h, which no longer exists under IRIX6.4. If I comment out + that include, the next problem I hit is that PIOCGETPR and PIOCGETU + are no longer defined in IRIX6.4 (presumably related to the + disappearance of user.h). + + -- + + Regressions (prologue) with devel GCC. + + The current head of the GCC branch doesn't co-operate well with GDB + over debug information. + + Regressions problem (200 failures) + http://sourceware.cygnus.com/ml/gdb/2000-q1/msg00475.html + + -- + + RFA: infrun.c, breakpoint.c: Kludge for Solaris x86 hardware watchpoint support + http://sourceware.cygnus.com/ml/gdb-patches/2000-q1/msg00664.html + + Unfortunately I'd need the following kludge to work around a Solaris + x86 kernel problem with hardware watchpoint support. See the comment + in the patches for a description of the problem. + + -- + + RFD: infrun.c: No bpstat_stop_status call after proceed over break ? + http://sourceware.cygnus.com/ml/gdb-patches/2000-q1/msg00665.html + + I am currently trying to fix a GDB bug with missing watchpoint triggers + after proceeding over a breakpoint on x86 targets. + + -- + + GDB 5.0: Won't have + ------------------- + + The following are on hold until GDB 5.0 is branched. In general they + won't go in as they unsettle the GDB sources. + + -- + + ATTRIBUTE_UNUSED + + The need for this as almost been eliminated. The next version of GCC + (assuming cagney gets the revised patch approved) will be able to + supress unused parameter warnings. + + -- + + Delete macro TARGET_BYTE_ORDER_SELECTABLE. + + Patches in the database. + + -- + + Updated readline + + Readline 4.? is out. A merge wouldn't hurt. + + -- + + Purge PARAMS + + Something to do post 5.0 branch + + -- + + GDB 5.0: Test results + --------------------- + + Please include: + + o the output of `config.guess` + o the date + o the compiler + o a note mentioning the reason + for any serious failures. + + -- + + alpha-dec-osf4.0a, vendor compiler, 2000-03-04 + + Still has many compile warnings (mostly relating back to PTR vs void*) + but it did compile using: + + CC=cc .../configure + make + + Test results are: + + # of expected passes 6223 + # of unexpected failures 103 + # of unexpected successes 2 + # of expected failures 196 + # of unresolved testcases 6 + # of unsupported tests 1 + + Looking at the output it would appear that GDB is stepping into some + functions instead of ``next'' ing over them: + + 35 dummy(); + (gdb) next + dummy () at /home/cagney/GDB-DEJAGNU/src/gdb/testsuite/gdb.base/all-types.c:41 + 41 { + + Since there is no active maintainer, I'd consider this sufficient for + 5.0 :-/ + + -- + + sparc-sun-solaris2.6, egcs-2.91.66, 2000-02-10 + http://sourceware.cygnus.com/ml/gdb-testers/2000-q1/msg00030.html + + There is a SIGTRAP problem that occures in ptrace.exp (Cagney to + expand on). + + # of expected passes 6420 + # of unexpected failures 7 + # of expected failures 199 + + -- + + solaris 2.5.1 sparc?, 2.9-gnupro-99r1, 2000-02-10 + http://sourceware.cygnus.com/ml/gdb-testers/2000-q1/msg00032.html + + # of expected passes 6420 + # of unexpected failures 6 + # of expected failures 199 + + -- + + sparc-unknown-netbsdelf1.4P, egcs-1.1.2+, 2000-03-01 + + This is with a very recent kernel. + + # of expected passes 6055 + # of unexpected failures 88 + # of unexpected successes 1 + # of expected failures 190 + # of unresolved testcases 59 + + -- + + GNU/Linux PPC + http://sourceware.cygnus.com/ml/gdb/2000-q1/msg00185.html + + Kevins merged it all in. + + -- + + Unixware + + Builds ok. Problems with some of the thread code. Unfortunate but + not a show stopper. Nick D's still looking at it. + + Re: uw-threads issues + http://sourceware.cygnus.com/ml/gdb/2000-q1/msg00025.html + + + ------------------------------------------------ + + + General Wish List + ================= This list is probably not up to date, and opinions vary about the importance or even desirability of some of the items. >From phdm@macqel.be Mon Mar 27 03:22:00 2000 From: "Philippe De Muyter" To: gdb-patches@sourceware.cygnus.com (gdb-patches@sourceware.cygnus.com) Subject: PATCH/RFA: regerror link error Date: Mon, 27 Mar 2000 03:22:00 -0000 Message-id: <200003271122.NAA25753@mail.macqel.be> X-SW-Source: 2000-03/msg00615.html Content-length: 1697 I wrote : > the compilation of gdb fails on my system (m68k-motorola-sysv) : > > gcc -g -O2 -W -Wall -o gdb main.o libgdb.a ../bfd/libbfd.a ../readline > /libreadline.a ../opcodes/libopcodes.a ./../intl/libintl.a ../libiberty/libibert > y.a -lncurses -lm ../libiberty/libiberty.a > libgdb.a(command.o): In function `apropos_command': > command.c:481: undefined reference to `regerror' > collect2: ld returned 1 exit status > > Actually, I have found a __regerror, but no regerror. How can we fix that ? > Following advice from Todd Whitesel and J.T. Conklin, jtc> I think the __regerror() function in gnu-regex.c needs to be renamed jtc> regerror(). Todd> Absolutely agree. Todd> The __ should only be used (and must be used) if the file is part of a Todd> library provided with a compiler. Todd> If the file is part of our app, then we should not be defining a __ symbol Todd> because ANSI C reserves all __ symbols for the compiler's library! here is a patch : OK to commit ? Mon Mar 27 12:23:37 2000 Philippe De Muyter * gnu-regex.c (regerror): Function renamed from `__regerror'. Index: gdb/gnu-regex.c =================================================================== RCS file: /cvs/src/src/gdb/gnu-regex.c,v retrieving revision 1.1.1.5 diff -u -p -b -r1.1.1.5 gnu-regex.c --- gnu-regex.c 1999/10/12 04:37:21 1.1.1.5 +++ gnu-regex.c 2000/03/27 10:22:35 @@ -5730,7 +5730,7 @@ weak_alias (__regexec, regexec) from either regcomp or regexec. We don't use PREG here. */ size_t -__regerror (errcode, preg, errbuf, errbuf_size) +regerror (errcode, preg, errbuf, errbuf_size) int errcode; const regex_t *preg; char *errbuf; >From Peter.Schauer@regent.e-technik.tu-muenchen.de Mon Mar 27 07:36:00 2000 From: "Peter.Schauer" To: gdb-patches@sourceware.cygnus.com Subject: RFA: infcmd.c: Add `info r' alias for `info registers' Date: Mon, 27 Mar 2000 07:36:00 -0000 Message-id: <200003271536.RAA03863@reisser.regent.e-technik.tu-muenchen.de> X-SW-Source: 2000-03/msg00616.html Content-length: 973 For over ten years I have been using i r $NN to examine the contents of a register. Due to the new `info remote-process' command, `i r' is now ambigious, which really gets in the way, as I have to retype `i reg $NN' if I fall back into old habits. The following patch adds an alias and makes my life easier. 2000-03-27 Peter Schauer * infcmd.c (_initialize_infcmd): Add `info r' alias for `info registers'. --- gdb/infcmd.c.orig Thu Feb 24 13:41:44 2000 +++ gdb/infcmd.c Sat Mar 25 13:38:22 2000 @@ -1998,6 +1998,7 @@ use \"set args\" without arguments."); add_info ("registers", nofp_registers_info, "List of integer registers and their contents, for selected stack frame.\n\ Register name as argument means describe only that register."); + add_info_alias ("r", "registers", 1); if (xdb_commands) add_com ("lr", class_info, nofp_registers_info, -- Peter Schauer pes@regent.e-technik.tu-muenchen.de >From Peter.Schauer@regent.e-technik.tu-muenchen.de Mon Mar 27 07:37:00 2000 From: "Peter.Schauer" To: gdb-patches@sourceware.cygnus.com Subject: RFA: maint.c: Add `mt i' alias for `mt info' Date: Mon, 27 Mar 2000 07:37:00 -0000 Message-id: <200003271537.RAA03867@reisser.regent.e-technik.tu-muenchen.de> X-SW-Source: 2000-03/msg00617.html Content-length: 988 I have been used to issue e.g. `maint i sec'. Due to the new `maint internal-error' command, `maint i sec' is now ambigous. I could live with this, but as the top level `info' command can be abbreviated via `i', GDB should be consistent and allow the same for `mt info'. Here is a patch: 2000-03-27 Peter Schauer * maint.c (_initialize_maint_cmds): Add `mt i' alias for `mt info'. --- gdb/maint.c.orig Thu Sep 9 01:59:19 1999 +++ gdb/maint.c Sat Mar 25 20:46:19 2000 @@ -375,6 +375,7 @@ to test internal functions such as the C "Commands for showing internal info about the program being debugged.", &maintenanceinfolist, "maintenance info ", 0, &maintenancelist); + add_alias_cmd ("i", "info", class_maintenance, 1, &maintenancelist); add_cmd ("sections", class_maintenance, maintenance_info_sections, "List the BFD sections of the exec and core files.", -- Peter Schauer pes@regent.e-technik.tu-muenchen.de >From Peter.Schauer@regent.e-technik.tu-muenchen.de Mon Mar 27 07:38:00 2000 From: "Peter.Schauer" To: gdb-patches@sourceware.cygnus.com Subject: RFA: procfs.c: init_procfs_ops should set procfs_ops.to_has_[all]_memory Date: Mon, 27 Mar 2000 07:38:00 -0000 Message-id: <200003271538.RAA03884@reisser.regent.e-technik.tu-muenchen.de> X-SW-Source: 2000-03/msg00618.html Content-length: 1712 I am pretty sure that this is caused by some accidental deletion, but procfs.c:init_procfs_ops no longer sets procfs_ops.to_has_memory and procfs_ops.to_has_all_memory. I noticed it when issuing an `i target' command on Solaris with a running executable: (gdb) i target Symbols from "/home2/pes/gnu/gdb/gdbnd/solx86/gdb/testsuite/gdb.base/run". Local exec file: `/home2/pes/gnu/gdb/gdbnd/solx86/gdb/testsuite/gdb.base/run', file type elf32-i386. Entry point: 0x8048a34 0x080480f4 - 0x08048105 is .interp . . After applying the patch below I get the more familiar: (gdb) i target Symbols from "/home2/pes/gnu/gdb/gdbnd/solx86/gdb/testsuite/gdb.base/run". Unix /proc child process: Using the running image of child LWP 1 via /proc. While running this, GDB does not access memory from... Local exec file: `/home2/pes/gnu/gdb/gdbnd/solx86/gdb/testsuite/gdb.base/run', file type elf32-i386. Entry point: 0x8048a34 0x080480f4 - 0x08048105 is .interp . . 2000-03-27 Peter Schauer * procfs.c (init_procfs_ops): Set procfs_ops.to_has_memory and procfs_ops.to_has_all_memory to 1. --- gdb/procfs.c.orig Wed Mar 1 21:54:05 2000 +++ gdb/procfs.c Sun Mar 26 22:07:31 2000 @@ -154,6 +154,8 @@ init_procfs_ops () procfs_ops.to_thread_alive = procfs_thread_alive; procfs_ops.to_pid_to_str = procfs_pid_to_str; + procfs_ops.to_has_all_memory = 1; + procfs_ops.to_has_memory = 1; procfs_ops.to_has_execution = 1; procfs_ops.to_has_stack = 1; procfs_ops.to_has_registers = 1; -- Peter Schauer pes@regent.e-technik.tu-muenchen.de >From dan@cgsoftware.com Mon Mar 27 08:34:00 2000 From: dan@cgsoftware.com (Daniel Berlin+list.gdb-patches) To: gdb-patches@sourceware.cygnus.com Subject: [RFA]: New set debug patch Date: Mon, 27 Mar 2000 08:34:00 -0000 Message-id: X-SW-Source: 2000-03/msg00619.html Content-length: 282 This patch deprecates the old commands, adds the new commands, and adds documentation for the set/show debug command. Of course, the documentation needs work, but I think it's in the right place, and none of the stuff was documented before, so it's better than it was before. --Dan >From fnasser@cygnus.com Mon Mar 27 08:36:00 2000 From: Fernando Nasser To: "Peter.Schauer" Cc: gdb-patches@sourceware.cygnus.com Subject: Re: RFA: infcmd.c: Add `info r' alias for `info registers' Date: Mon, 27 Mar 2000 08:36:00 -0000 Message-id: <38DF8D48.65F10946@cygnus.com> References: <200003271536.RAA03863@reisser.regent.e-technik.tu-muenchen.de> X-SW-Source: 2000-03/msg00620.html Content-length: 416 "Peter.Schauer" wrote: > > For over ten years I have been using > i r $NN > to examine the contents of a register. Due to the new `info remote-process' > command, `i r' is now ambigious, which really gets in the way, as I have > to retype `i reg $NN' if I fall back into old habits. > I think this is a reasonable request. -- Fernando Nasser Red Hat - Toronto E-Mail: fnasser@cygnus.com >From fnasser@cygnus.com Mon Mar 27 09:46:00 2000 From: Fernando Nasser To: dan@cgsoftware.com Cc: gdb-patches@sourceware.cygnus.com Subject: Re: [RFA]: New set debug patch Date: Mon, 27 Mar 2000 09:46:00 -0000 Message-id: <38DF9E7D.9C1737D3@cygnus.com> References: X-SW-Source: 2000-03/msg00621.html Content-length: 972 "Daniel Berlin+list.gdb-patches" wrote: > > This patch deprecates the old commands, adds the new commands, and > adds documentation for the set/show debug command. > Of course, the documentation needs work, but I think it's in the right > place, and none of the stuff was documented before, so it's better > than it was before. I believe this will require more than one approval. You got mine. P.S.: An interesting case: there was a blank line too many in gdbtypes.c and you replaced it with a useful line of code. Normally we avoid formatting fixes to be mixed with the actual code changes, but I admit having to introduce a new line of code exactly there is sort of an opportunity to get things right. I will let Andrew have the final say on that. -- Fernando Nasser Red Hat - Toronto E-Mail: fnasser@cygnus.com 2323 Yonge Street, Suite #300 Tel: 416-482-2661 ext. 311 Toronto, Ontario M4P 2C9 Fax: 416-482-6299 >From fnasser@cygnus.com Mon Mar 27 11:14:00 2000 From: Fernando Nasser To: rearnsha@arm.com Cc: gdb-patches@sourceware.cygnus.com Subject: Re: ARM patch -- extra info about cpsr register Date: Mon, 27 Mar 2000 11:14:00 -0000 Message-id: <38DFB300.B82108A@cygnus.com> References: <200003131918.TAA21085@cam-mail2.cambridge.arm.com> X-SW-Source: 2000-03/msg00622.html Content-length: 1612 Hi Richard, Thanks for the submission. However, we are using something else to show register bits nowadays. It uses the REGISTER_VIRTUAL_TYPE and we build a type for the register with bitfields so normal gdb processing (and the GUI) can show the bits and allow the user to set a specific bit by name (without having to know its position by heart). I am sorting out some details and tracking down a bug in gdb before making it available. My code is for another processor but it will be very easy to adapt it for ARM. If you fell like helping, as soon as I have a final version I can point you to the right pieces of code. Hope you are not too disappointed. Best regards, Fernando Richard Earnshaw wrote: > > Time I sorted out some of my local changes... > > This patch provides a useful additional decoding of the CPSR register for > ARM ports of GDB for commands such as "info reg". It translates the > setting of the CPSR into a set of mnemonic letters representing the > settings of the various flag bits as documented in the data sheet (upper > case for set bits, lower case for clear bits) -- generally I find this > much more intelligible than the raw numbers. > > Richard Earnshaw (rearnsha@arm.com) > > * arm-tdep.c (arm_print_register_hook): New function. > * arm/tm-arm.h (PRINT_REGISTER_HOOK): Call it. > (FLAG_*): New bits in CPSR. > -- Fernando Nasser Red Hat - Toronto E-Mail: fnasser@cygnus.com 2323 Yonge Street, Suite #300 Tel: 416-482-2661 ext. 311 Toronto, Ontario M4P 2C9 Fax: 416-482-6299 >From shebs@apple.com Mon Mar 27 11:53:00 2000 From: Stan Shebs To: Chris Faylor Cc: gdb-patches@sourceware.cygnus.com Subject: Re: [PATCH] revert win32-nat.c stack handling to working version Date: Mon, 27 Mar 2000 11:53:00 -0000 Message-id: <38DFBC32.6694D52@apple.com> References: <20000324213253.A23842@cygnus.com> X-SW-Source: 2000-03/msg00623.html Content-length: 984 Chris Faylor wrote: > > I added some "functionality" to win32-nat.c a while ago while under the > mistaken impression that using the Microsoft stack-walking APIs would > somehow provide more functionality than what was previously available in > gdb. Instead, I just broke things so that stack walking stopped after a > few frames. > > The enclosed patch reverts gdb to its previous behavior and also adds an > additional unrelated trap for illegal instructions, which was missing > before (I know this should be a separate patch but...). Seems like it would be helpful to add a comment in the sources somewhere so that some future hacker won't go down the same fruitless path. When I first started hacking on GCC, I was impressed by the number of #if 0 chunks that were preceded by "you would think this would be the right thing to do, but here's why it loses", along with the explanation. You wouldn't want to do this all the time, but this case seems worth documenting. Stan >From jimb@zwingli.cygnus.com Mon Mar 27 11:53:00 2000 From: Jim Blandy To: Stephane Carrez Cc: Andrew Cagney , gdb-patches@sourceware.cygnus.com Subject: Re: path for gdb/dwarf2read.c, support 16-bit targets in dwarf-2 Date: Mon, 27 Mar 2000 11:53:00 -0000 Message-id: References: <38D4DCB0.88313CB2@worldnet.fr> <38D5B6E0.50FF6A5E@cygnus.com> <38D68C56.856CB00C@worldnet.fr> <38D74A9E.A85ED8EC@cygnus.com> <38D7E6BC.79543EBA@worldnet.fr> X-SW-Source: 2000-03/msg00624.html Content-length: 1641 I've reached the same conclusion on a project I'm doing right now. I think this test is bogus. > > Rather than diging values out of archures I think the possibility of: > > cu_header.address_size < elf-header.address_size > > should be documented as being just as legetimate (sarcasm :-) as: > > cu_header.address_size > elf-header.address_size > > and the check either replaced or removed. > > > > Andrew > > Ok, lets remove the strange test (it does not exist in bfd/dwarf2.c > nor in readelf.c...) > > Thanks, > Stephane > > 2000-03-21 Stephane Carrez > > * dwarf2read.c (dwarf2_build_psymtabs_hard): Do not check > the dwarf address size against elf address size. > --------------171FF77269274D1E5CFD870E > Content-Type: text/plain; charset=us-ascii; > name="dwarf2read.c.diff" > Content-Transfer-Encoding: 7bit > Content-Disposition: inline; > filename="dwarf2read.c.diff" > > --- /src/gnu/cygnus/gdb/gdb/dwarf2read.c Sat Mar 4 11:38:38 2000 > +++ gdb/dwarf2read.c Tue Mar 21 20:50:13 2000 > @@ -980,12 +980,6 @@ dwarf2_build_psymtabs_hard (objfile, mai > (long) (beg_of_comp_unit - dwarf_info_buffer)); > return; > } > - if (address_size < address_significant_size) > - { > - error ("Dwarf Error: bad address size (%ld) in compilation unit header (offset 0x%lx + 11).", > - (long) cu_header.addr_size, > - (long) (beg_of_comp_unit - dwarf_info_buffer)); > - } > > /* Read the abbrevs for this compilation unit into a table */ > dwarf2_read_abbrevs (abfd, cu_header.abbrev_offset); > > --------------171FF77269274D1E5CFD870E-- > > >From fnasser@cygnus.com Mon Mar 27 12:07:00 2000 From: Fernando Nasser To: Jim Blandy Cc: Stephane Carrez , Andrew Cagney , gdb-patches@sourceware.cygnus.com Subject: Re: path for gdb/dwarf2read.c, support 16-bit targets in dwarf-2 Date: Mon, 27 Mar 2000 12:07:00 -0000 Message-id: <38DFBF66.137FC0A@cygnus.com> References: <38D4DCB0.88313CB2@worldnet.fr> <38D5B6E0.50FF6A5E@cygnus.com> <38D68C56.856CB00C@worldnet.fr> <38D74A9E.A85ED8EC@cygnus.com> <38D7E6BC.79543EBA@worldnet.fr> X-SW-Source: 2000-03/msg00625.html Content-length: 466 Jim Blandy wrote: > > I've reached the same conclusion on a project I'm doing right now. I > think this test is bogus. > It seems that we have a consensus. Jim, will you do the honors and get Stephane patch in (thus removing the offending test)? -- Fernando Nasser Red Hat - Toronto E-Mail: fnasser@cygnus.com 2323 Yonge Street, Suite #300 Tel: 416-482-2661 ext. 311 Toronto, Ontario M4P 2C9 Fax: 416-482-6299 >From brolley@redhat.com Mon Mar 27 12:08:00 2000 From: Dave Brolley To: gdb-patches@sourceware.cygnus.com Subject: Patch -- Floating point conversions Date: Mon, 27 Mar 2000 12:08:00 -0000 Message-id: <38DFC097.6E397E09@redhat.com> X-SW-Source: 2000-03/msg00626.html Content-length: 395 Hi, The following patch adds floating point conversions between single and double precision to the cgen-fpu code. Ok to commit? Dave 2000-03-23 Dave Brolley * cgen-fpu.h: Rename extsfdf to fextsfdf. Rename truncdfsf to ftruncdfsf. * cgen-accfp.c (fextsfdf): New function. (ftruncdfsf): New function. (cgen_init_accurate_fpu): Initialize fextsfdf and ftruncdfsf.