Re: [PATCH v3 2/3] Add FreeBSD/mips architecture.

Luis Machado
2017-01-05T00:52:34Z

On 01/04/2017 04:10 PM, John Baldwin wrote:
> On Wednesday, January 04, 2017 03:23:00 PM Luis Machado wrote:
>> Hi,
>>
>> Did this get pushed? I thought we were waiting for Maciej to provide
>> feedback?
>
> I did not push the binutils change, only the gdb ones (they are independent).
> Between Pedro's earlier comments and yours (which I had taken as approval),
> I figured the GDB ones were fine and didn't want to keep reposting them while
> hashing out the binutils change. (I've seen some other patch series go by
> where a subset of patches were committed earlier while other patches were
> reworked.)
>

I see.

>> Also please note i only review, i don't approve. Mark Kettenis would be
>> the one to approve native FreeBSD bits (if the MAINTAINERS file is still
>> up-to-date).
>>
>> Or maybe that has changed? If so, the MAINTAINERS file needs to be updated.
>
> Hmm, I misinterpreted your comments as approval then. Most of my recent
> FreeBSD changes have been approved by Pedro Alves.
>

I apologize if i haven't been clear. I tend to remind people about
waiting for formal approval here and there, but not on every review.