From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 2z/AI5OjXGAlKQAAWB0awg (envelope-from ) for ; Thu, 25 Mar 2021 10:52:03 -0400 Received: by simark.ca (Postfix, from userid 112) id 84A991EF7C; Thu, 25 Mar 2021 10:52:03 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 8625A1EF5D for ; Thu, 25 Mar 2021 10:52:02 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 136203858022; Thu, 25 Mar 2021 14:52:02 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 136203858022 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1616683922; bh=oRfSDXzLaetMd2q6eTZy/qbOeTtiwj+0eWrxtHZPTms=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=xxxwPLVDqqb5JcvFG7aFJPwMY0gZxFfwRgOjj7pE4sKQtqdRnnDqQISvYbiE0GTca qYdgPip4XnpIulfo/4+UoOts4dQl+LVoYtpNz9YxjM74yGjvVhebufQAQyh75BYOIh UhZDMsDZUK4b6sFpb5f+tm9QT5Sjc6cqzejJ5PX4= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 278043858022 for ; Thu, 25 Mar 2021 14:52:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 278043858022 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 12PEonKX017524 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 25 Mar 2021 10:50:54 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 12PEonKX017524 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 419491EF5D; Thu, 25 Mar 2021 10:50:49 -0400 (EDT) Subject: Re: [PATCH] [PR gdb/27614] gdb-add-index fails on symlinks. To: Lancelot SIX , Andreas Schwab References: <20210325004358.31291-1-lsix@lancelotsix.com> <87eeg3k30x.fsf@igel.home> <20210325142703.GA9731@gwenhwyvar> Message-ID: <1ff9524a-9d9d-4a30-1e0d-7712ea10dab5@polymtl.ca> Date: Thu, 25 Mar 2021 10:50:49 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210325142703.GA9731@gwenhwyvar> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Thu, 25 Mar 2021 14:50:49 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Cc: Lancelot SIX via Gdb-patches Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 2021-03-25 10:27 a.m., Lancelot SIX via Gdb-patches wrote: > On Thu, Mar 25, 2021 at 10:15:26AM +0100, Andreas Schwab wrote: >> On Mär 25 2021, Lancelot SIX via Gdb-patches wrote: >> >>> +if test -L "$1"; then >>> + # This script will most likely fail if the argument is a symlink to a >>> + # program. In order to avoid that, try to follow the symlink. However, >>> + # readlink is not a standard POSIX tool so we have to check if it is >>> + # available. >>> + if command -v readlink &>/dev/null; then >> >> &> isn't standard shell. > > Thanks for spotting it. I’ll change it to '2>&1 >/dev/null'. In my experience, shellcheck is very good at spotting these non-standard things (and much more). It could be worth making the file shellcheck-clean and ensure it stays that way. Simon