From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id tTxAOPx3gmMiLB0AWB0awg (envelope-from ) for ; Sat, 26 Nov 2022 15:33:00 -0500 Received: by simark.ca (Postfix, from userid 112) id D7F321E11E; Sat, 26 Nov 2022 15:33:00 -0500 (EST) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=UXBkbuh8; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A, RCVD_IN_DNSWL_MED,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 8C1171E112 for ; Sat, 26 Nov 2022 15:33:00 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1D91B3852207 for ; Sat, 26 Nov 2022 20:33:00 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1D91B3852207 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1669494780; bh=ksma2tFH2mGWgiYQ6bHOI4aLkn7QAZZNbSUig/wZvbY=; h=Date:Subject:To:Cc:References:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=UXBkbuh8NNXCt9nRZOhI4U4qa1MziolhhGsyoXn3OgAKWzEyBnoWO5pFPZRg4UxQn wNUuBaQkcCuAW5dh7sTEEQqtooAbp9lU+MgJhJC/2DS89NHEm64MN39Lw8HfJkYyz6 OV+gZdySmt9PajmEKUA1lBEl24KuNZHzQPXnTe7Q= Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 981843858296 for ; Sat, 26 Nov 2022 20:32:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 981843858296 Received: from [10.0.0.11] (unknown [217.28.27.60]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 1B4C91E112; Sat, 26 Nov 2022 15:32:40 -0500 (EST) Message-ID: <1ff352e2-7e07-a818-01ff-3004142a1eef@simark.ca> Date: Sat, 26 Nov 2022 15:32:40 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH] Remove reset_ecs Content-Language: en-US To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20221121175830.3585569-1-tom@tromey.com> <102b6335-e33d-ffc0-b7a5-fd79d4cf26af@simark.ca> <87edtqbhx7.fsf@tromey.com> In-Reply-To: <87edtqbhx7.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" > diff --git a/gdb/infrun.c b/gdb/infrun.c > index 96346e1f25b..248b71a053b 100644 > --- a/gdb/infrun.c > +++ b/gdb/infrun.c > @@ -1854,55 +1854,33 @@ displaced_step_finish (thread_info *event_thread, enum gdb_signal signal) > discarded between events. */ > struct execution_control_state > { > - execution_control_state () > + explicit execution_control_state (thread_info *thr = nullptr) > + : ptid (thr == nullptr ? null_ptid : thr->ptid), > + event_thread (thr), > + ws (target_waitstatus ()) Not sure, but I feel like setting ws like this is unnecessary. It will be default-constructed the same way if we specify nothing, I believe. In any case: Approved-By: Simon Marchi Simon