From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 79461 invoked by alias); 2 Feb 2017 17:45:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 79443 invoked by uid 89); 2 Feb 2017 17:45:01 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=no version=3.3.2 spammy=tense, 109,10, H*f:sk:e08d9eb, 10910 X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 02 Feb 2017 17:44:58 +0000 Received: by simark.ca (Postfix, from userid 33) id 422ED1E163; Thu, 2 Feb 2017 12:44:57 -0500 (EST) To: Pedro Alves Subject: Re: [PATCH] Move "tee" building down to interpreter::set_logging_proc X-PHP-Originating-Script: 33:rcube.php MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 02 Feb 2017 17:45:00 -0000 From: Simon Marchi Cc: gdb-patches@sourceware.org In-Reply-To: References: <1486045694-22866-1-git-send-email-palves@redhat.com> Message-ID: <1fc904d1eef0f26d27539a2b2b4da5ab@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.2.3 X-IsSubscribed: yes X-SW-Source: 2017-02/txt/msg00073.txt.bz2 On 2017-02-02 12:39, Pedro Alves wrote: > On 02/02/2017 03:17 PM, Simon Marchi wrote: >> On 2017-02-02 09:28, Pedro Alves wrote: >>> @@ -109,13 +109,13 @@ extern int current_interp_named_p (const char >>> *name); >>> >>> /* Call this function to give the current interpreter an opportunity >>> to do any special handling of streams when logging is enabled or >>> - disabled. START_LOG is 1 when logging is starting, 0 when it >>> ends, >>> - and OUT is the stream for the log file; it will be NULL when >>> - logging is ending. LOGFILE is non-NULL if the output streams >>> + disabled. START_LOG is true when logging is starting, false when >> >> START_LOG is not there anymore. From what I understand, it's replaced >> with LOGFILE being null or not? > > You're right. How about this: > > -- i/gdb/interps.h > +++ w/gdb/interps.h > @@ -109,10 +109,10 @@ extern int current_interp_named_p (const char > *name); > > /* Call this function to give the current interpreter an opportunity > to do any special handling of streams when logging is enabled or > - disabled. START_LOG is true when logging is starting, false when > - it ends. LOGFILE is the stream for the log file; it's NULL when > - logging is ending. LOGGING_REDIRECT is false if the output streams > - are to be tees, with the log file as one of the outputs. */ > + disabled. LOGFILE is the stream for the log file when logging is > + starting and is NULL when logging is ending. LOGGING_REDIRECT is > + false if the output streams are to be tees, with the log file as > + one of the outputs. */ > > extern void current_interp_set_logging (ui_file_up logfile, > bool logging_redirect); > > > OK? Yeah sounds good. Though the pre-existing sentence "...if the output streams are to be tees" is not that clear to me, I'm not sure I would understand if I didn't already know what the function does. Why does it talk about multiple output streams that have to be tees, isn't there only one tee? Or is it meant to be a past tense verb, in which case it should be something like "...are to be tee-ed"? I just find the formulation awkward.