Re: [PATCH] gdb: pass inferior argument to inf_child_target::maybe_unpush_target

[Simon Marchi <simark@simark.ca>]

On 2026-05-12 11:45, Andrew Burgess wrote:
> @@ -2594,9 +2594,9 @@ procfs_target::mourn_inferior ()
>  	destroy_procinfo (pi);
>      }
>  
> +  inferior *inf = current_inferior ();
>    generic_mourn_inferior ();
> -
> -  maybe_unpush_target ();
> +  maybe_unpush_target (inf);

You wrote it this particular way because generic_mourn_inferior could
switch inferior, as you explained in your commit message.  I think it
would deserve a comment at all these spots to explain that we capture
the current inferior before "generic_mourn_inferior", because that
function can switch the current inferior.  Otherwise, it would be very
easy for someone (like me) to "optimize out" the temporary variable
without realizing the behavior change.

Otherwise I think it's fine, one little baby steps towards using less
"current inferior" everywhere.

Simon