Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: "Maciej W. Rozycki" <macro@imgtec.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Restore the order of file lists in features/Makefile
Date: Tue, 08 Nov 2016 14:55:00 -0000	[thread overview]
Message-ID: <1f5b0d24-b6df-c432-b216-8e624d99975f@redhat.com> (raw)
In-Reply-To: <794ebe50-9058-1df7-24d6-25c0e8fdb8ec@redhat.com>

On 11/08/2016 02:48 PM, Pedro Alves wrote:
> On 10/28/2016 03:52 PM, Maciej W. Rozycki wrote:
>>  # Record which registers should be sent to GDB by default after stop.
>>  aarch64-expedite = x29,sp,pc
>> +amd64-expedite = rbp,rsp,rip
>>  arm-expedite = r11,sp,pc
>>  i386-expedite = ebp,esp,eip
>> -amd64-expedite = rbp,rsp,rip
>> -x32-expedite = rbp,rsp,rip
>> -mips-expedite = r29,pc
> 
> ...
> 
>> +tic6x-c64x-linux-expedite = A15,PC
>> +tic6x-c64xp-expedite = A15,PC
>> +tic6x-c64xp-linux-expedite = A15,PC
>> +x32-expedite = rbp,rsp,rip
>>  
> 
> It's a bit of a shame that amd64, i386 and x32 get split up.
> And they'll get further and further away as we add more entries.
> 
> How bad would it look if we said it's "mostly" sorted?  E.g.,
> 
> # Record which registers should be sent to GDB by default after
> # stop.  Mostly alpha-sorted, except when it makes sense to group
> # architectures.
> 
> amd64-expedite = rbp,rsp,rip
> i386-expedite = ebp,esp,eip
> x32-expedite = rbp,rsp,rip
> 
> aarch64-expedite = x29,sp,pc
> arm-expedite = r11,sp,pc
> ...

Hmmm, the rs6000/ entries have an explicit dir name:

rs6000/powerpc-cell32l-expedite = r1,pc,r0,orig_r3,r4
rs6000/powerpc-cell64l-expedite = r1,pc,r0,orig_r3,r4

Maybe all we need is to prefix the x86 ones with i386/ ?

i386/amd64-expedite = rbp,rsp,rip
i386/i386-expedite = ebp,esp,eip
i386/x32-expedite = rbp,rsp,rip

I don't know if that works.  I see that that prefix was actually
there recently, and it was removed by 414c838a722e recently.

Thanks,
Pedro Alves


      reply	other threads:[~2016-11-08 14:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-28 14:53 Maciej W. Rozycki
2016-11-08  8:49 ` [PING][PATCH] " Maciej W. Rozycki
2016-11-08 13:23   ` Simon Marchi
2016-11-08 14:37 ` [PATCH] " Yao Qi
2016-11-08 14:48 ` Pedro Alves
2016-11-08 14:55   ` Pedro Alves [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1f5b0d24-b6df-c432-b216-8e624d99975f@redhat.com \
    --to=palves@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=macro@imgtec.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox