From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id kxfeL08Thmk5SSwAWB0awg (envelope-from ) for ; Fri, 06 Feb 2026 11:14:07 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=AUBvtOaB; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id A37181E08D; Fri, 06 Feb 2026 11:14:07 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED,RDNS_NONE autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (unknown [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 222E71E08D for ; Fri, 06 Feb 2026 11:14:07 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 9C01043796FC for ; Fri, 6 Feb 2026 16:14:06 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9C01043796FC Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=AUBvtOaB Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 477CC4CF309E for ; Fri, 6 Feb 2026 16:13:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 477CC4CF309E Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 477CC4CF309E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1770394421; cv=none; b=Ii5qDSCsGporJnbJakJEDOVM0nxp/vgIntq883OdsNR2XNqNna0LcrcUo2q15RGVRcKGbcD0zpXjzvquIBGvyyDvPYrwi32Xba0jEJRubbVTcRcalqxRbXAVD5GChjWAo20C1buGH25Utyk8EwwVWg8UKHch/J/CqA4LdtnAjbc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1770394421; c=relaxed/simple; bh=8Zw6T9rtrm1EHGjlyIKoqIKZ8wJuSiAgjDEuAVaxaFM=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=pFoMhB0271pRxd01E7ivlVGfPkKB8rJ3uA9eeHImN1vOhklsNSYtF6x0sFfcKa1+rvHZAEEtwkA8BYLbrAfqjrRDZX/BCTce2WiVvpm/u+qJG2r7iLAwFmYicrMAMuUKGQbUGvHRJAuWJGKq6R7v1XDswHb5n0TTFnNX6hB2AAE= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 477CC4CF309E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770394420; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=verS5r5IfJga2iudWzbc8s7TCavm9Er0WnSJ0oijPXE=; b=AUBvtOaBiyZSJxBfVVM1nVJmD6l0O3wo3dxZRtgF2i87TfVCwzxzfZSuGX1Ust/U7PPbdF ZAOrQJ35eWyABJ4ERREf+ZzpQo4/aX7sDgjMoQAKOjOdEMgIYHTxm/AfWH6B077ZYXF6wP bdEEqa+mNM0bYR254ptno1Wa1U5IcVY= Received: from mail-yw1-f198.google.com (mail-yw1-f198.google.com [209.85.128.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-616-d6nMgjL7NEq6MfXubhrcGg-1; Fri, 06 Feb 2026 11:13:39 -0500 X-MC-Unique: d6nMgjL7NEq6MfXubhrcGg-1 X-Mimecast-MFC-AGG-ID: d6nMgjL7NEq6MfXubhrcGg_1770394419 Received: by mail-yw1-f198.google.com with SMTP id 00721157ae682-794f200bfa1so40016607b3.2 for ; Fri, 06 Feb 2026 08:13:39 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770394418; x=1770999218; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=verS5r5IfJga2iudWzbc8s7TCavm9Er0WnSJ0oijPXE=; b=ihqV6iQCtJGduXJCg9jJxpDNA9oh9QYX+MkXh8e+T41OWcEwp0DOivvJb5s3bciiRh pT0/kvwVMhR+iQnHc6dZZukQR3A+9NUK3RksgGo9yMWIJud1B/xvq1rrKSvu1cnk/ytt +5pkSI5ECr/F6RbIO1u13SJo9Y7uMZZMkj26q1OBWVRIqBky4DS1CHY+toX6ig2/j521 EUgCtchIvetavTxHUK/5bq2m3SCO9DUKanOCPmB/KXe6ZsMDIrCoBRqLwJ6baX7uCr3X LgOBw4QSrFppBjBIR8rGpNHfPnevC4dhmpFAcH0GbCeRqPHn+sMBeLj+hqvAKiD1iOiW +MTA== X-Forwarded-Encrypted: i=1; AJvYcCVGCX8PEB8vbO4al4FHzq0WmVNttv5jk8Yz6m5Ex4X8wskZ7lWTenifJfQNbqpPujqCurU2PPFjsbA5Yw==@sourceware.org X-Gm-Message-State: AOJu0YxE73KxBOnkeBIWISRbjSGW+2ZN/5IaG5RWQT/ZPKCnlMYRE3bk 57r5Qw3QnO472ufM0BCWfmGH1oX24iwbDhl1vY1oyrCwBKgypSGQXP+atf8u87qr8aI1qOpHohH QMkSOR2o3hUc7VuiuvsrOqW8HdYZWUArfnv0D490asZhWuF1PBRpGW3XVmTgTprA= X-Gm-Gg: AZuq6aLao8yPi/5r1HCqpmC1Q/GDDg+mCJiBaK7kSQuvzsVNfjJXV62Uu8yMoBouQG+ FjuWm7pncnuKOW2+4sTWbU5dKoAvLRCtsKQcX/l+2XqeoD54dWMBH5YJA7E+ei9eHemX8L7axpX Ly+PNzuD5Spwl+WP3D1dbnmy/6iTEl6Z7OiwJ28Z4oCAbFzrWpA5yQvBv1IeI7yKsrTt9FCkXqy IcV4gRT7Y2cru7vSvabM7eB+R17Yj7+Qr0JxXYhF6pPFZ58MykYtjferVsx3/lC8dltXrcEczEo 81yeKNRqTfUk9tMjzS6yqeCOWTubD0pjbA+WCD9RtgmbouVq12sKF5Fhv6iap+5s+rPGNWpzyEU ehDXPEz7Y9mA6wc/qB6hY1Q== X-Received: by 2002:a05:690c:4510:b0:794:bd20:ea06 with SMTP id 00721157ae682-7952aa90f51mr32211447b3.21.1770394418599; Fri, 06 Feb 2026 08:13:38 -0800 (PST) X-Received: by 2002:a05:690c:4510:b0:794:bd20:ea06 with SMTP id 00721157ae682-7952aa90f51mr32211197b3.21.1770394418246; Fri, 06 Feb 2026 08:13:38 -0800 (PST) Received: from ?IPV6:2804:14d:8084:a5b1::1002? ([2804:14d:8084:a5b1::1002]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7952a013c01sm25100527b3.12.2026.02.06.08.13.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Feb 2026 08:13:37 -0800 (PST) Message-ID: <1f3fdbb5-1716-404f-abd5-da0858939bf4@redhat.com> Date: Fri, 6 Feb 2026 13:13:35 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] gdb/block: add assert in block_iterator::compunit_symtab To: simon.marchi@polymtl.ca, gdb-patches@sourceware.org Cc: Simon Marchi References: <20260206025238.3467043-1-simon.marchi@polymtl.ca> <20260206025238.3467043-2-simon.marchi@polymtl.ca> From: Guinevere Larsen In-Reply-To: <20260206025238.3467043-2-simon.marchi@polymtl.ca> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: eVkryAc_RzTEM4Gis03f34nLm9CpRDXBhyQez-X3S4Q_1770394419 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2/5/26 11:52 PM, simon.marchi@polymtl.ca wrote: > From: Simon Marchi > > Verify that the compunit is only accessed when the iterator is in the > mode where that field makes sense. > > We could also set compunit_symtab_ even in "single block" mode, it > wouldn't hurt, but it would not be useful either. > > Change-Id: I237db16bb485148f9e906b2e7238159e9f0a8585 Same as the previous patch Tested-By: Guinevere Larsen > --- > gdb/block.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/gdb/block.c b/gdb/block.c > index 5aa58545393b..730e4580a5b7 100644 > --- a/gdb/block.c > +++ b/gdb/block.c > @@ -442,6 +442,10 @@ initialize_block_iterator (const struct block *block, > compunit_symtab * > block_iterator::compunit_symtab () const > { > + /* The compunit field is only used when iterating over global or static > + blocks. */ > + gdb_assert (this->which != FIRST_LOCAL_BLOCK); > + > if (this->idx == -1) > return this->compunit_symtab_; > -- Cheers, Guinevere Larsen It/she