From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id cRffCc5sEmmI/TMAWB0awg (envelope-from ) for ; Mon, 10 Nov 2025 17:53:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1762815182; bh=aYmwXFswdut4EjDgJPX0EDnYd9gyEgmmGReofSryYPQ=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=ucTns7lxSBuhYc3tnznPIbi99USR5Z7V2UnlSTT4CRehSMFbRbaI/qRzXHx2O7tbe DIldsxohgIF4cA64xMCubkt8tCuzCTy3fibb4vwrugFsJNn7fLzGjnJcOT+VVn/qRb 9TuOzPcMvDckfO07FO2dY1lQ1zrq6EZ3teTGEkeA= Received: by simark.ca (Postfix, from userid 112) id 187641E0B8; Mon, 10 Nov 2025 17:53:02 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=Zdxj1Zek; dkim-atps=neutral Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 431A31E04C for ; Mon, 10 Nov 2025 17:53:01 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id DB7113858C54 for ; Mon, 10 Nov 2025 22:53:00 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DB7113858C54 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=Zdxj1Zek Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 788FB3858C31; Mon, 10 Nov 2025 22:51:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 788FB3858C31 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 788FB3858C31 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1762815105; cv=none; b=m+qgIDTokeGbpfJE4YmM6cF07/r4gzNqXJ/oQfHAcn5eeXHKm1MX+srXC1xc0UoMnAudlyGs9kip5x7Wr7lNLa8TL1HBazLS0MNQ+Y1/bKXbS4gjjJwpp2+TaVoEdu40PYyS1ePjERIarWNKG3WQAoQri0H0fOcTWVwZWGgANQY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1762815105; c=relaxed/simple; bh=aYmwXFswdut4EjDgJPX0EDnYd9gyEgmmGReofSryYPQ=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=dPpr0zwhgd0V2aNvM1VZn0SiixppoD3NHsfsAE62NMHi4ZvEpJrWPCg4GqbLm1SJ34VsQMg6aJsVBVMotMm2QvxDlbRH4Bd337D2H2HzkIoAEJFjvHIl0Gx+VuWfmMxeOU987BVU55fiPkGmXmcaru3VCHIv2Ca/13bh/5NCMk0= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 788FB3858C31 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1762815105; bh=aYmwXFswdut4EjDgJPX0EDnYd9gyEgmmGReofSryYPQ=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Zdxj1ZeklVfImu6JiamR2iedLz4QQlgqjnrXncfd7EoHjdk+6SJK1dxUiGcjHGuIC SzRhGrSrXCG10Kv2zJ+XgrchsFasTmyHQ2xngL+T6Rfkax3G3W528ClKtraqYVWLYj I1L8HccNUxYmqfW7bKNZaLI8iegVMRQwYJ3mJ4+g= Received: by simark.ca (Postfix) id C767E1E04C; Mon, 10 Nov 2025 17:51:44 -0500 (EST) Message-ID: <1f2edf48-ac23-4366-bbbc-aacdcd1582ba@simark.ca> Date: Mon, 10 Nov 2025 17:51:44 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] gdb/hppa: guess g packet size To: Sven Schnelle Cc: gdb-patches@sourceware.org, Helge Deller , John David Anglin , binutils@sourceware.org References: <20251110210717.152087-1-svens@stackframe.org> <87zf8th8s7.fsf@stackframe.org> <08dd0dbb-b105-4039-b81e-4569b3a44065@simark.ca> <87v7jhh8id.fsf@stackframe.org> Content-Language: en-US From: Simon Marchi In-Reply-To: <87v7jhh8id.fsf@stackframe.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2025-11-10 16:39, Sven Schnelle wrote: > Simon Marchi writes: > >> On 11/10/25 4:34 PM, Sven Schnelle wrote: >>> Simon Marchi writes: >>> >>>>> + warning (_("target returned a target description this gdb doesn't " >>>>> + "support for the HP/PA architecture")); >>>> >>>> Good idea to put out a warning. I would suggesting some minor changes >>>> to the message: >>>> >>>> warning (_("The target returned a target description but this gdb " >>>> "doesn't support target descriptions for the HP/PA >>>> "architecture")); >>>> >>>> Just thinking out loud: it would actually be nice to have this warning >>>> for all architectures that don't support target descriptions, if there >>>> was a way to put it at a single common place. >>>> >>>> Other than that, the patch looks fine. >>>> >>>> Approved-By: Simon Marchi >>>> >>>> Do you have push access or would you like me to push the patch on your >>>> behalf (with the modification proposed above)? >>> >>> I don't have push acess - would appreciate if you could adjust the >>> message and push it. >> >> Done, thanks. I even extended the message to: >> >> warning (_("The target returned a target description but this GDB " >> "doesn't support target descriptions for the HP/PA" >> "architecture. Assuming standard 32-bit register" >> "layout.")); > > Thanks! One nit pick - I think there's a superfluous whitespace before > 'Assuming standard 32-bit...' The GNU standard calls for two spaces after a period (in comments as well). Simon