From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 119195 invoked by alias); 6 Apr 2017 14:38:52 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 117493 invoked by uid 89); 6 Apr 2017 14:38:51 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 spammy= X-HELO: mail-wr0-f171.google.com Received: from mail-wr0-f171.google.com (HELO mail-wr0-f171.google.com) (209.85.128.171) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 06 Apr 2017 14:38:50 +0000 Received: by mail-wr0-f171.google.com with SMTP id o21so37453787wrb.2 for ; Thu, 06 Apr 2017 07:38:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=K6wK46B+PVZaKS3GM+lOeOR0iMk/bZNSk0QfhT52TuI=; b=GJWrJ9LE679DBmGWf9Qw1DczFpDfPaZOeBi9YCiI1kZCTKMEHzc1flwMSYdZTYG+UL y4FmQzx6M92qurlArWTrBoyeIcr5enyghhj0qcnnpv+AsTpVcE60W9XNXI+chgMkfNLu ts5tcp3RCQvHbMuV1iZgCo942tlNbBCOeB6+a7jdO6KfgyLhVgvKnzeSZSyciH0suTmK l60Bouur/OtnH2PXoQ4/2pQSRh5lH1i4ip/u8LJ6DzitFV9t1LWVnUQ8njhZQKrOQ72+ StfTSCByaKkhpWkyv9rJVCD3gkTkDtSRMD2RTs6mCsU+IAS4GpU/Uc1DhRbnEQjPOs29 555w== X-Gm-Message-State: AFeK/H0N7PofOW5yled6LaG+nuOtHGilJoiFkMN/e39JEc5rmwnvTSpf 8Tu2iaUetb4ttN7Z X-Received: by 10.28.59.8 with SMTP id i8mr24131525wma.27.1491489530182; Thu, 06 Apr 2017 07:38:50 -0700 (PDT) Received: from [192.168.0.101] ([37.189.166.198]) by smtp.gmail.com with ESMTPSA id b66sm2394283wrd.29.2017.04.06.07.38.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 06 Apr 2017 07:38:49 -0700 (PDT) Subject: Re: [PATCH 2/2] Class-ify ptid_t To: Simon Marchi References: <20170404183235.10589-1-simon.marchi@ericsson.com> <20170404183235.10589-2-simon.marchi@ericsson.com> <580e9a8a-d59b-095c-cf56-ee2f50fe46df@redhat.com> <84b33a5c655af3f344494c9e9ee473d6@polymtl.ca> <03bc3933d454f9fa01567a0e1000e201@polymtl.ca> <5c5e486c-54b1-31d7-887c-c3e92e667e6d@redhat.com> <602b8c1244e73bbcb583bb29eb48f874@polymtl.ca> Cc: Simon Marchi , gdb-patches@sourceware.org From: Pedro Alves Message-ID: <1f2deb3c-6664-5916-a975-5b9ced33c4e1@redhat.com> Date: Thu, 06 Apr 2017 14:38:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <602b8c1244e73bbcb583bb29eb48f874@polymtl.ca> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-04/txt/msg00144.txt.bz2 On 04/06/2017 03:31 PM, Simon Marchi wrote: > On 2017-04-06 07:12, Pedro Alves wrote: >> Or leave it in ptid.c, doesn't have to be in a separate file. >> Putting it in the .c file instead of the .h has the advantage >> that it doesn't expose type_traits.h to all of gdb, that's all. >> (Though I'm not sure whether be able to avoid it as we grow more >> C++ utilities.) > > My intention was to put the tests in unittests/ptid-selftests.c, any > objection to that? No. Thanks, Pedro Alves