From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 85122 invoked by alias); 8 Nov 2017 16:20:22 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 84187 invoked by uid 89); 8 Nov 2017 16:20:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1019 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 08 Nov 2017 16:20:19 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id BF77CC04AC4F for ; Wed, 8 Nov 2017 16:20:18 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 273F95EE02; Wed, 8 Nov 2017 16:20:17 +0000 (UTC) Subject: Re: [PATCH 30/40] Use search_domain::FUNCTIONS_DOMAIN when setting breakpoints To: Keith Seitz , gdb-patches@sourceware.org References: <1496406158-12663-1-git-send-email-palves@redhat.com> <1496406158-12663-31-git-send-email-palves@redhat.com> <9b79fadc-9ad9-0b02-14c3-b63ff3803396@redhat.com> From: Pedro Alves Message-ID: <1f225b35-beb7-653b-7b23-00ef6d5adf66@redhat.com> Date: Wed, 08 Nov 2017 16:20:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <9b79fadc-9ad9-0b02-14c3-b63ff3803396@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-11/txt/msg00181.txt.bz2 On 08/08/2017 10:07 PM, Keith Seitz wrote: > On 06/02/2017 05:22 AM, Pedro Alves wrote: > >> however, we're currently passing down search_domain::ALL_DOMAIN when >> we know we're looking for functions, for no good reason. This patch >> fixes that. > > I have a similar patch on the compile branch. That one I had no idea... :-P > >> gdb/ChangeLog: >> yyyy-mm-dd Pedro Alves >> >> * linespec.c (iterate_over_all_matching_symtabs): Add >> search_domain parameter. Pass it down to expand_symtabs_matching. >> (decode_objc): Request FUNCTIONS_DOMAIN symbols only. >> (lookup_prefix_sym): Adjust by passing ALL_DOMAIN as >> search_domain. >> (add_all_symbol_names_from_pspace): Add search_domain parameter. >> Pass it down. >> (find_method, find_function_symbols): Request FUNCTIONS_DOMAIN >> symbols. >> (add_matching_symbols_to_info): Add search_domain parameter. Pass >> it down. > > LGTM Thanks, pushed. Pedro Alves