From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id OEvRLehoCGiQzgAAWB0awg (envelope-from ) for ; Wed, 23 Apr 2025 00:13:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1745381608; bh=gHnqUeMcirprPaPxLl0BFDD+XKv7FeFQMuO4DzgJzb8=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=wj7VptARkK3mhCYk35NR8BFbpuRt9gFxPSgTHA7pteOHYP6tI+VE8/XHnTVTgT/lZ OYuW5nxXnip8UcX8T8RDKeI35ghDI0TOqE8iMejd2kiEA3fUUhOY7FG8m3mkV089nN nj03AmFVOgJzov2/M6c1+rAHOhqx31ZbyEybqN/M= Received: by simark.ca (Postfix, from userid 112) id B88BE1E0C3; Wed, 23 Apr 2025 00:13:28 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.1 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=Vydgptax; dkim=pass (1024-bit key) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=nZcQ63Ep; dkim-atps=neutral Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 1B53C1E05C for ; Wed, 23 Apr 2025 00:13:28 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C04023857BA7 for ; Wed, 23 Apr 2025 04:13:27 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C04023857BA7 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=Vydgptax; dkim=pass (1024-bit key) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=nZcQ63Ep Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id C389C3857C7B for ; Wed, 23 Apr 2025 04:12:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C389C3857C7B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C389C3857C7B Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1745381573; cv=none; b=hcLj3XVmfXzy59SFDMBle9VLs/IfT1eycZKA9QfJR6qVJm2hFHURhD23i8SQs/xZnsPyAgHiiIrkzJjIKviyycKsi7rcpPgMJrVN406N2uNdmbhg3a/VVcM6pzNrGU1M3dQEAQ2ynjArUk8d1P4+WVn/bROl3RCkvWnQVFbVjNY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1745381573; c=relaxed/simple; bh=gHnqUeMcirprPaPxLl0BFDD+XKv7FeFQMuO4DzgJzb8=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:MIME-Version: Subject:To:From; b=cw1XU54ZjVwnVJEnmrECz03TKzMh+L33Kne0fWccfEEnMbHN3AA/zqllrpShZd3gHO32e2XGuQ3EidiPSGjmQ2Z6g65URXGpuXCQGg6fuxYAiCg4kPkHIVJBlkNiJMccYA6IKfaazi+StQQrneyDKeA5UnwiH+BAIoUzhURveyc= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C389C3857C7B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1745381573; bh=gHnqUeMcirprPaPxLl0BFDD+XKv7FeFQMuO4DzgJzb8=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=VydgptaxplpCZosQg0LhxrBY3V5dZ+PkeJ5BsymXKFS2V1c4KMEr3H9gjrJmQLy0o 5LsUzxcnVVqzLNRrF8VdTGZFcLuO/L/vHbKSg5vsaOUiVuXUfJ4tqA2h5S8fCUWE60 SE/Qkv/fyJ5wuA/T4pf6w6pSk1g9JhK4CD6D26nM= Received: by simark.ca (Postfix, from userid 112) id 825AF1E100; Wed, 23 Apr 2025 00:12:53 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1745381572; bh=gHnqUeMcirprPaPxLl0BFDD+XKv7FeFQMuO4DzgJzb8=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=nZcQ63Eph0PUsyWYDNUkyPJ7PcoaSSPA3Y/2X5DMLmyNfclNMr9aabDmTVexCN1uT jTQd15/TXXmskjYd4OwvDV09yR8s/E17rj4rnzaVNzGbgHIvTIKw8u9X5tAa9UaUvU KGXkpWGSWKKnXbJ1/H6WHGL6nflexrMefD4a44bA= Received: from [10.0.0.11] (modemcable238.237-201-24.mc.videotron.ca [24.201.237.238]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id C71051E05C; Wed, 23 Apr 2025 00:12:52 -0400 (EDT) Message-ID: <1ee3b30b-abed-4d65-82a1-ead349328ccc@simark.ca> Date: Wed, 23 Apr 2025 00:12:52 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 09/28] Remove dwarf2_per_cu_data::mark To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20250402-search-in-psyms-v2-0-ea91704487cb@tromey.com> <20250402-search-in-psyms-v2-9-ea91704487cb@tromey.com> <83b9f38b-22f0-476d-b2dc-0501b41e2738@simark.ca> <87v7qxwmmg.fsf@tromey.com> Content-Language: en-US From: Simon Marchi In-Reply-To: <87v7qxwmmg.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2025-04-21 11:38, Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi writes: > > Simon> Can you choose a different name for these "marked" parameters? That > Simon> name doesn't convey what a mark means. Perhaps "visited_cus", or > Simon> something like that. > > I used cus_to_skip. > > "visited" won't really be accurate by the end of the series, because by > then a CU that's already expanded will still be searched. Fine with me, thanks. > Simon> Also, does the "marked" in "dw2_expand_marked_cus" have the same meaning > Simon> as the "marked" that changed meaning in this patch? If so, does this > Simon> function need to be renamed (does it do the opposite of the what its > Simon> name imply now)? > > I think that is what it mean, and furthermore the function seems > mis-named in other ways, since it isn't primarily concerned with marked > CUs so much as deciding which CUs to expand. > > However I would rather not bother to rename it at this point, since it's > deleted entirely in a subsequent patch in the series. Works for me, thanks!. Simon