From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 100121 invoked by alias); 24 Dec 2018 16:29:51 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 100111 invoked by uid 89); 24 Dec 2018 16:29:51 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-11.9 required=5.0 tests=BAYES_00,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1313 X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 24 Dec 2018 16:29:49 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id wBOGTbfK001953 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 24 Dec 2018 11:29:41 -0500 Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 9E0081E059; Mon, 24 Dec 2018 11:29:36 -0500 (EST) Subject: Re: GDB internal error in pc_in_thread_step_range To: Eli Zaretskii Cc: gdb-patches@sourceware.org References: <83h8kjr8r6.fsf@gnu.org> <100001f1b27aa7d90902a75d5db37710@polymtl.ca> <83a7m6tk92.fsf@gnu.org> <8336qxfpjo.fsf@gnu.org> <83tvjde68l.fsf@gnu.org> <83ftutcy7p.fsf@gnu.org> <659d33b5e4af35aea6c3aaef08559f31@polymtl.ca> <837eg4cick.fsf@gnu.org> <988ca92d2c5c976fbea57c2381eb6279@polymtl.ca> <834lb6ar3g.fsf@gnu.org> <83sgyo8brg.fsf@gnu.org> <83k1jy9a2k.fsf@gnu.org> From: Simon Marchi Message-ID: <1ebc24f4-9b09-4a42-6b24-f43f6641eb9d@polymtl.ca> Date: Mon, 24 Dec 2018 16:29:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.3 MIME-Version: 1.0 In-Reply-To: <83k1jy9a2k.fsf@gnu.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2018-12/txt/msg00302.txt.bz2 On 2018-12-24 11:13 a.m., Eli Zaretskii wrote: >> Cc: gdb-patches@sourceware.org >> From: Simon Marchi >> Date: Sun, 23 Dec 2018 18:31:45 -0500 >> >> On 2018-12-23 11:10 a.m., Eli Zaretskii wrote: >>> Like this? >>> >>> --- gdb/coffread.c~1 2018-07-04 18:41:59.000000000 +0300 >>> +++ gdb/coffread.c 2018-12-23 10:24:15.758116900 +0200 >>> @@ -874,8 +874,10 @@ coff_symtab_read (minimal_symbol_reader >>> int section = cs_to_section (cs, objfile); >>> >>> tmpaddr = cs->c_value; >>> - record_minimal_symbol (reader, cs, tmpaddr, mst_text, >>> - section, objfile); >>> + /* Don't record unresolved symbols. */ >>> + if (!(cs->c_secnum <= 0 && cs->c_value == 0)) >>> + record_minimal_symbol (reader, cs, tmpaddr, mst_text, >>> + section, objfile); >>> >>> fcn_line_ptr = main_aux.x_sym.x_fcnary.x_fcn.x_lnnoptr; >>> fcn_start_addr = tmpaddr; >> >> That looks good to me. > > Should I push it to the master branch? Yes, just make sure to include the relevant info in the commit log. It would be a good idea to link back to this thread, so someone doing archeology can find why we added this. > I'm happy to help with this, but setting up the GDB test suite needs a > Cygwin installation as well, and I don't have that. Ok I see. Simon