From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id fHRwH/boXGD0LwAAWB0awg (envelope-from ) for ; Thu, 25 Mar 2021 15:48:06 -0400 Received: by simark.ca (Postfix, from userid 112) id 73ECC1EF7C; Thu, 25 Mar 2021 15:48:06 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 9859A1E789 for ; Thu, 25 Mar 2021 15:48:05 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 48B693858001; Thu, 25 Mar 2021 19:48:05 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 48B693858001 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1616701685; bh=lP49i5snYKuLJPBZxTkz6LET28+HHBt5J8pH7j9Uv20=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=dv67vmvRnPDQ+sVKcBxyV/HPB86tXKmp7xcQ4Z4pjCB8Pb6g/CNif6Ujp1xm/ejdo iz8usregaVMucgGqaLKTsweYVHg55Tr9AWLJ5YpDj2Ai7Oq5E2XX1u02WBKlkf6VSt ziaL1KWS5U0P2uA+FIrlm8/AZ3BbDf3g+vBDD84w= Received: from mail-qt1-x82c.google.com (mail-qt1-x82c.google.com [IPv6:2607:f8b0:4864:20::82c]) by sourceware.org (Postfix) with ESMTPS id 33F0B385800D for ; Thu, 25 Mar 2021 19:48:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 33F0B385800D Received: by mail-qt1-x82c.google.com with SMTP id f12so2615999qtq.4 for ; Thu, 25 Mar 2021 12:48:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=lP49i5snYKuLJPBZxTkz6LET28+HHBt5J8pH7j9Uv20=; b=ACfEFj2O1AtFXGnjR19jM9pn3q3yw+ZVvc1/qsQHcGgcYQEQY/QIpcqmBpDbfZPprY hcp+CtZbXL/MDg2GfkMGJR1ngWI0SNqnzpB31zlIVervj5p/Yphg1iri5cqWXEmIBwpO M+UsQfHcaxVJsBX3T6yXu5Dj1WNU87wb8Ifo2cdoFwDfdedfQSbebod3973aSLeyQu36 fopVjrSgR6QOIakMpGm2dUitaC5lbEhgsS4QsCT5AphqqMdhMhVXzqVYvF0fBM9J+0Z1 udiFqPDfDLzjkWC7nPSUTTsBip1w4uMdMVX7Pu4HFmXa5b5NxcVGjBkDCOtCmexMLZsG q3vA== X-Gm-Message-State: AOAM5300uaAS9+uF6BK9jWqxIh4+SvFJkB7QJ+M64zNc2U89YYc2CJUP U07KijrCQO3PziaywXmczPjhIkE1WE9Vjw== X-Google-Smtp-Source: ABdhPJylLmgQ9vW2elzz8adVzJ3ynfZ98jOzS45hIt8wgLGNUDLJfVPIG6QCLGejOTF/h1Qgk5f9ag== X-Received: by 2002:ac8:5d52:: with SMTP id g18mr9510329qtx.380.1616701682752; Thu, 25 Mar 2021 12:48:02 -0700 (PDT) Received: from ?IPv6:2804:7f0:4841:2841:9c7b:60f4:124f:3c69? ([2804:7f0:4841:2841:9c7b:60f4:124f:3c69]) by smtp.gmail.com with ESMTPSA id g74sm4885126qke.3.2021.03.25.12.48.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 25 Mar 2021 12:48:02 -0700 (PDT) Subject: Re: [PATCH] Add startswith function and use it instead of CONST_STRNEQ. To: Alan Modra References: <20210319063759.GM6791@bubble.grove.modra.org> <20210320070037.GR6791@bubble.grove.modra.org> <87wnu1k5z1.fsf@tromey.com> <20210321131254.GS6791@bubble.grove.modra.org> <87k0q0j5ql.fsf@tromey.com> <20210322120652.GV6791@bubble.grove.modra.org> <20210322225639.GY6791@bubble.grove.modra.org> <0520bcb8-1945-5f0f-87d1-14785b881c45@linaro.org> <20210325115413.GB5425@bubble.grove.modra.org> Message-ID: <1e7e6f28-c916-f138-63c5-ca27f191f994@linaro.org> Date: Thu, 25 Mar 2021 16:47:59 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210325115413.GB5425@bubble.grove.modra.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Luis Machado via Gdb-patches Reply-To: Luis Machado Cc: Tom Tromey , Alan Modra via Binutils , gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" Hi, On 3/25/21 8:54 AM, Alan Modra wrote: > On Thu, Mar 25, 2021 at 07:53:04AM -0300, Luis Machado wrote: >> On 3/22/21 7:56 PM, Alan Modra wrote: >>> On Mon, Mar 22, 2021 at 01:13:00PM -0300, Luis Machado wrote: >>>> Just FTR, I'm seeing breakage in sim/aarch64 and sim/arm. Both are >>>> complaining about "-Werror=implicit-function-declaration" regarding strncmp >>>> and strlen. >>>> >>>> Is this the breakage you're talking about? Just so I know what to expect >>>> when it gets fixed. >>> >>> Yes. >>> >> >> Thanks. Are there plans to address this or should I come up with a patch? > > I posted a patch here > https://sourceware.org/pipermail/binutils/2021-March/115863.html > It's been tested with gdb, sim and binutils builds. > > Tom offered to solve the problem himself, so I'm waiting on that or > for someone in the gdb camp to review my patch. Since I messed this > up in the first place by taking a comment by Tom as a go-ahead rather > than first posting a patch for proper review by gdb maintainers, I'm > being a little cautious in committing the above patch. > I applied the above patch to today's master binutils-gdb and gave configure's --enable-targets=all a try, but I ran into the following: In file included from ../../../repos/binutils-gdb/bfd/archive.c:135: ./bfd.h:568:1: error: redefinition of ‘startswith’ 568 | startswith (const char *str, const char *prefix) | ^~~~~~~~~~ In file included from ../../../repos/binutils-gdb/bfd/sysdep.h:122, from ../../../repos/binutils-gdb/bfd/archive.c:134: ../../../repos/binutils-gdb/bfd/../include/str-util.h:23:1: note: previous definition of ‘startswith’ was here 23 | startswith (const char *str, const char *prefix) | ^~~~~~~~~~