From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id MUf6D5y4j2dkcxYAWB0awg (envelope-from ) for ; Tue, 21 Jan 2025 10:09:16 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=vt/3jTeV; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=QkrRV9yw; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=vt/3jTeV; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=QkrRV9yw; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 2B4841E100; Tue, 21 Jan 2025 10:09:16 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 6EA801E08E for ; Tue, 21 Jan 2025 10:09:15 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 0DD9E385700A for ; Tue, 21 Jan 2025 15:09:15 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0DD9E385700A Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=vt/3jTeV; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=QkrRV9yw; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=vt/3jTeV; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=QkrRV9yw Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by sourceware.org (Postfix) with ESMTPS id 210E73857727 for ; Tue, 21 Jan 2025 15:08:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 210E73857727 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 210E73857727 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1737472124; cv=none; b=Uf7L1NM5gF5M1h64o3G99aS8+93P3lsoUW/t+famBrENmc0blF0DrTIOtABXCnhCilopykS/r+eOfgV+RsjKHs54qgruFgWzQX1mEN4FGbHm977FbFrdRKaO5jwhpLxEcxAYKDqha4Y7+SKzSr/z/ItovSrUJnmaGipYa2Uibzc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1737472124; c=relaxed/simple; bh=22+u3j0AiqKHRgfIukqwQ+4UGlhkcwNvmiUi15cD/6A=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=KcPnIQ3ldOjtmn7ZudMr3s96wCOd7d1Dk/aePSaCzY0WYWFIU9gBHEi1b74M807tY3ksmqDcsrOXb7l7SdulexYpox7jv7wOX4Iq+W3dUcpMf0dMw/yE918SBW04aPQkIboH8ri7yFZi53wWZY0P0VaK3k9VKfFlP/71QMOEkTk= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 210E73857727 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 0EDEB1F7B9; Tue, 21 Jan 2025 15:08:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1737472123; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DZ0LpSWXR+zgjQBWALz8qpo9V3lAPQUcpto8svDPiAg=; b=vt/3jTeVtAfyTFS0teBUrWPTOYERl0tlLUd8GLUIAknh2oyz+ME8t54M+9EOwXUwdcxEQc y0VDJspn/PdPditkqxnZ9EnruSGFOzUomkylY6e7G/mBI7iEWXvfAIXG9g7MszHp6WCDLB o962QBPThwWJP5oHN4ZQThz4afduCPQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1737472123; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DZ0LpSWXR+zgjQBWALz8qpo9V3lAPQUcpto8svDPiAg=; b=QkrRV9ywxwn9qksVoJ/ujGkCnSuNUljwjyy/ZEQFWYgs2/nAMivjSkWae1e1/7udZIzjyF TgcTtXocgV7YNsAg== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="vt/3jTeV"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=QkrRV9yw DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1737472123; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DZ0LpSWXR+zgjQBWALz8qpo9V3lAPQUcpto8svDPiAg=; b=vt/3jTeVtAfyTFS0teBUrWPTOYERl0tlLUd8GLUIAknh2oyz+ME8t54M+9EOwXUwdcxEQc y0VDJspn/PdPditkqxnZ9EnruSGFOzUomkylY6e7G/mBI7iEWXvfAIXG9g7MszHp6WCDLB o962QBPThwWJP5oHN4ZQThz4afduCPQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1737472123; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DZ0LpSWXR+zgjQBWALz8qpo9V3lAPQUcpto8svDPiAg=; b=QkrRV9ywxwn9qksVoJ/ujGkCnSuNUljwjyy/ZEQFWYgs2/nAMivjSkWae1e1/7udZIzjyF TgcTtXocgV7YNsAg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id EA0461387C; Tue, 21 Jan 2025 15:08:42 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id zmh/N3q4j2dmKwAAD6G6ig (envelope-from ); Tue, 21 Jan 2025 15:08:42 +0000 Message-ID: <1e6e2875-acb5-40e7-99aa-d5d15d245b8e@suse.de> Date: Tue, 21 Jan 2025 16:09:00 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] [gdb/symtab] Fix dwarf version of DWO TU To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20250120085723.5693-1-tdevries@suse.de> <87ikq8pa0o.fsf@tromey.com> Content-Language: en-US From: Tom de Vries In-Reply-To: <87ikq8pa0o.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 0EDEB1F7B9 X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RCPT_COUNT_TWO(0.00)[2]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; ARC_NA(0.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; ASN(0.00)[asn:25478, ipnet:::/0, country:RU]; RCVD_VIA_SMTP_AUTH(0.00)[]; DKIM_TRACE(0.00)[suse.de:+]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo, imap1.dmz-prg2.suse.org:rdns] X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Action: no action X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 1/21/25 14:32, Tom Tromey wrote: >>>>>> "Tom" == Tom de Vries writes: > > Tom> When running test-case gdb.ada/access_tagged_param.exp with target board > Tom> fission, we run into: > Tom> ... > Tom> (gdb) break pck.adb:19^M > Tom> gdb/dwarf2/read.h:289: internal-error: version: \ > Tom> Assertion `m_dwarf_version != 0' failed.^M > Tom> ... > > Tom> - && (cu->per_cu->version () == 2 > Tom> + && (cu->header.version == 2 > > All the stuff in this area seems kind of horrible to me. Like, first of > all, how can this even fail? It seems like the CU version should be set > when setting up the reader. Hi Tom, thanks for the review. The v1 ( https://sourceware.org/pipermail/gdb-patches/2024-October/212676.html ) takes the approach of making sure "cu->per_cu->version ()" is set. Do you prefer that one? Thanks, - Tom > And if not, what's gone wrong there? > Relatedly, can the other callers of version() fail in the same way? > Finally there aren't really that many callers of this method so I wonder > if it can be removed, maybe making this code less fragile. Looking at > it, I feel pretty sure if I needed a version check I'd probably write > code to call this method but ... maybe that's unsafe? > > Tom