From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 56224 invoked by alias); 29 Jun 2016 15:55:11 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 56215 invoked by uid 89); 29 Jun 2016 15:55:11 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:696 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 29 Jun 2016 15:55:01 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A96856438E; Wed, 29 Jun 2016 15:54:59 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u5TFsw3q001372; Wed, 29 Jun 2016 11:54:58 -0400 Subject: Re: [PATCH] Initialize strtok_r's saveptr to NULL To: Manish Goregaokar , gdb-patches@sourceware.org References: From: Pedro Alves Message-ID: <1e5e845a-9e46-59a8-bd7f-38cdff165b29@redhat.com> Date: Wed, 29 Jun 2016 15:55:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-SW-Source: 2016-06/txt/msg00520.txt.bz2 On 06/29/2016 03:25 PM, Pedro Alves wrote: > gcc 7 shows a bit more detail, though it's still not very clear: > > /home/pedro/gdb/mygit/src/gdb/rust-lang.c: In function ‘rust_get_disr_info.isra.5’: > /home/pedro/gdb/mygit/src/gdb/rust-lang.c:173:15: error: ‘__s’ may be used uninitialized in this function [-Werror=maybe-uninitialized] > ret.name = concat (TYPE_NAME (type), "::", token, (char *) NULL); > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > cc1: some warnings being treated as errors > > > The mention of "__s" is a hint. Filed this one as: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71701 Thanks, Pedro Alves