From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 114737 invoked by alias); 18 Apr 2017 20:20:46 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 114700 invoked by uid 89); 18 Apr 2017 20:20:45 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-11.9 required=5.0 tests=BAYES_00,GIT_PATCH_2,GIT_PATCH_3,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 18 Apr 2017 20:20:43 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id AD771C059752; Tue, 18 Apr 2017 20:20:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com AD771C059752 Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com AD771C059752 Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.phx2.redhat.com [10.5.9.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 17D8B83298; Tue, 18 Apr 2017 20:20:42 +0000 (UTC) Subject: Re: [PATCH 1/4] Change field separator in gdbarch.sh To: Simon Marchi , gdb-patches@sourceware.org References: <20170416141430.2585-1-simon.marchi@polymtl.ca> <20170416141430.2585-2-simon.marchi@polymtl.ca> From: Pedro Alves Message-ID: <1e5568c8-eead-c0b1-8b34-736b9b6ff5d0@redhat.com> Date: Tue, 18 Apr 2017 20:20:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20170416141430.2585-2-simon.marchi@polymtl.ca> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-04/txt/msg00530.txt.bz2 On 04/16/2017 03:14 PM, Simon Marchi wrote: > --- a/gdb/gdbarch.h > +++ b/gdb/gdbarch.h > @@ -129,7 +129,7 @@ extern void set_gdbarch_bits_big_endian (struct gdbarch *gdbarch, int bits_big_e > > /* Number of bits in a char or unsigned char for the target machine. > Just like CHAR_BIT in but describes the target machine. > - v:TARGET_CHAR_BIT:int:char_bit::::8 * sizeof (char):8::0: > + v;TARGET_CHAR_BIT;int;char_bit;;;;8 * sizeof (char);8;;0; BTW, do you know why does this bit appear in the .h file in the first place? Thanks, Pedro Alves