From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id tWpJHe8kDGGIOQAAWB0awg (envelope-from ) for ; Thu, 05 Aug 2021 13:50:39 -0400 Received: by simark.ca (Postfix, from userid 112) id 679D01EDE3; Thu, 5 Aug 2021 13:50:39 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H2,RDNS_DYNAMIC, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A5C571E813 for ; Thu, 5 Aug 2021 13:50:37 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 0CCA8396902B for ; Thu, 5 Aug 2021 17:50:37 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0CCA8396902B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1628185837; bh=eRqXNZReHCpiH8X/tpuUCeYRmUrTQgxWfX7k47XQrZA=; h=Subject:To:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=b1pksg5XMaNc2tkTw3D4c7ug/rbd86nY2G16J2YXtpugsVBiSaXEZBQeabOSHBMPK sD3UpRfCEaXBwYHgaM9URIPupcrLUb/AXkhi2+osV6OxDD0q6fMgoM4ijFz4z7XXAJ FwgzqVmkOrm09CSmgfaKO8OqDUNb/Wzthxj45tsQ= Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id E09943857C6F for ; Thu, 5 Aug 2021 17:50:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E09943857C6F Received: from pps.filterd (m0098399.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 175HgoaC026411 for ; Thu, 5 Aug 2021 13:50:16 -0400 Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 3a8k452x3k-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 05 Aug 2021 13:50:15 -0400 Received: from m0098399.ppops.net (m0098399.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 175HhfYR028707 for ; Thu, 5 Aug 2021 13:50:15 -0400 Received: from ppma02wdc.us.ibm.com (aa.5b.37a9.ip4.static.sl-reverse.com [169.55.91.170]) by mx0a-001b2d01.pphosted.com with ESMTP id 3a8k452x2p-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 05 Aug 2021 13:50:15 -0400 Received: from pps.filterd (ppma02wdc.us.ibm.com [127.0.0.1]) by ppma02wdc.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 175HmgC7024497; Thu, 5 Aug 2021 17:50:14 GMT Received: from b03cxnp08025.gho.boulder.ibm.com (b03cxnp08025.gho.boulder.ibm.com [9.17.130.17]) by ppma02wdc.us.ibm.com with ESMTP id 3a6nhxqcm0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 05 Aug 2021 17:50:14 +0000 Received: from b03ledav004.gho.boulder.ibm.com (b03ledav004.gho.boulder.ibm.com [9.17.130.235]) by b03cxnp08025.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 175HoCu148234794 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 5 Aug 2021 17:50:12 GMT Received: from b03ledav004.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id CB97578068; Thu, 5 Aug 2021 17:50:12 +0000 (GMT) Received: from b03ledav004.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0228578092; Thu, 5 Aug 2021 17:50:10 +0000 (GMT) Received: from lexx (unknown [9.171.49.56]) by b03ledav004.gho.boulder.ibm.com (Postfix) with ESMTP; Thu, 5 Aug 2021 17:50:10 +0000 (GMT) Message-ID: <1e42e4781b6465743c415950628bf09608cb931f.camel@vnet.ibm.com> Subject: Re: [Patch v2] Handle .TOC. sections during gdb-compile for rs6000 target. To: Ulrich Weigand , Alan Modra Date: Thu, 05 Aug 2021 12:50:09 -0500 In-Reply-To: References: <21185e6d3118c97c9dde66df366bb9ff3b31dede.camel@vnet.ibm.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 (3.28.5-10.el7) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: wrlCUTK29-lsJ2NRcJOams7nmZz1Ox7M X-Proofpoint-ORIG-GUID: x0loa8xzv7CZXs9SI_zmvEZC9lvX19Eo X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.790 definitions=2021-08-05_10:2021-08-05, 2021-08-05 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 spamscore=0 clxscore=1015 impostorscore=0 mlxscore=0 adultscore=0 phishscore=0 priorityscore=1501 suspectscore=0 malwarescore=0 mlxlogscore=876 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2107140000 definitions=main-2108050104 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: will schmidt via Gdb-patches Reply-To: will schmidt Cc: rogerio , "gdb-patches@sourceware.org" Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On Thu, 2021-07-29 at 13:49 +0200, Ulrich Weigand wrote: > "Alan Modra" wrote on 29.07.2021 10:26:11: > > On Thu, Jul 29, 2021 at 09:18:18AM +0200, Ulrich Weigand wrote: > > > > > > > > > "will schmidt" wrote on 28.07.2021 > 21:08:21: > > > > > > > + sym->section = toc_fallback; > > > > + sym->value = 0x8000; > > > > + bfd_set_gp_value(abfd.get(), toc_fallback->vma); > > > > > > For compatibility with BFD, shouldn't this be rather: > > > > > > bfd_set_gp_value(abfd.get(), toc_fallback->vma + sym- > >value); > > > > > > Alan, can you confirm? > > > > No, see bfd/elf64-ppc.c:ppc64_elf_sec_toc. A long time ago I chose > > the value of elf_gp used in elf64-ppc.c to be the start of the toc > > section rather than the value of ".TOC.". The value is somewhat > > arbitrary. Yes, I could change it to be the value of .TOC., but > for > > now the value above is correct. > > I see, thanks for the explanation. > > Will, the patch is OK for trunk then. Committed with some additional indentation and cosmetic tweaks, Thanks -WIll > > Thanks, > Ulrich > >