From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 7KrvMfcUDGYyUyAAWB0awg (envelope-from ) for ; Tue, 02 Apr 2024 10:23:51 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=EgTW0Fqf; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=HvJEewNW; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id B7C911E0C0; Tue, 2 Apr 2024 10:23:51 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 5F3611E030 for ; Tue, 2 Apr 2024 10:23:49 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 07C3D385842A for ; Tue, 2 Apr 2024 14:23:48 +0000 (GMT) Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by sourceware.org (Postfix) with ESMTPS id 323723858CDB for ; Tue, 2 Apr 2024 14:23:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 323723858CDB Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 323723858CDB Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712067805; cv=none; b=BFC/omZS/P2DRnQOkXy13+y0yp60XL5kLyW2BRkminM4mlJ3T/wj+UhaMbZCSCMxUZVLyIFcHY+DRbqtS6jOF5ADoNTKxZ5YIUrYqG7CQrCo3w4RrGd5kED4lGHAET+nrKyTJ7ldH39ARJ+JGN+wSV+sMEluvTUMdXi3Ro/GWsY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712067805; c=relaxed/simple; bh=o9NQPdYdKQoEEZWSTF6jAcFrWj547WncCYAIo5z4zfc=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:MIME-Version: Subject:To:From; b=gWIq0NF7IOjTegI0EFchKUoaaXc9c9/mWj7Qm58XlEm8fL9hPVZDbdtZVOvkb5GwxLtyCKsAq6rnCOO52eGj3hbf8H5aYrEfUo9ysxi7Xh6/pbIePqlB+q5vXW+Se9+SsyeDNV8pSQngveg0A4/h7Zf/2rRQ2w/Wq8FloyUZ9Ow= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap2.dmz-prg2.suse.org (imap2.dmz-prg2.suse.org [10.150.64.98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 49B7D3476A; Tue, 2 Apr 2024 14:23:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1712067803; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Bn1lrEIsMaCGRomDWDLMdtPUV6rtDRC0IVxFW/BpIWg=; b=EgTW0FqfXWZZJKlbuf6QqB/14RNBnZ51zhd347TDvOdpE04i2v6ZkdQebmzrX42JFnqt0J cPVPJl7EDR6U3BqROe7QAn7VapquxunJczohUqZpM/UuWrJhS1vEdth/LKU1M0WXkjibzc S8eiEbu7Gc60DnmdVsCmvsy1Ds92cjs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1712067803; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Bn1lrEIsMaCGRomDWDLMdtPUV6rtDRC0IVxFW/BpIWg=; b=HvJEewNWfj+NITlm31rKjBbi6e/j7KX0QEK1R9TSiIUeYogoZOZyeF7i+fs7PcgncFCRAO kwzuHJesWNUp6dCQ== Authentication-Results: smtp-out1.suse.de; none Received: from imap2.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap2.dmz-prg2.suse.org (Postfix) with ESMTPS id 2966413A90; Tue, 2 Apr 2024 14:23:23 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap2.dmz-prg2.suse.org with ESMTPSA id 9e8TBdsUDGb3ZgAAn2gu4w (envelope-from ); Tue, 02 Apr 2024 14:23:23 +0000 Message-ID: <1dd28397-74f4-4302-af4d-d7d0120093ed@suse.de> Date: Tue, 2 Apr 2024 16:23:35 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] [gdb/tetsuite] Add missing include in gdb.base/ctf-ptype.c Content-Language: en-US To: Tom Tromey , John Baldwin Cc: gdb-patches@sourceware.org References: <20240327143038.20021-1-tdevries@suse.de> <364a5861-a4a2-47ba-9253-5c564c41ebe3@FreeBSD.org> <87bk6taxrj.fsf@tromey.com> From: Tom de Vries In-Reply-To: <87bk6taxrj.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spamd-Result: default: False [-0.42 / 50.00]; NEURAL_HAM_SHORT(-0.20)[-1.000]; BAYES_HAM(-0.13)[67.53%]; MIME_GOOD(-0.10)[text/plain]; XM_UA_NO_VERSION(0.01)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_VIA_SMTP_AUTH(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; RCPT_COUNT_THREE(0.00)[3] X-Spam-Score: -0.42 X-Spam-Level: X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org On 4/1/24 17:49, Tom Tromey wrote: >>>>>> "John" == John Baldwin writes: > >>> int main () >>> { >>> - /* Ensure that malloc is a pointer type; avoid use of "void" and any include files. */ >>> -/* extern char *malloc();*/ >>> - > > John> This certainly seems curious. Nothing in the commit log for when this was added > John> gives any clue to why this comment is here, nor why the prototype is commented > John> out. Other comments later in this function mention limitations of the linker on > John> AIX, which makes me wonder how it was tested originally. Did you confirm that > John> the test program compiled contained CTF but not DWARF when the test passed? > > This file was apparently just copy-pasted from ptype.c, which has this > same commented-out line. It probably dates to the stabs days. I > wouldn't worry too much about it... it could use a scrubbing and perhaps > should be moved to gdb.ctf anyway. OK, in that case ... pushed. Thanks, - Tom