From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 66806 invoked by alias); 2 Jun 2017 18:42:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 66797 invoked by uid 89); 2 Jun 2017 18:42:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 02 Jun 2017 18:42:28 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 224FE4E358; Fri, 2 Jun 2017 18:42:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 224FE4E358 Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 224FE4E358 Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 77EF360BEF; Fri, 2 Jun 2017 18:42:30 +0000 (UTC) Subject: Re: [RFA 14/23] Use unique_xmalloc_ptr in jit.c To: Tom Tromey , gdb-patches@sourceware.org References: <20170503224626.2818-1-tom@tromey.com> <20170503224626.2818-15-tom@tromey.com> From: Pedro Alves Message-ID: <1dcc01cc-3521-af8d-7554-19668a02a06a@redhat.com> Date: Fri, 02 Jun 2017 18:42:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20170503224626.2818-15-tom@tromey.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-06/txt/msg00065.txt.bz2 On 05/03/2017 11:46 PM, Tom Tromey wrote: > static void > jit_reader_load_command (char *args, int from_tty) > { > - char *so_name; > - struct cleanup *prev_cleanup; > - > if (args == NULL) > error (_("No reader name provided.")); > - args = tilde_expand (args); > - prev_cleanup = make_cleanup (xfree, args); > + gdb::unique_xmalloc_ptr file (tilde_expand (args)); > > if (loaded_jit_reader != NULL) > error (_("JIT reader already loaded. Run jit-reader-unload first.")); > > - if (IS_ABSOLUTE_PATH (args)) > - so_name = args; > + gdb::unique_xmalloc_ptr so_name; > + if (IS_ABSOLUTE_PATH (file.get ())) > + so_name = std::move (file); I think we don't really need two unique pointers, and then moving. I.e., this should do, I think: if (loaded_jit_reader != NULL) error (_("JIT reader already loaded. Run jit-reader-unload first.")); gdb::unique_xmalloc_ptr so_name (tilde_expand (args)); if (!IS_ABSOLUTE_PATH (so_name.get ())) so_name.reset (xstrprintf ("%s%s%s", jit_reader_dir, SLASH_STRING, so_name.get ())); Thanks, Pedro Alves