From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id B3bMCmIB7Wgcgy4AWB0awg (envelope-from ) for ; Mon, 13 Oct 2025 09:40:50 -0400 Received: by simark.ca (Postfix, from userid 112) id 1E3F31E047; Mon, 13 Oct 2025 09:40:50 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.3 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 093511E047 for ; Mon, 13 Oct 2025 09:40:49 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 725243858CDA for ; Mon, 13 Oct 2025 13:40:47 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 725243858CDA Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by sourceware.org (Postfix) with ESMTP id D13063858D26 for ; Mon, 13 Oct 2025 13:40:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D13063858D26 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D13063858D26 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=217.140.110.172 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1760362811; cv=none; b=OMKP3Q5dcgLJGGqpWv+obTyOfbffLUexOvgYp5Y8T5WRVUfggmGvuz/RNp2c3ZoCf8qhXpcMMkhPSOmQAzdK3eftX0vdy8pjpQW2tgBUkUNMZzDFoSYsCdATk647WE3FwmQSACP0Exnc00y5wlx6+Dg4nLxUNQCMwYJXxDknnEk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1760362811; c=relaxed/simple; bh=xxsSYdwHowuxZoqN/1rHrprfxmBB2W+7KG6czISQ+ic=; h=Message-ID:Date:MIME-Version:Subject:To:From; b=abEiYRO+/mMoWJBhYUTtvqL5SNdftyo472Er+RHw/UCk4yE8tiDwpfVIabgE3635AuqTLRnEOWPND28Zercnr18oGYTZvQZy3Omd12NLrL6nsIGItVywlaw/2W7jrmKTXdy12ax7R1iQHQJtX6ga0a2ppx/xxWGoaQCtyouMGK4= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D13063858D26 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id BD04C113E; Mon, 13 Oct 2025 06:40:01 -0700 (PDT) Received: from [10.57.1.191] (unknown [10.57.1.191]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id DF2EC3F66E; Mon, 13 Oct 2025 06:40:08 -0700 (PDT) Message-ID: <1db3bf19-02e4-40bb-adf7-6355b176e0f2@arm.com> Date: Mon, 13 Oct 2025 14:40:07 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/5] gdbserver/aarch64: Enable FPMR for AArch64 in gdbserver on Linux To: Luis , Ezra.Sitorus@arm.com, gdb-patches@sourceware.org Cc: thiago.bauermann@linaro.org References: <20251007123132.26769-1-Ezra.Sitorus@arm.com> <20251007123132.26769-3-Ezra.Sitorus@arm.com> <5bff9203-f0f8-4661-8aff-7b28d758416b@gmail.com> Content-Language: en-GB From: Richard Earnshaw In-Reply-To: <5bff9203-f0f8-4661-8aff-7b28d758416b@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 11/10/2025 12:50, Luis wrote: > On 07/10/2025 13:31, Ezra.Sitorus@arm.com wrote: >> From: Ezra Sitorus >> >> Support FPMR in gdbserver. > > Nit. Make it "Add support for FPMR register set in gdbserver." > > It is a bit more descriptive. But grammatically wrong, since FPMR is short for Floating Point Mode Register. So then you'd have: Add support for the floating point mode register register set in gdbserver!!!! R. > >> --- >> Changes from v1->v2: >> * Updated comments >> * Use HWCAP2_FPMR in aarch64_target::low_arch_setup >> >> Ezra >> >>   gdbserver/linux-aarch64-low.cc | 29 +++++++++++++++++++++++++++++ >>   1 file changed, 29 insertions(+) >> >> diff --git a/gdbserver/linux-aarch64-low.cc b/gdbserver/linux-aarch64- >> low.cc >> index 9d3ac803e7b..73db8f52ed5 100644 >> --- a/gdbserver/linux-aarch64-low.cc >> +++ b/gdbserver/linux-aarch64-low.cc >> @@ -248,6 +248,26 @@ aarch64_store_fpregset (struct regcache >> *regcache, const void *buf) >>     supply_register (regcache, AARCH64_FPCR_REGNUM, ®set->fpcr); >>   } >> +/* Fill BUF with the FPMR register from the regcache.  */ >> + >> +static void >> +aarch64_fill_fpmr_regset (struct regcache *regcache, void *buf) >> +{ >> +  uint64_t *fpmr = (uint64_t *) buf; >> +  int fpmr_regnum = find_regno (regcache->tdesc, "fpmr"); >> +  collect_register (regcache, fpmr_regnum, fpmr); >> +} >> + >> +/* Store the FPMR register to regcache.  */ >> + >> +static void >> +aarch64_store_fpmr_regset (struct regcache *regcache, const void *buf) >> +{ >> +  uint64_t *fpmr = (uint64_t *) buf; >> +  int fpmr_regnum = find_regno (regcache->tdesc, "fpmr"); >> +  supply_register (regcache, fpmr_regnum, fpmr); >> +} >> + >>   /* Store the pauth registers to regcache.  */ >>   static void >> @@ -879,6 +899,10 @@ static struct regset_info aarch64_regsets[] = >>     { PTRACE_GETREGSET, PTRACE_SETREGSET, NT_ARM_TAGGED_ADDR_CTRL, >>       0, OPTIONAL_REGS, >>       aarch64_fill_mteregset, aarch64_store_mteregset }, >> +  /* Floating Point Mode Register (FPMR).  */ >> +  { PTRACE_GETREGSET, PTRACE_SETREGSET, NT_ARM_FPMR, >> +    0, OPTIONAL_REGS, >> +    aarch64_fill_fpmr_regset, aarch64_store_fpmr_regset }, >>     /* TLS register.  */ >>     { PTRACE_GETREGSET, PTRACE_SETREGSET, NT_ARM_TLS, >>       0, OPTIONAL_REGS, >> @@ -954,6 +978,10 @@ aarch64_adjust_register_sets (const struct >> aarch64_features &features) >>         if (features.gcs_linux) >>           regset->size = sizeof (user_gcs); >>         break; >> +    case NT_ARM_FPMR: >> +      if (features.fpmr) >> +        regset->size = sizeof (uint64_t); >> +      break; >>       default: >>         gdb_assert_not_reached ("Unknown register set found."); >>       } >> @@ -986,6 +1014,7 @@ aarch64_target::low_arch_setup () >>         features.mte = linux_get_hwcap2 (pid, 8) & HWCAP2_MTE; >>         features.tls = aarch64_tls_register_count (tid); >>         features.gcs = features.gcs_linux = linux_get_hwcap (pid, 8) & >> HWCAP_GCS; >> +      features.fpmr = linux_get_hwcap2 (pid, 8) & HWCAP2_FPMR; >>         /* Scalable Matrix Extension feature and size check.  */ >>         if (linux_get_hwcap2 (pid, 8) & HWCAP2_SME) > > This one looks OK and should be fine to push once we have the rest of > the series OK-ed > > Approved-By: Luis Machado