From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 65131 invoked by alias); 19 Feb 2019 02:48:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 64872 invoked by uid 89); 19 Feb 2019 02:47:59 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:776 X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 19 Feb 2019 02:47:58 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id x1J2lqH9008719 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 18 Feb 2019 21:47:57 -0500 Received: by simark.ca (Postfix, from userid 112) id 4178D1E656; Mon, 18 Feb 2019 21:47:52 -0500 (EST) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 6F42E1E16B; Mon, 18 Feb 2019 21:47:50 -0500 (EST) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 19 Feb 2019 02:48:00 -0000 From: Simon Marchi To: Kevin Buettner Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 0/4] Define gdb.Value(val, type) constructor In-Reply-To: <20190218075816.6f67f3d9@f29-4.lan> References: <20190218075816.6f67f3d9@f29-4.lan> Message-ID: <1da692ad72b4d871a93161f41c8d46f2@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.6 X-IsSubscribed: yes X-SW-Source: 2019-02/txt/msg00299.txt.bz2 On 2019-02-18 09:58, Kevin Buettner wrote: > This four part patch series defines a two argument constructor for > gdb.Value. > > gdb.Value currently has a one argument constructor. It takes a python > value, figures out some potentially suitable gdb type and then > constructs a gdb value of that type. > > The two argument version that I'm introducing is useful for > constructing a gdb value of a specified type from a buffer of bytes. > It takes the form gdb.Value (val, type). VAL is a python buffer > object, > i.e. an object from which bytes may be read using python's buffer > protocol. TYPE is a gdb type perhaps obtained by calling > gdb.lookup_type(). Apart from the two small nits I sent, this LGTM. Simon